Skip to content

fix: stabilize OpenTelemetry exporter builder API - #2257

Merged
zeitlinger merged 3 commits into
mainfrom
fix/deprecate-otel-exporter-reader-ctor
Jul 2, 2026
Merged

fix: stabilize OpenTelemetry exporter builder API#2257
zeitlinger merged 3 commits into
mainfrom
fix/deprecate-otel-exporter-reader-ctor

Conversation

@zeitlinger

@zeitlingerzeitlinger commented Jun 26, 2026

Copy link
Copy Markdown
Member

Blocked by #2265 - to make sure that breaking api change is correctly flagged

Summary

  • deprecate the OpenTelemetryExporter(MetricReader) constructor instead of treating it as stable API
  • make the builder entry points the stable surface for OpenTelemetryExporter
  • grandfather the already-accepted constructor removal in the API diff workflow so unrelated PRs stop inheriting the failure on main

Testing

  • mise run lint:fix
  • mise run build
  • ./mvnw -B verify -pl prometheus-metrics-exporter-opentelemetry,prometheus-metrics-exporter-opentelemetry-shaded -am -P 'api-diff,!examples-and-integration-tests' -DskipTests -Dcoverage.skip=true -Dcheckstyle.skip=true -Dwarnings=-nowarn

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger
zeitlingerforce-pushed the fix/deprecate-otel-exporter-reader-ctor branch from 8342b7a to 46b6f9dCompareJune 26, 2026 14:59
@github-actions

github-actionsBot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ Breaking API changes detected — maintainer review required

This PR modifies the published API diff for the following module(s):

  • prometheus-metrics-exporter-opentelemetry
  • prometheus-metrics-exporter-opentelemetry-shaded

The committed API diff contains breaking-change markers for:

  • prometheus-metrics-exporter-opentelemetry
  • prometheus-metrics-exporter-opentelemetry-shaded

Please review the changes in docs/apidiffs/current_vs_latest/ carefully before approving.

@zeitlinger
zeitlinger enabled auto-merge (squash) July 2, 2026 10:12
@zeitlinger
zeitlinger merged commit 09e6e2d into mainJul 2, 2026
22 checks passed
@zeitlinger
zeitlinger deleted the fix/deprecate-otel-exporter-reader-ctor branch July 2, 2026 10:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zeitlinger@jaydeluca