From 3b1c8a444b3ebd019b31c5791acbadc00a27d5c9 Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Sun, 23 Aug 2026 12:30:05 -0700 Subject: [PATCH] Correct repo-gate-exclude-globs Description: eol Never Reads the Tracked List Real finding from coderabbitai on PR #959 (the develop -> main promotion PR carrying #958's exclude-globs work), reproduced before the fix. `repo-gate-exclude-globs`'s description claimed it narrows what `sha-pin`, `eol`, and `eol-coverage` scan, but `check_eol()` never reads its `files` parameter at all: it only compares `.editorconfig` and `.gitattributes` content directly. Only `sha-pin` (via `workflow_files(files)`) and the tracked-path portion of `eol-coverage` (via its shebang scan) actually narrow with the exclude list. ## The fix `.github/workflows/validate-task.yml`: dropped `eol` from the description, per CodeRabbit's own proposed wording. ## Verified `python3 scripts/repo_gate.py`, `prose_lint.py --diff origin/develop`, and a YAML parse of the edited file all pass clean. The change is a one-line description string; no behavior changed. --- .github/workflows/validate-task.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-task.yml b/.github/workflows/validate-task.yml index 47efcfd7..74fc5030 100644 --- a/.github/workflows/validate-task.yml +++ b/.github/workflows/validate-task.yml @@ -16,7 +16,7 @@ on: default: '' # Threaded to the repo-gate composite action's own exclude-globs input, unvalidated. repo-gate-exclude-globs: - description: Git pathspec patterns to exclude, one per line (for example 'themes/PaperMod/**'), narrowing what sha-pin/eol/eol-coverage scan via repo_gate.py's --exclude. + description: Git pathspec patterns to exclude, one per line (for example 'themes/PaperMod/**'), narrowing sha-pin and tracked-path eol-coverage scans via repo_gate.py's --exclude. required: false type: string default: ''