From 8f07cfbd3a1ef9f4e5c7680d5e2ce2500eef5cbb Mon Sep 17 00:00:00 2001 From: Srijan Saurav Date: Sun, 15 Dec 2019 23:40:11 +0530 Subject: [PATCH 1/2] Fix minor code quality issues Changes: - Use `_` for unused variables - Use `"""` for docstrings - Add `.deepsource.toml` file to run continuous static analysis on repository with DeepSource --- .deepsource.toml | 13 +++++++++++++ xarray/util/print_versions.py | 6 +++--- 2 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 .deepsource.toml diff --git a/.deepsource.toml b/.deepsource.toml new file mode 100644 index 00000000000..7eff5e3940c --- /dev/null +++ b/.deepsource.toml @@ -0,0 +1,13 @@ +version = 1 + +test_patterns = [ + "xarray/tests/**" +] + +[[analyzers]] +name = "python" +enabled = true + + [analyzers.meta] + runtime_version = "3.x.x" + type_checker = "mypy" diff --git a/xarray/util/print_versions.py b/xarray/util/print_versions.py index 0d6d147f0bb..9b304c3c8e6 100755 --- a/xarray/util/print_versions.py +++ b/xarray/util/print_versions.py @@ -9,7 +9,7 @@ def get_sys_info(): - "Returns system information as a dict" + """Returns system information as a dict""" blob = [] @@ -22,7 +22,7 @@ def get_sys_info(): stdout=subprocess.PIPE, stderr=subprocess.PIPE, ) - so, serr = pipe.communicate() + so, _ = pipe.communicate() except Exception: pass else: @@ -37,7 +37,7 @@ def get_sys_info(): blob.append(("commit", commit)) try: - (sysname, nodename, release, version, machine, processor) = platform.uname() + (sysname, _nodename, release, _version, machine, processor) = platform.uname() blob.extend( [ ("python", sys.version), From 17c7edad652e98dc0467e045c37113645c58dab7 Mon Sep 17 00:00:00 2001 From: Maximilian Roos <5635139+max-sixty@users.noreply.github.com> Date: Wed, 4 Mar 2020 23:46:26 -0500 Subject: [PATCH 2/2] Remove deepsource @sauravsrijan best of luck with your project, even if we won't be the first library to take this up --- .deepsource.toml | 13 ------------- 1 file changed, 13 deletions(-) delete mode 100644 .deepsource.toml diff --git a/.deepsource.toml b/.deepsource.toml deleted file mode 100644 index 7eff5e3940c..00000000000 --- a/.deepsource.toml +++ /dev/null @@ -1,13 +0,0 @@ -version = 1 - -test_patterns = [ - "xarray/tests/**" -] - -[[analyzers]] -name = "python" -enabled = true - - [analyzers.meta] - runtime_version = "3.x.x" - type_checker = "mypy"