address review: reuse array.typecodes

skirpichev · skirpichev · commit 37738f449202 · 2026-06-01T13:58:34.000+03:00
diff --git a/Lib/test/test_array.py b/Lib/test/test_array.py
@@ -26,9 +26,7 @@ class ArraySubclassWithKwargs(array.array):
 def __init__(self, typecode, newarg=None):
 array.array.__init__(self)
 
-typecodes = (
- 'w', 'b', 'B', 'h', 'H', 'i', 'I', 'l', 'L',
- 'f', 'd', 'q', 'Q', 'e', 'Zf', 'Zd')
+typecodes = array.typecodes
 
 
 class MiscTest(unittest.TestCase):
diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py
@@ -1783,7 +1783,7 @@ def test_bug_6561(self):
 def test_empty_array(self):
 # SF buf 1647541
 import array
- for typecode in 'bBhwHiIlLfd':
+ for typecode in array.typecodes:
 a = array.array(typecode)
 self.assertIsNone(re.compile(b"bla").match(a))
 self.assertEqual(re.compile(b"").match(a).groups(), ())

-Original file line number
+Diff line change
 def__init__(self, typecode, newarg=None):
 array.array.__init__(self)
 -typecodes= (
 -'w', 'b', 'B', 'h', 'H', 'i', 'I', 'l', 'L',
 -'f', 'd', 'q', 'Q', 'e', 'Zf', 'Zd')
 +typecodes=array.typecodes
 classMiscTest(unittest.TestCase):