bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)

Author: asvetlov

Lib/test/test_asyncio/test_threads.py

@@ -5,87 +5,58 @@
 
 fromcontextvarsimportContextVar
 fromunittestimportmock
-fromtest.test_asyncioimportutilsastest_utils
 
 
 deftearDownModule():
 asyncio.set_event_loop_policy(None)
 
 
-classToThreadTests(test_utils.TestCase):
-defsetUp(self):
-super().setUp()
-self.loop=asyncio.new_event_loop()
-asyncio.set_event_loop(self.loop)
-
-deftearDown(self):
-self.loop.run_until_complete(
-self.loop.shutdown_default_executor())
-self.loop.close()
-asyncio.set_event_loop(None)
-self.loop=None
-super().tearDown()
-
-deftest_to_thread(self):
-asyncdefmain():
-returnawaitasyncio.to_thread(sum, [40, 2])
-
-result=self.loop.run_until_complete(main())
+classToThreadTests(unittest.IsolatedAsyncioTestCase):
+asyncdeftest_to_thread(self):
+result=awaitasyncio.to_thread(sum, [40, 2])
 self.assertEqual(result, 42)
 
-deftest_to_thread_exception(self):
+asyncdeftest_to_thread_exception(self):
 defraise_runtime():
 raiseRuntimeError("test")
 
-asyncdefmain():
-awaitasyncio.to_thread(raise_runtime)
-
 withself.assertRaisesRegex(RuntimeError, "test"):
-self.loop.run_until_complete(main())
+awaitasyncio.to_thread(raise_runtime)
 
-deftest_to_thread_once(self):
+asyncdeftest_to_thread_once(self):
 func=mock.Mock()
 
-asyncdefmain():
-awaitasyncio.to_thread(func)
-
-self.loop.run_until_complete(main())
+awaitasyncio.to_thread(func)
 func.assert_called_once()
 
-deftest_to_thread_concurrent(self):
+asyncdeftest_to_thread_concurrent(self):
 func=mock.Mock()
 
-asyncdefmain():
-futs= []
-for_inrange(10):
-fut=asyncio.to_thread(func)
-futs.append(fut)
-awaitasyncio.gather(*futs)
+futs= []
+for_inrange(10):
+fut=asyncio.to_thread(func)
+futs.append(fut)
+awaitasyncio.gather(*futs)
 
-self.loop.run_until_complete(main())
 self.assertEqual(func.call_count, 10)
 
-deftest_to_thread_args_kwargs(self):
+asyncdeftest_to_thread_args_kwargs(self):
 # Unlike run_in_executor(), to_thread() should directly accept kwargs.
 func=mock.Mock()
 
-asyncdefmain():
-awaitasyncio.to_thread(func, 'test', something=True)
+awaitasyncio.to_thread(func, 'test', something=True)
 
-self.loop.run_until_complete(main())
 func.assert_called_once_with('test', something=True)
 
-deftest_to_thread_contextvars(self):
+asyncdeftest_to_thread_contextvars(self):
 test_ctx=ContextVar('test_ctx')
 
 defget_ctx():
 returntest_ctx.get()
 
-asyncdefmain():
-test_ctx.set('parrot')
-returnawaitasyncio.to_thread(get_ctx)
+test_ctx.set('parrot')
+result=awaitasyncio.to_thread(get_ctx)
 
-result=self.loop.run_until_complete(main())
 self.assertEqual(result, 'parrot')
 
 

Misc/NEWS.d/next/Tests/2022-03-23-22-45-51.bpo-47104._esUq8.rst

@@ -0,0 +1,2 @@
+Rewrite :func:`asyncio.to_thread` tests to use
+:class:`unittest.IsolatedAsyncioTestCase`.