Skip to content

Remove the ability to bring your own flatc #9145

Description

@jathu

We currently build flatc from source, however we also:

  • Allow people to bring their own flatc via the FLATC_EXECUTABLE flag
  • Install flatc from pip for some builds

Given we rely on flatbuffers headers from the one we import, I think we should make this completely hermetic and always build flatc from source.

What are some reasons to allow bringing in flatc?

cc @larryliu0820@lucylq

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

actionableItems in the backlog waiting for an appropriate impl/fixgood first issueGood for newcomersmodule: build/installIssues related to the cmake and buck2 builds, and to installing ExecuTorch

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions