Enable Performance panel by default (#216)

Author: huntie

front_end/core/rn_experiments/experimentsImpl.ts

@@ -185,13 +185,6 @@ Instance.register({
 enabledByDefault: ({ isReactNativeEntryPoint })=>isReactNativeEntryPoint,
 });
 
-Instance.register({
-name: RNExperimentName.ENABLE_PERFORMANCE_PANEL,
-title: 'Enable Performance panel',
-unstable: true,
-enabledByDefault: ({ isReactNativeEntryPoint })=>!isReactNativeEntryPoint,
-});
-
 Instance.register({
 name: RNExperimentName.ENABLE_NETWORK_PANEL,
 title: 'Enable Network panel',

front_end/core/root/Runtime.ts

@@ -305,7 +305,6 @@ export const experiments = new ExperimentsSupport();
 exportenumRNExperimentName{
 REACT_NATIVE_SPECIFIC_UI='react-native-specific-ui',
 JS_HEAP_PROFILER_ENABLE='js-heap-profiler-enable',
-ENABLE_PERFORMANCE_PANEL='enable-performance-panel',
 ENABLE_NETWORK_PANEL='enable-network-panel',
 }
 
@@ -341,7 +340,6 @@ export const enum ExperimentName {
 JS_HEAP_PROFILER_ENABLE=RNExperimentName.JS_HEAP_PROFILER_ENABLE,
 REACT_NATIVE_SPECIFIC_UI=RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
 NOT_REACT_NATIVE_SPECIFIC_UI='!'+RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
-ENABLE_PERFORMANCE_PANEL=RNExperimentName.ENABLE_PERFORMANCE_PANEL,
 ENABLE_NETWORK_PANEL=RNExperimentName.ENABLE_NETWORK_PANEL,
 }
 

front_end/entrypoints/rn_fusebox/FuseboxExperimentsObserver.ts

@@ -13,11 +13,6 @@ import * as UI from '../../ui/legacy/legacy.js';
 import{FuseboxWindowTitleManager}from'./FuseboxWindowTitleManager.js';
 
 constUIStrings={
-/**
- * @description Message for the "settings changed" banner shown when a reload is required for the Performance panel.
- */
-reloadRequiredForPerformancePanelMessage:
-'[Profiling build first run] One or more settings have changed. Please reload to access the Performance panel.',
 /**
  * @description Message for the "settings changed" banner shown when a reload is required for the Network panel.
  */
@@ -55,7 +50,6 @@ export class FuseboxFeatureObserver implements
 if(unstable_isProfilingBuild){
 FuseboxWindowTitleManager.instance().setSuffix('[PROFILING]');
 this.#hideUnsupportedFeaturesForProfilingBuilds();
-this.#ensurePerformancePanelEnabled();
 }
 
 if(unstable_networkInspectionEnabled){
@@ -91,26 +85,6 @@ export class FuseboxFeatureObserver implements
 });
 }
 
- #ensurePerformancePanelEnabled(): void{
-if(
-!Root.Runtime.experiments.isEnabled(
-Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
-)
-){
-Root.Runtime.experiments.setEnabled(
-Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
-true,
-);
-
-constinspectorView=UI.InspectorView?.InspectorView?.instance();
-if(inspectorView){
-inspectorView.displayReloadRequiredWarning(
-i18nString(UIStrings.reloadRequiredForPerformancePanelMessage),
-);
-}
-}
-}
-
  #ensureNetworkPanelEnabled(): void{
 if(Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.ENABLE_NETWORK_PANEL)){
 return;

front_end/global_typings/react_native.d.ts

@@ -19,7 +19,5 @@ declare global {
 varreactNativeOpenInEditorButtonImage: string|undefined;
 // eslint-disable-next-line no-var,@typescript-eslint/naming-convention
 varFB_ONLY__reactNativeFeedbackLink: string|undefined;
-// eslint-disable-next-line no-var,@typescript-eslint/naming-convention
-varFB_ONLY__enablePerformance: unknown;
 }
 }

front_end/panels/timeline/timeline-meta.ts

@@ -88,7 +88,6 @@ UI.ViewManager.registerViewExtension({
 title: i18nLazyString(UIStrings.performance),
 commandPrompt: i18nLazyString(UIStrings.showPerformance),
 order: 50,
-experiment: globalThis.FB_ONLY__enablePerformance===true ? undefined : Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
 asyncloadView(){
 constTimeline=awaitloadTimelineModule();
 returnTimeline.TimelinePanel.TimelinePanel.instance();