Commit ceb1d1c

Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Removing our own implementation of round-to-pixel algorithm
Summary: > Okay, I don't remember where we first met > But hey, admitting is the first step This issue has a looong history. The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!) The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK. For now, the vision is clear: * The basic algorithm should live in Yoga for unification and performance reasons. * We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout. * We have to enable it in RN eventually. So, this is the first step: Removing old, broken code which we don't plan to fix and use. Make React Native crisp again! Reviewed By: fkgozali Differential Revision: D6888662 fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
1 parent c19bc79 commit ceb1d1c

1 file changed

Lines changed: 2 additions & 49 deletions

File tree

‎React/Views/RCTShadowView.m‎

Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -154,35 +154,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
154154
YGNodeStyleSetBorder(node, YGEdgeAll, metaProps[META_PROP_ALL].value);
155155
}
156156

157-
// The absolute stuff is so that we can take into account our absolute position when rounding in order to
158-
// snap to the pixel grid. For example, say you have the following structure:
159-
//
160-
// +--------+---------+--------+
161-
// | |+-------+| |
162-
// | || || |
163-
// | |+-------+| |
164-
// +--------+---------+--------+
165-
//
166-
// Say the screen width is 320 pts so the three big views will get the following x bounds from our layout system:
167-
// {0, 106.667}, {106.667, 213.333}, {213.333, 320}
168-
//
169-
// Assuming screen scale is 2, these numbers must be rounded to the nearest 0.5 to fit the pixel grid:
170-
// {0, 106.5}, {106.5, 213.5}, {213.5, 320}
171-
// You'll notice that the three widths are 106.5, 107, 106.5.
172-
//
173-
// This is great for the parent views but it gets trickier when we consider rounding for the subview.
174-
//
175-
// When we go to round the bounds for the subview in the middle, it's relative bounds are {0, 106.667}
176-
// which gets rounded to {0, 106.5}. This will cause the subview to be one pixel smaller than it should be.
177-
// this is why we need to pass in the absolute position in order to do the rounding relative to the screen's
178-
// grid rather than the view's grid.
179-
//
180-
// After passing in the absolutePosition of {106.667, y}, we do the following calculations:
181-
// absoluteLeft = round(absolutePosition.x + viewPosition.left) = round(106.667 + 0) = 106.5
182-
// absoluteRight = round(absolutePosition.x + viewPosition.left + viewSize.left) + round(106.667 + 0 + 106.667) = 213.5
183-
// width = 213.5 - 106.5 = 107
184-
// You'll notice that this is the same width we calculated for the parent view because we've taken its position into account.
185-
186157
- (void)applyLayoutNode:(YGNodeRef)node
187158
viewsWithNewFrame:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
188159
absolutePosition:(CGPoint)absolutePosition
@@ -218,26 +189,8 @@ - (void)applyLayoutWithFrame:(CGRect)frame
218189
viewsWithUpdatedLayout:(NSMutableSet<RCTShadowView *> *)viewsWithUpdatedLayout
219190
absolutePosition:(CGPoint)absolutePosition
220191
{
221-
CGPoint absoluteTopLeft = {
222-
absolutePosition.x + frame.origin.x,
223-
absolutePosition.y + frame.origin.y
224-
};
225-
226-
CGPoint absoluteBottomRight = {
227-
absolutePosition.x + frame.origin.x + frame.size.width,
228-
absolutePosition.y + frame.origin.y + frame.size.height
229-
};
230-
231-
CGRect roundedFrame = {{
232-
RCTRoundPixelValue(frame.origin.x),
233-
RCTRoundPixelValue(frame.origin.y),
234-
}, {
235-
RCTRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x),
236-
RCTRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y)
237-
}};
238-
239-
if (!CGRectEqualToRect(_frame, roundedFrame) || _layoutDirection != layoutDirection) {
240-
_frame = roundedFrame;
192+
if (!CGRectEqualToRect(_frame, frame) || _layoutDirection != layoutDirection) {
193+
_frame = frame;
241194
_layoutDirection = layoutDirection;
242195
[viewsWithUpdatedLayout addObject:self];
243196
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Commit ceb1d1c
Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Removing our own implementation of round-to-pixel algorithm
Summary:
> Okay, I don't remember where we first met
> But hey, admitting is the first step
This issue has a looong history.
The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)
The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.
For now, the vision is clear:
* The basic algorithm should live in Yoga for unification and performance reasons.
* We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.
* We have to enable it in RN eventually.
So, this is the first step: Removing old, broken code which we don't plan to fix and use.
Make React Native crisp again!
Reviewed By: fkgozali
Differential Revision: D6888662
fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
1 parent c19bc79 commit ceb1d1c
1 file changed
Lines changed: 2 additions & 49 deletions
File tree
‎React/Views/RCTShadowView.m‎
Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -154,35 +154,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
154154
YGNodeStyleSetBorder(node, YGEdgeAll, metaProps[META_PROP_ALL].value);
155155
}
156156

157-
// The absolute stuff is so that we can take into account our absolute position when rounding in order to
158-
// snap to the pixel grid. For example, say you have the following structure:
159-
//
160-
// +--------+---------+--------+
161-
// | |+-------+| |
162-
// | || || |
163-
// | |+-------+| |
164-
// +--------+---------+--------+
165-
//
166-
// Say the screen width is 320 pts so the three big views will get the following x bounds from our layout system:
167-
// {0, 106.667}, {106.667, 213.333}, {213.333, 320}
168-
//
169-
// Assuming screen scale is 2, these numbers must be rounded to the nearest 0.5 to fit the pixel grid:
170-
// {0, 106.5}, {106.5, 213.5}, {213.5, 320}
171-
// You'll notice that the three widths are 106.5, 107, 106.5.
172-
//
173-
// This is great for the parent views but it gets trickier when we consider rounding for the subview.
174-
//
175-
// When we go to round the bounds for the subview in the middle, it's relative bounds are {0, 106.667}
176-
// which gets rounded to {0, 106.5}. This will cause the subview to be one pixel smaller than it should be.
177-
// this is why we need to pass in the absolute position in order to do the rounding relative to the screen's
178-
// grid rather than the view's grid.
179-
//
180-
// After passing in the absolutePosition of {106.667, y}, we do the following calculations:
181-
// absoluteLeft = round(absolutePosition.x + viewPosition.left) = round(106.667 + 0) = 106.5
182-
// absoluteRight = round(absolutePosition.x + viewPosition.left + viewSize.left) + round(106.667 + 0 + 106.667) = 213.5
183-
// width = 213.5 - 106.5 = 107
184-
// You'll notice that this is the same width we calculated for the parent view because we've taken its position into account.
185-
186157
- (void)applyLayoutNode:(YGNodeRef)node
187158
viewsWithNewFrame:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
188159
absolutePosition:(CGPoint)absolutePosition
@@ -218,26 +189,8 @@ - (void)applyLayoutWithFrame:(CGRect)frame
218189
viewsWithUpdatedLayout:(NSMutableSet<RCTShadowView *> *)viewsWithUpdatedLayout
219190
absolutePosition:(CGPoint)absolutePosition
220191
{
221-
 CGPoint absoluteTopLeft = {
222-
 absolutePosition.x + frame.origin.x,
223-
 absolutePosition.y + frame.origin.y
224-
 };
225-
226-
 CGPoint absoluteBottomRight = {
227-
 absolutePosition.x + frame.origin.x + frame.size.width,
228-
 absolutePosition.y + frame.origin.y + frame.size.height
229-
 };
230-
231-
 CGRect roundedFrame = {{
232-
RCTRoundPixelValue(frame.origin.x),
233-
RCTRoundPixelValue(frame.origin.y),
234-
 }, {
235-
RCTRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x),
236-
RCTRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y)
237-
 }};
238-
239-
if (!CGRectEqualToRect(_frame, roundedFrame) || _layoutDirection != layoutDirection) {
240-
 _frame = roundedFrame;
192+
if (!CGRectEqualToRect(_frame, frame) || _layoutDirection != layoutDirection) {
193+
 _frame = frame;
241194
 _layoutDirection = layoutDirection;
242195
 [viewsWithUpdatedLayout addObject:self];
243196
 }
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ceb1d1c
Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Removing our own implementation of round-to-pixel algorithm
Summary:
> Okay, I don't remember where we first met
> But hey, admitting is the first step
This issue has a looong history.
The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)
The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.
For now, the vision is clear:
* The basic algorithm should live in Yoga for unification and performance reasons.
* We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.
* We have to enable it in RN eventually.
So, this is the first step: Removing old, broken code which we don't plan to fix and use.
Make React Native crisp again!
Reviewed By: fkgozali
Differential Revision: D6888662
fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
1 parent c19bc79 commit ceb1d1c
1 file changed
Lines changed: 2 additions & 49 deletions
File tree
‎React/Views/RCTShadowView.m‎
Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -154,35 +154,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
154154
YGNodeStyleSetBorder(node, YGEdgeAll, metaProps[META_PROP_ALL].value);
155155
}
156156

157-
// The absolute stuff is so that we can take into account our absolute position when rounding in order to
158-
// snap to the pixel grid. For example, say you have the following structure:
159-
//
160-
// +--------+---------+--------+
161-
// | |+-------+| |
162-
// | || || |
163-
// | |+-------+| |
164-
// +--------+---------+--------+
165-
//
166-
// Say the screen width is 320 pts so the three big views will get the following x bounds from our layout system:
167-
// {0, 106.667}, {106.667, 213.333}, {213.333, 320}
168-
//
169-
// Assuming screen scale is 2, these numbers must be rounded to the nearest 0.5 to fit the pixel grid:
170-
// {0, 106.5}, {106.5, 213.5}, {213.5, 320}
171-
// You'll notice that the three widths are 106.5, 107, 106.5.
172-
//
173-
// This is great for the parent views but it gets trickier when we consider rounding for the subview.
174-
//
175-
// When we go to round the bounds for the subview in the middle, it's relative bounds are {0, 106.667}
176-
// which gets rounded to {0, 106.5}. This will cause the subview to be one pixel smaller than it should be.
177-
// this is why we need to pass in the absolute position in order to do the rounding relative to the screen's
178-
// grid rather than the view's grid.
179-
//
180-
// After passing in the absolutePosition of {106.667, y}, we do the following calculations:
181-
// absoluteLeft = round(absolutePosition.x + viewPosition.left) = round(106.667 + 0) = 106.5
182-
// absoluteRight = round(absolutePosition.x + viewPosition.left + viewSize.left) + round(106.667 + 0 + 106.667) = 213.5
183-
// width = 213.5 - 106.5 = 107
184-
// You'll notice that this is the same width we calculated for the parent view because we've taken its position into account.
185-
186157
- (void)applyLayoutNode:(YGNodeRef)node
187158
viewsWithNewFrame:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
188159
absolutePosition:(CGPoint)absolutePosition
@@ -218,26 +189,8 @@ - (void)applyLayoutWithFrame:(CGRect)frame
218189
viewsWithUpdatedLayout:(NSMutableSet<RCTShadowView *> *)viewsWithUpdatedLayout
219190
absolutePosition:(CGPoint)absolutePosition
220191
{
221-
 CGPoint absoluteTopLeft = {
222-
 absolutePosition.x + frame.origin.x,
223-
 absolutePosition.y + frame.origin.y
224-
 };
225-
226-
 CGPoint absoluteBottomRight = {
227-
 absolutePosition.x + frame.origin.x + frame.size.width,
228-
 absolutePosition.y + frame.origin.y + frame.size.height
229-
 };
230-
231-
 CGRect roundedFrame = {{
232-
RCTRoundPixelValue(frame.origin.x),
233-
RCTRoundPixelValue(frame.origin.y),
234-
 }, {
235-
RCTRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x),
236-
RCTRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y)
237-
 }};
238-
239-
if (!CGRectEqualToRect(_frame, roundedFrame) || _layoutDirection != layoutDirection) {
240-
 _frame = roundedFrame;
192+
if (!CGRectEqualToRect(_frame, frame) || _layoutDirection != layoutDirection) {
193+
 _frame = frame;
241194
 _layoutDirection = layoutDirection;
242195
 [viewsWithUpdatedLayout addObject:self];
243196
 }
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ceb1d1c
Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Removing our own implementation of round-to-pixel algorithm
Summary:
> Okay, I don't remember where we first met
> But hey, admitting is the first step
This issue has a looong history.
The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)
The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.
For now, the vision is clear:
* The basic algorithm should live in Yoga for unification and performance reasons.
* We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.
* We have to enable it in RN eventually.
So, this is the first step: Removing old, broken code which we don't plan to fix and use.
Make React Native crisp again!
Reviewed By: fkgozali
Differential Revision: D6888662
fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
1 parent c19bc79 commit ceb1d1c
1 file changed
Lines changed: 2 additions & 49 deletions
File tree
‎React/Views/RCTShadowView.m‎
Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -154,35 +154,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
154154
YGNodeStyleSetBorder(node, YGEdgeAll, metaProps[META_PROP_ALL].value);
155155
}
156156

157-
// The absolute stuff is so that we can take into account our absolute position when rounding in order to
158-
// snap to the pixel grid. For example, say you have the following structure:
159-
//
160-
// +--------+---------+--------+
161-
// | |+-------+| |
162-
// | || || |
163-
// | |+-------+| |
164-
// +--------+---------+--------+
165-
//
166-
// Say the screen width is 320 pts so the three big views will get the following x bounds from our layout system:
167-
// {0, 106.667}, {106.667, 213.333}, {213.333, 320}
168-
//
169-
// Assuming screen scale is 2, these numbers must be rounded to the nearest 0.5 to fit the pixel grid:
170-
// {0, 106.5}, {106.5, 213.5}, {213.5, 320}
171-
// You'll notice that the three widths are 106.5, 107, 106.5.
172-
//
173-
// This is great for the parent views but it gets trickier when we consider rounding for the subview.
174-
//
175-
// When we go to round the bounds for the subview in the middle, it's relative bounds are {0, 106.667}
176-
// which gets rounded to {0, 106.5}. This will cause the subview to be one pixel smaller than it should be.
177-
// this is why we need to pass in the absolute position in order to do the rounding relative to the screen's
178-
// grid rather than the view's grid.
179-
//
180-
// After passing in the absolutePosition of {106.667, y}, we do the following calculations:
181-
// absoluteLeft = round(absolutePosition.x + viewPosition.left) = round(106.667 + 0) = 106.5
182-
// absoluteRight = round(absolutePosition.x + viewPosition.left + viewSize.left) + round(106.667 + 0 + 106.667) = 213.5
183-
// width = 213.5 - 106.5 = 107
184-
// You'll notice that this is the same width we calculated for the parent view because we've taken its position into account.
185-
186157
- (void)applyLayoutNode:(YGNodeRef)node
187158
viewsWithNewFrame:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
188159
absolutePosition:(CGPoint)absolutePosition
@@ -218,26 +189,8 @@ - (void)applyLayoutWithFrame:(CGRect)frame
218189
viewsWithUpdatedLayout:(NSMutableSet<RCTShadowView *> *)viewsWithUpdatedLayout
219190
absolutePosition:(CGPoint)absolutePosition
220191
{
221-
 CGPoint absoluteTopLeft = {
222-
 absolutePosition.x + frame.origin.x,
223-
 absolutePosition.y + frame.origin.y
224-
 };
225-
226-
 CGPoint absoluteBottomRight = {
227-
 absolutePosition.x + frame.origin.x + frame.size.width,
228-
 absolutePosition.y + frame.origin.y + frame.size.height
229-
 };
230-
231-
 CGRect roundedFrame = {{
232-
RCTRoundPixelValue(frame.origin.x),
233-
RCTRoundPixelValue(frame.origin.y),
234-
 }, {
235-
RCTRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x),
236-
RCTRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y)
237-
 }};
238-
239-
if (!CGRectEqualToRect(_frame, roundedFrame) || _layoutDirection != layoutDirection) {
240-
 _frame = roundedFrame;
192+
if (!CGRectEqualToRect(_frame, frame) || _layoutDirection != layoutDirection) {
193+
 _frame = frame;
241194
 _layoutDirection = layoutDirection;
242195
 [viewsWithUpdatedLayout addObject:self];
243196
 }
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Commit ceb1d1c
Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Removing our own implementation of round-to-pixel algorithm
Summary:
> Okay, I don't remember where we first met
> But hey, admitting is the first step
This issue has a looong history.
The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)
The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.
For now, the vision is clear:
* The basic algorithm should live in Yoga for unification and performance reasons.
* We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.
* We have to enable it in RN eventually.
So, this is the first step: Removing old, broken code which we don't plan to fix and use.
Make React Native crisp again!
Reviewed By: fkgozali
Differential Revision: D6888662
fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
1 parent c19bc79 commit ceb1d1c
1 file changed
Lines changed: 2 additions & 49 deletions
File tree
‎React/Views/RCTShadowView.m‎
Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -154,35 +154,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
154154
YGNodeStyleSetBorder(node, YGEdgeAll, metaProps[META_PROP_ALL].value);
155155
}
156156

157-
// The absolute stuff is so that we can take into account our absolute position when rounding in order to
158-
// snap to the pixel grid. For example, say you have the following structure:
159-
//
160-
// +--------+---------+--------+
161-
// | |+-------+| |
162-
// | || || |
163-
// | |+-------+| |
164-
// +--------+---------+--------+
165-
//
166-
// Say the screen width is 320 pts so the three big views will get the following x bounds from our layout system:
167-
// {0, 106.667}, {106.667, 213.333}, {213.333, 320}
168-
//
169-
// Assuming screen scale is 2, these numbers must be rounded to the nearest 0.5 to fit the pixel grid:
170-
// {0, 106.5}, {106.5, 213.5}, {213.5, 320}
171-
// You'll notice that the three widths are 106.5, 107, 106.5.
172-
//
173-
// This is great for the parent views but it gets trickier when we consider rounding for the subview.
174-
//
175-
// When we go to round the bounds for the subview in the middle, it's relative bounds are {0, 106.667}
176-
// which gets rounded to {0, 106.5}. This will cause the subview to be one pixel smaller than it should be.
177-
// this is why we need to pass in the absolute position in order to do the rounding relative to the screen's
178-
// grid rather than the view's grid.
179-
//
180-
// After passing in the absolutePosition of {106.667, y}, we do the following calculations:
181-
// absoluteLeft = round(absolutePosition.x + viewPosition.left) = round(106.667 + 0) = 106.5
182-
// absoluteRight = round(absolutePosition.x + viewPosition.left + viewSize.left) + round(106.667 + 0 + 106.667) = 213.5
183-
// width = 213.5 - 106.5 = 107
184-
// You'll notice that this is the same width we calculated for the parent view because we've taken its position into account.
185-
186157
- (void)applyLayoutNode:(YGNodeRef)node
187158
viewsWithNewFrame:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
188159
absolutePosition:(CGPoint)absolutePosition
@@ -218,26 +189,8 @@ - (void)applyLayoutWithFrame:(CGRect)frame
218189
viewsWithUpdatedLayout:(NSMutableSet<RCTShadowView *> *)viewsWithUpdatedLayout
219190
absolutePosition:(CGPoint)absolutePosition
220191
{
221-
 CGPoint absoluteTopLeft = {
222-
 absolutePosition.x + frame.origin.x,
223-
 absolutePosition.y + frame.origin.y
224-
 };
225-
226-
 CGPoint absoluteBottomRight = {
227-
 absolutePosition.x + frame.origin.x + frame.size.width,
228-
 absolutePosition.y + frame.origin.y + frame.size.height
229-
 };
230-
231-
 CGRect roundedFrame = {{
232-
RCTRoundPixelValue(frame.origin.x),
233-
RCTRoundPixelValue(frame.origin.y),
234-
 }, {
235-
RCTRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x),
236-
RCTRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y)
237-
 }};
238-
239-
if (!CGRectEqualToRect(_frame, roundedFrame) || _layoutDirection != layoutDirection) {
240-
 _frame = roundedFrame;
192+
if (!CGRectEqualToRect(_frame, frame) || _layoutDirection != layoutDirection) {
193+
 _frame = frame;
241194
 _layoutDirection = layoutDirection;
242195
 [viewsWithUpdatedLayout addObject:self];
243196
 }
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ceb1d1c
Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Removing our own implementation of round-to-pixel algorithm
Summary:
> Okay, I don't remember where we first met
> But hey, admitting is the first step
This issue has a looong history.
The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)
The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.
For now, the vision is clear:
* The basic algorithm should live in Yoga for unification and performance reasons.
* We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.
* We have to enable it in RN eventually.
So, this is the first step: Removing old, broken code which we don't plan to fix and use.
Make React Native crisp again!
Reviewed By: fkgozali
Differential Revision: D6888662
fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
1 parent c19bc79 commit ceb1d1c
1 file changed
Lines changed: 2 additions & 49 deletions
File tree
‎React/Views/RCTShadowView.m‎
Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -154,35 +154,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
154154
YGNodeStyleSetBorder(node, YGEdgeAll, metaProps[META_PROP_ALL].value);
155155
}
156156

157-
// The absolute stuff is so that we can take into account our absolute position when rounding in order to
158-
// snap to the pixel grid. For example, say you have the following structure:
159-
//
160-
// +--------+---------+--------+
161-
// | |+-------+| |
162-
// | || || |
163-
// | |+-------+| |
164-
// +--------+---------+--------+
165-
//
166-
// Say the screen width is 320 pts so the three big views will get the following x bounds from our layout system:
167-
// {0, 106.667}, {106.667, 213.333}, {213.333, 320}
168-
//
169-
// Assuming screen scale is 2, these numbers must be rounded to the nearest 0.5 to fit the pixel grid:
170-
// {0, 106.5}, {106.5, 213.5}, {213.5, 320}
171-
// You'll notice that the three widths are 106.5, 107, 106.5.
172-
//
173-
// This is great for the parent views but it gets trickier when we consider rounding for the subview.
174-
//
175-
// When we go to round the bounds for the subview in the middle, it's relative bounds are {0, 106.667}
176-
// which gets rounded to {0, 106.5}. This will cause the subview to be one pixel smaller than it should be.
177-
// this is why we need to pass in the absolute position in order to do the rounding relative to the screen's
178-
// grid rather than the view's grid.
179-
//
180-
// After passing in the absolutePosition of {106.667, y}, we do the following calculations:
181-
// absoluteLeft = round(absolutePosition.x + viewPosition.left) = round(106.667 + 0) = 106.5
182-
// absoluteRight = round(absolutePosition.x + viewPosition.left + viewSize.left) + round(106.667 + 0 + 106.667) = 213.5
183-
// width = 213.5 - 106.5 = 107
184-
// You'll notice that this is the same width we calculated for the parent view because we've taken its position into account.
185-
186157
- (void)applyLayoutNode:(YGNodeRef)node
187158
viewsWithNewFrame:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
188159
absolutePosition:(CGPoint)absolutePosition
@@ -218,26 +189,8 @@ - (void)applyLayoutWithFrame:(CGRect)frame
218189
viewsWithUpdatedLayout:(NSMutableSet<RCTShadowView *> *)viewsWithUpdatedLayout
219190
absolutePosition:(CGPoint)absolutePosition
220191
{
221-
 CGPoint absoluteTopLeft = {
222-
 absolutePosition.x + frame.origin.x,
223-
 absolutePosition.y + frame.origin.y
224-
 };
225-
226-
 CGPoint absoluteBottomRight = {
227-
 absolutePosition.x + frame.origin.x + frame.size.width,
228-
 absolutePosition.y + frame.origin.y + frame.size.height
229-
 };
230-
231-
 CGRect roundedFrame = {{
232-
RCTRoundPixelValue(frame.origin.x),
233-
RCTRoundPixelValue(frame.origin.y),
234-
 }, {
235-
RCTRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x),
236-
RCTRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y)
237-
 }};
238-
239-
if (!CGRectEqualToRect(_frame, roundedFrame) || _layoutDirection != layoutDirection) {
240-
 _frame = roundedFrame;
192+
if (!CGRectEqualToRect(_frame, frame) || _layoutDirection != layoutDirection) {
193+
 _frame = frame;
241194
 _layoutDirection = layoutDirection;
242195
 [viewsWithUpdatedLayout addObject:self];
243196
 }
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ceb1d1c
Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Removing our own implementation of round-to-pixel algorithm
Summary:
> Okay, I don't remember where we first met
> But hey, admitting is the first step
This issue has a looong history.
The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)
The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.
For now, the vision is clear:
* The basic algorithm should live in Yoga for unification and performance reasons.
* We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.
* We have to enable it in RN eventually.
So, this is the first step: Removing old, broken code which we don't plan to fix and use.
Make React Native crisp again!
Reviewed By: fkgozali
Differential Revision: D6888662
fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
1 parent c19bc79 commit ceb1d1c
1 file changed
Lines changed: 2 additions & 49 deletions
File tree
‎React/Views/RCTShadowView.m‎
Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -154,35 +154,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
154154
YGNodeStyleSetBorder(node, YGEdgeAll, metaProps[META_PROP_ALL].value);
155155
}
156156

157-
// The absolute stuff is so that we can take into account our absolute position when rounding in order to
158-
// snap to the pixel grid. For example, say you have the following structure:
159-
//
160-
// +--------+---------+--------+
161-
// | |+-------+| |
162-
// | || || |
163-
// | |+-------+| |
164-
// +--------+---------+--------+
165-
//
166-
// Say the screen width is 320 pts so the three big views will get the following x bounds from our layout system:
167-
// {0, 106.667}, {106.667, 213.333}, {213.333, 320}
168-
//
169-
// Assuming screen scale is 2, these numbers must be rounded to the nearest 0.5 to fit the pixel grid:
170-
// {0, 106.5}, {106.5, 213.5}, {213.5, 320}
171-
// You'll notice that the three widths are 106.5, 107, 106.5.
172-
//
173-
// This is great for the parent views but it gets trickier when we consider rounding for the subview.
174-
//
175-
// When we go to round the bounds for the subview in the middle, it's relative bounds are {0, 106.667}
176-
// which gets rounded to {0, 106.5}. This will cause the subview to be one pixel smaller than it should be.
177-
// this is why we need to pass in the absolute position in order to do the rounding relative to the screen's
178-
// grid rather than the view's grid.
179-
//
180-
// After passing in the absolutePosition of {106.667, y}, we do the following calculations:
181-
// absoluteLeft = round(absolutePosition.x + viewPosition.left) = round(106.667 + 0) = 106.5
182-
// absoluteRight = round(absolutePosition.x + viewPosition.left + viewSize.left) + round(106.667 + 0 + 106.667) = 213.5
183-
// width = 213.5 - 106.5 = 107
184-
// You'll notice that this is the same width we calculated for the parent view because we've taken its position into account.
185-
186157
- (void)applyLayoutNode:(YGNodeRef)node
187158
viewsWithNewFrame:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
188159
absolutePosition:(CGPoint)absolutePosition
@@ -218,26 +189,8 @@ - (void)applyLayoutWithFrame:(CGRect)frame
218189
viewsWithUpdatedLayout:(NSMutableSet<RCTShadowView *> *)viewsWithUpdatedLayout
219190
absolutePosition:(CGPoint)absolutePosition
220191
{
221-
 CGPoint absoluteTopLeft = {
222-
 absolutePosition.x + frame.origin.x,
223-
 absolutePosition.y + frame.origin.y
224-
 };
225-
226-
 CGPoint absoluteBottomRight = {
227-
 absolutePosition.x + frame.origin.x + frame.size.width,
228-
 absolutePosition.y + frame.origin.y + frame.size.height
229-
 };
230-
231-
 CGRect roundedFrame = {{
232-
RCTRoundPixelValue(frame.origin.x),
233-
RCTRoundPixelValue(frame.origin.y),
234-
 }, {
235-
RCTRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x),
236-
RCTRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y)
237-
 }};
238-
239-
if (!CGRectEqualToRect(_frame, roundedFrame) || _layoutDirection != layoutDirection) {
240-
 _frame = roundedFrame;
192+
if (!CGRectEqualToRect(_frame, frame) || _layoutDirection != layoutDirection) {
193+
 _frame = frame;
241194
 _layoutDirection = layoutDirection;
242195
 [viewsWithUpdatedLayout addObject:self];
243196
 }
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Commit ceb1d1c
Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Removing our own implementation of round-to-pixel algorithm
Summary:
> Okay, I don't remember where we first met
> But hey, admitting is the first step
This issue has a looong history.
The original algorithm was introduced by Nick Lockwood (nicklockwood Hey Nick! We miss you!) a while ago and from the very beginning this has one small error that basically makes it useless (try to find it yourself, it's fun!)
The problem was discovered and fixed twice (D4133643, D4983054), but every time we found that our <Text> infra was not ready for this, so we reverted and abandoned the change. As part of the last attempt to finally solve the issue, I ported the algorithm to Yoga where it lives today and works very well for Lytho and CK.
For now, the vision is clear:
* The basic algorithm should live in Yoga for unification and performance reasons.
* We still have to have `absolutePostion` as part of this API because it might be useful for some components which implement its own custom/non-Yoga-based layout.
* We have to enable it in RN eventually.
So, this is the first step: Removing old, broken code which we don't plan to fix and use.
Make React Native crisp again!
Reviewed By: fkgozali
Differential Revision: D6888662
fbshipit-source-id: 2e5098d9935dcbe05d66c777dad3a9ec8ac87ec3
1 parent c19bc79 commit ceb1d1c
1 file changed
Lines changed: 2 additions & 49 deletions
File tree
‎React/Views/RCTShadowView.m‎
Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -154,35 +154,6 @@ static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT],
154154
YGNodeStyleSetBorder(node, YGEdgeAll, metaProps[META_PROP_ALL].value);
155155
}
156156

157-
// The absolute stuff is so that we can take into account our absolute position when rounding in order to
158-
// snap to the pixel grid. For example, say you have the following structure:
159-
//
160-
// +--------+---------+--------+
161-
// | |+-------+| |
162-
// | || || |
163-
// | |+-------+| |
164-
// +--------+---------+--------+
165-
//
166-
// Say the screen width is 320 pts so the three big views will get the following x bounds from our layout system:
167-
// {0, 106.667}, {106.667, 213.333}, {213.333, 320}
168-
//
169-
// Assuming screen scale is 2, these numbers must be rounded to the nearest 0.5 to fit the pixel grid:
170-
// {0, 106.5}, {106.5, 213.5}, {213.5, 320}
171-
// You'll notice that the three widths are 106.5, 107, 106.5.
172-
//
173-
// This is great for the parent views but it gets trickier when we consider rounding for the subview.
174-
//
175-
// When we go to round the bounds for the subview in the middle, it's relative bounds are {0, 106.667}
176-
// which gets rounded to {0, 106.5}. This will cause the subview to be one pixel smaller than it should be.
177-
// this is why we need to pass in the absolute position in order to do the rounding relative to the screen's
178-
// grid rather than the view's grid.
179-
//
180-
// After passing in the absolutePosition of {106.667, y}, we do the following calculations:
181-
// absoluteLeft = round(absolutePosition.x + viewPosition.left) = round(106.667 + 0) = 106.5
182-
// absoluteRight = round(absolutePosition.x + viewPosition.left + viewSize.left) + round(106.667 + 0 + 106.667) = 213.5
183-
// width = 213.5 - 106.5 = 107
184-
// You'll notice that this is the same width we calculated for the parent view because we've taken its position into account.
185-
186157
- (void)applyLayoutNode:(YGNodeRef)node
187158
viewsWithNewFrame:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
188159
absolutePosition:(CGPoint)absolutePosition
@@ -218,26 +189,8 @@ - (void)applyLayoutWithFrame:(CGRect)frame
218189
viewsWithUpdatedLayout:(NSMutableSet<RCTShadowView *> *)viewsWithUpdatedLayout
219190
absolutePosition:(CGPoint)absolutePosition
220191
{
221-
 CGPoint absoluteTopLeft = {
222-
 absolutePosition.x + frame.origin.x,
223-
 absolutePosition.y + frame.origin.y
224-
 };
225-
226-
 CGPoint absoluteBottomRight = {
227-
 absolutePosition.x + frame.origin.x + frame.size.width,
228-
 absolutePosition.y + frame.origin.y + frame.size.height
229-
 };
230-
231-
 CGRect roundedFrame = {{
232-
RCTRoundPixelValue(frame.origin.x),
233-
RCTRoundPixelValue(frame.origin.y),
234-
 }, {
235-
RCTRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x),
236-
RCTRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y)
237-
 }};
238-
239-
if (!CGRectEqualToRect(_frame, roundedFrame) || _layoutDirection != layoutDirection) {
240-
 _frame = roundedFrame;
192+
if (!CGRectEqualToRect(_frame, frame) || _layoutDirection != layoutDirection) {
193+
 _frame = frame;
241194
 _layoutDirection = layoutDirection;
242195
 [viewsWithUpdatedLayout addObject:self];
243196
 }
0 commit comments
Comments
 (0)