Cover runtimeexecutor with Stable API guards (#58324) - #58324
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D118792973. |
runtimeexecutor with Stable API guardsruntimeexecutor with Stable API guards (#58324)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 7, 2026
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 7, 2026 09:40
59f7781 to
b5bd592
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 9, 2026 07:41
b5bd592 to
8eb1d3b
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 11, 2026
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 11, 2026 09:24
8eb1d3b to
be41ad0
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 11, 2026
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 11, 2026 09:24
be41ad0 to
3fb1207
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 13, 2026
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: javache Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 13, 2026 19:10
3fb1207 to
a3305ac
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 14, 2026
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: javache Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 14, 2026 05:32
a3305ac to
9ee7924
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 14, 2026
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: javache Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 14, 2026 05:32
9ee7924 to
b0120ec
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 14, 2026
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: javache Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 14, 2026 07:31
b0120ec to
12f7321
Compare
Summary: Classifies `runtimeexecutor:runtimeexecutor` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 3 exported headers and introduces the module umbrella `React/RuntimeExecutor.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RuntimeExecutor.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: javache Differential Revision: D118792973
j-piasecki
force-pushed
the
export-D118792973
branch
from
September 14, 2026 07:38
12f7321 to
0948aa8
Compare
|
This pull request has been merged in 9038350. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
runtimeexecutor:runtimeexecutoras a public target under the C++ stable API three-tier visibility model. Adds#include <react/cxxstableapi/UmbrellaGuard.h>to the module's 3 exported headers and introduces the module umbrellaReact/RuntimeExecutor.h, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export.Consumers that opt into
RN_STRICT_APInow get an error if they include the module's headers directly, and should include<React/RuntimeExecutor.h>instead; without that flag the guards are inert, so no existing build changes behaviour.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D118792973