From 45807e0b2843065a283ea4b76a679875b0434c2f Mon Sep 17 00:00:00 2001 From: Gabriel Donadel Date: Wed, 8 Nov 2023 01:17:21 -0300 Subject: [PATCH 1/4] Remove package.json exports field from dev-middleware and community-cli-plugin --- packages/community-cli-plugin/package.json | 4 ---- packages/dev-middleware/package.json | 4 ---- 2 files changed, 8 deletions(-) diff --git a/packages/community-cli-plugin/package.json b/packages/community-cli-plugin/package.json index c75800c798ce..2d8398c011d2 100644 --- a/packages/community-cli-plugin/package.json +++ b/packages/community-cli-plugin/package.json @@ -14,10 +14,6 @@ "directory": "packages/community-cli-plugin" }, "license": "MIT", - "exports": { - ".": "./src/index.js", - "./package.json": "./package.json" - }, "files": [ "dist" ], diff --git a/packages/dev-middleware/package.json b/packages/dev-middleware/package.json index 8b8c6db29270..4554c804fc14 100644 --- a/packages/dev-middleware/package.json +++ b/packages/dev-middleware/package.json @@ -14,10 +14,6 @@ "directory": "packages/dev-middleware" }, "license": "MIT", - "exports": { - ".": "./src/index.js", - "./package.json": "./package.json" - }, "files": [ "dist" ], From 324def9683f07401b11d26a8b5b8762966490685 Mon Sep 17 00:00:00 2001 From: Cedric van Putten Date: Thu, 9 Nov 2023 14:38:40 +0100 Subject: [PATCH 2/4] refactor(community-cli-plugin): revert `exports` change in `package.json` --- packages/community-cli-plugin/package.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/community-cli-plugin/package.json b/packages/community-cli-plugin/package.json index 2d8398c011d2..c75800c798ce 100644 --- a/packages/community-cli-plugin/package.json +++ b/packages/community-cli-plugin/package.json @@ -14,6 +14,10 @@ "directory": "packages/community-cli-plugin" }, "license": "MIT", + "exports": { + ".": "./src/index.js", + "./package.json": "./package.json" + }, "files": [ "dist" ], From 2061b6dc3145247420a38f8bbb6b3024b1699840 Mon Sep 17 00:00:00 2001 From: Cedric van Putten Date: Thu, 9 Nov 2023 14:54:41 +0100 Subject: [PATCH 3/4] refactor(dev-middleware): allow inspector proxy implementation modifications --- packages/dev-middleware/package.json | 4 ++++ packages/dev-middleware/src/createDevMiddleware.js | 11 ++++++++++- packages/dev-middleware/src/index.flow.js | 3 +++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/packages/dev-middleware/package.json b/packages/dev-middleware/package.json index 4554c804fc14..8b8c6db29270 100644 --- a/packages/dev-middleware/package.json +++ b/packages/dev-middleware/package.json @@ -14,6 +14,10 @@ "directory": "packages/dev-middleware" }, "license": "MIT", + "exports": { + ".": "./src/index.js", + "./package.json": "./package.json" + }, "files": [ "dist" ], diff --git a/packages/dev-middleware/src/createDevMiddleware.js b/packages/dev-middleware/src/createDevMiddleware.js index c73d19a17374..bd785a0122d8 100644 --- a/packages/dev-middleware/src/createDevMiddleware.js +++ b/packages/dev-middleware/src/createDevMiddleware.js @@ -59,6 +59,13 @@ type Options = $ReadOnly<{ * This is an unstable API with no semver guarantees. */ unstable_experiments?: ExperimentsConfig, + + /** + * An interface for using a modified inspector proxy implementation. + * + * This is an unstable API with no semver guarantees. + */ + unstable_InspectorProxy?: Class, }>; type DevMiddlewareAPI = $ReadOnly<{ @@ -73,10 +80,12 @@ export default function createDevMiddleware({ unstable_browserLauncher = DefaultBrowserLauncher, unstable_eventReporter, unstable_experiments: experimentConfig = {}, + unstable_InspectorProxy, }: Options): DevMiddlewareAPI { const experiments = getExperiments(experimentConfig); - const inspectorProxy = new InspectorProxy( + const InspectorProxyClass = unstable_InspectorProxy ?? InspectorProxy; + const inspectorProxy = new InspectorProxyClass( projectRoot, serverBaseUrl, unstable_eventReporter, diff --git a/packages/dev-middleware/src/index.flow.js b/packages/dev-middleware/src/index.flow.js index 4060a2bb2d4c..be878d4edf52 100644 --- a/packages/dev-middleware/src/index.flow.js +++ b/packages/dev-middleware/src/index.flow.js @@ -13,3 +13,6 @@ export {default as createDevMiddleware} from './createDevMiddleware'; export type {BrowserLauncher, LaunchedBrowser} from './types/BrowserLauncher'; export type {EventReporter, ReportableEvent} from './types/EventReporter'; + +export {InspectorProxy as unstable_InspectorProxy} from './inspector-proxy/InspectorProxy'; +export {Device as unstable_Device} from './inspector-proxy/Device'; From 3c259240f0ea68a9105be817d71b06f3e046d6d3 Mon Sep 17 00:00:00 2001 From: Gabriel Donadel Date: Thu, 9 Nov 2023 13:23:41 -0300 Subject: [PATCH 4/4] Fix export default --- packages/dev-middleware/src/index.flow.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/dev-middleware/src/index.flow.js b/packages/dev-middleware/src/index.flow.js index be878d4edf52..c662838fea10 100644 --- a/packages/dev-middleware/src/index.flow.js +++ b/packages/dev-middleware/src/index.flow.js @@ -14,5 +14,5 @@ export {default as createDevMiddleware} from './createDevMiddleware'; export type {BrowserLauncher, LaunchedBrowser} from './types/BrowserLauncher'; export type {EventReporter, ReportableEvent} from './types/EventReporter'; -export {InspectorProxy as unstable_InspectorProxy} from './inspector-proxy/InspectorProxy'; -export {Device as unstable_Device} from './inspector-proxy/Device'; +export {default as unstable_InspectorProxy} from './inspector-proxy/InspectorProxy'; +export {default as unstable_Device} from './inspector-proxy/Device';