Reland Remove redundant initial of isArray (#21188)

* Remove redundant initial of isArray (#21163)
* Reapply prettier
* Type the isArray function with refinement support
This ensures that an argument gets refined just like it does if isArray is
used directly.
I'm not sure how to express with just a direct reference so I added a
function wrapper and confirmed that this does get inlined properly by
closure compiler.
* A few more
* Rename unit test to internal
This is not testing a bundle.
Co-authored-by: Behnam Mohammadi <itten@live.com>

Author: sebmarkbage

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js

@@ -145,6 +145,8 @@ export default {
 componentScope=currentScope;
 }
 
+constisArray=Array.isArray;
+
 // Next we'll define a few helpers that helps us
 // tell if some values don't have to be declared as deps.
 
@@ -157,7 +159,7 @@ export default {
 // ^^^ true for this reference
 // False for everything else.
 functionisStableKnownHookValue(resolved){
-if(!Array.isArray(resolved.defs)){
+if(!isArray(resolved.defs)){
 returnfalse;
 }
 constdef=resolved.defs[0];
@@ -226,7 +228,7 @@ export default {
 if(
 id.type==='ArrayPattern'&&
 id.elements.length===2&&
-Array.isArray(resolved.identifiers)
+isArray(resolved.identifiers)
 ){
 // Is second tuple value the same reference we're checking?
 if(id.elements[1]===resolved.identifiers[0]){
@@ -253,10 +255,7 @@ export default {
 }
 }
 }elseif(name==='useTransition'){
-if(
-id.type==='ArrayPattern'&&
-Array.isArray(resolved.identifiers)
-){
+if(id.type==='ArrayPattern'&&isArray(resolved.identifiers)){
 // Is first tuple value the same reference we're checking?
 if(id.elements[0]===resolved.identifiers[0]){
 // Setter is stable.
@@ -270,7 +269,7 @@ export default {
 
 // Some are just functions that don't reference anything dynamic.
 functionisFunctionWithoutCapturedValues(resolved){
-if(!Array.isArray(resolved.defs)){
+if(!isArray(resolved.defs)){
 returnfalse;
 }
 constdef=resolved.defs[0];

packages/jest-react/src/JestReact.js

@@ -8,6 +8,7 @@
 import{REACT_ELEMENT_TYPE,REACT_FRAGMENT_TYPE}from'shared/ReactSymbols';
 
 importinvariantfrom'shared/invariant';
+importisArrayfrom'shared/isArray';
 
 functioncaptureAssertion(fn){
 // Trick to use a Jest matcher inside another Jest matcher. `fn` contains an
@@ -42,7 +43,7 @@ export function unstable_toMatchRenderedOutput(root, expectedJSX) {
 letactualJSX;
 if(actualJSON===null||typeofactualJSON==='string'){
 actualJSX=actualJSON;
-}elseif(Array.isArray(actualJSON)){
+}elseif(isArray(actualJSON)){
 if(actualJSON.length===0){
 actualJSX=null;
 }elseif(actualJSON.length===1){

packages/react-devtools-shared/src/backend/renderer.js

@@ -105,6 +105,7 @@ import type {
 ElementType,
 }from'react-devtools-shared/src/types';
 importisfrom'shared/objectIs';
+importisArrayfrom'shared/isArray';
 
 typegetDisplayNameForFiberType=(fiber: Fiber)=>string|null;
 typegetTypeSymbolType=(type: any)=>Symbol|number;
@@ -1137,7 +1138,7 @@ export function attach(
 memoizedState.hasOwnProperty('create')&&
 memoizedState.hasOwnProperty('destroy')&&
 memoizedState.hasOwnProperty('deps')&&
-(memoizedState.deps===null||Array.isArray(memoizedState.deps))&&
+(memoizedState.deps===null||isArray(memoizedState.deps))&&
 memoizedState.hasOwnProperty('next')
 );
 }

packages/react-devtools-shared/src/backend/utils.js

@@ -9,6 +9,7 @@
 
 import{copy}from'clipboard-js';
 import{dehydrate}from'../hydration';
+importisArrayfrom'shared/isArray';
 
 importtype{DehydratedData}from'react-devtools-shared/src/devtools/views/Components/types';
 
@@ -61,9 +62,9 @@ export function copyWithDelete(
 index: number=0,
 ): Object|Array<any>{
  const key=path[index];
-constupdated=Array.isArray(obj) ? obj.slice() : {...obj};
+constupdated=isArray(obj) ? obj.slice() : {...obj};
 if(index+1===path.length){
-if(Array.isArray(updated)){
+if(isArray(updated)){
 updated.splice(((key: any): number),1);
 }else{
 deleteupdated[key];
@@ -84,12 +85,12 @@ export function copyWithRename(
 index: number=0,
 ): Object|Array<any>{
 const oldKey =oldPath[index];
-constupdated=Array.isArray(obj) ? obj.slice() : {...obj};
+constupdated=isArray(obj) ? obj.slice() : {...obj};
 if(index+1===oldPath.length){
 constnewKey=newPath[index];
 // $FlowFixMe number or string is fine here
 updated[newKey]=updated[oldKey];
-if(Array.isArray(updated)){
+if(isArray(updated)){
 updated.splice(((oldKey: any): number),1);
 }else{
 deleteupdated[oldKey];
@@ -111,7 +112,7 @@ export function copyWithSet(
 returnvalue;
 }
 const key =path[index];
-constupdated=Array.isArray(obj) ? obj.slice() : {...obj};
+constupdated=isArray(obj) ? obj.slice() : {...obj};
 // $FlowFixMe number or string is fine here
 updated[key]=copyWithSet(obj[key],path,value,index+1);
 returnupdated;

packages/react-dom/src/client/ReactDOMSelect.js

@@ -12,6 +12,7 @@ import {getCurrentFiberOwnerNameInDevOrNull} from 'react-reconciler/src/ReactCur
 
 import{checkControlledValueProps}from'../shared/ReactControlledValuePropTypes';
 import{getToStringValue,toString}from'./ToStringValue';
+importisArrayfrom'shared/isArray';
 
 letdidWarnValueDefaultValue;
 
@@ -45,15 +46,15 @@ function checkSelectPropTypes(props) {
 if(props[propName]==null){
 continue;
 }
-constisArray=Array.isArray(props[propName]);
-if(props.multiple&&!isArray){
+constpropNameIsArray=isArray(props[propName]);
+if(props.multiple&&!propNameIsArray){
 console.error(
 'The `%s` prop supplied to <select> must be an array if '+
 '`multiple` is true.%s',
 propName,
 getDeclarationErrorAddendum(),
 );
-}elseif(!props.multiple&&isArray){
+}elseif(!props.multiple&&propNameIsArray){
 console.error(
 'The `%s` prop supplied to <select> must be a scalar '+
 'value if `multiple` is false.%s',

packages/react-dom/src/client/ReactDOMTextarea.js

@@ -8,12 +8,12 @@
  */
 
 importinvariantfrom'shared/invariant';
+importisArrayfrom'shared/isArray';
 
 import{checkControlledValueProps}from'../shared/ReactControlledValuePropTypes';
 import{getCurrentFiberOwnerNameInDevOrNull}from'react-reconciler/src/ReactCurrentFiber';
 import{getToStringValue,toString}from'./ToStringValue';
 importtype{ToStringValue}from'./ToStringValue';
-
 import{disableTextareaChildren}from'shared/ReactFeatureFlags';
 
 letdidWarnValDefaultVal=false;
@@ -100,7 +100,7 @@ export function initWrapperState(element: Element, props: Object) {
 defaultValue==null,
 'If you supply `defaultValue` on a <textarea>, do not pass children.',
 );
-if(Array.isArray(children)){
+if(isArray(children)){
 invariant(
 children.length<=1,
 '<textarea> can only have at most one child.',

packages/react-dom/src/server/ReactDOMServerFormatConfig.js

@@ -46,8 +46,7 @@ import hyphenateStyleName from '../shared/hyphenateStyleName';
 importinvariantfrom'shared/invariant';
 importhasOwnPropertyfrom'shared/hasOwnProperty';
 importsanitizeURLfrom'../shared/sanitizeURL';
-
-constisArray=Array.isArray;
+importisArrayfrom'shared/isArray';
 
 // Per response, global state that is not contextual to the rendering subtree.
 exporttypeResponseState={

packages/react-dom/src/server/ReactPartialRenderer.js

@@ -14,6 +14,7 @@ import type {ReactProvider, ReactContext} from 'shared/ReactTypes';
 
 import*asReactfrom'react';
 importinvariantfrom'shared/invariant';
+importisArrayfrom'shared/isArray';
 importgetComponentNameFromTypefrom'shared/getComponentNameFromType';
 import{describeUnknownElementTypeFrameInDEV}from'shared/ReactComponentStackFrame';
 importReactSharedInternalsfrom'shared/ReactSharedInternals';
@@ -1438,7 +1439,7 @@ class ReactDOMServerRenderer {
 defaultValue==null,
 'If you supply `defaultValue` on a <textarea>, do not pass children.',
 );
-if(Array.isArray(textareaChildren)){
+if(isArray(textareaChildren)){
 invariant(
 textareaChildren.length<=1,
 '<textarea> can only have at most one child.',
@@ -1467,14 +1468,14 @@ class ReactDOMServerRenderer {
 if(props[propName]==null){
 continue;
 }
-constisArray=Array.isArray(props[propName]);
-if(props.multiple&&!isArray){
+constpropNameIsArray=isArray(props[propName]);
+if(props.multiple&&!propNameIsArray){
 console.error(
 'The `%s` prop supplied to <select> must be an array if '+
 '`multiple` is true.',
 propName,
 );
-}elseif(!props.multiple&&isArray){
+}elseif(!props.multiple&&propNameIsArray){
 console.error(
 'The `%s` prop supplied to <select> must be a scalar '+
 'value if `multiple` is false.',
@@ -1515,7 +1516,7 @@ class ReactDOMServerRenderer {
 value=optionChildren;
 }
 selected=false;
-if(Array.isArray(selectValue)){
+if(isArray(selectValue)){
 // multiple
 for(letj=0;j<selectValue.length;j++){
 if(''+selectValue[j]===value){

packages/react-dom/src/test-utils/ReactTestUtils.js

@@ -24,6 +24,7 @@ import {
 rethrowCaughtError,
 invokeGuardedCallbackAndCatchFirstError,
 }from'shared/ReactErrorUtils';
+importisArrayfrom'shared/isArray';
 
 // Keep in sync with ReactDOM.js, and ReactTestUtilsAct.js:
 constEventInternals=
@@ -97,7 +98,7 @@ function validateClassInstance(inst, methodName) {
 }
 letreceived;
 conststringified=''+inst;
-if(Array.isArray(inst)){
+if(isArray(inst)){
 received='an array';
 }elseif(inst&&inst.nodeType===ELEMENT_NODE&&inst.tagName){
 received='a DOM node';
@@ -197,7 +198,7 @@ function scryRenderedDOMComponentsWithClass(root, classNames) {
 }
 constclassList=className.split(/\s+/);
 
-if(!Array.isArray(classNames)){
+if(!isArray(classNames)){
 invariant(
 classNames!==undefined,
 'TestUtils.scryRenderedDOMComponentsWithClass expects a '+
@@ -365,7 +366,7 @@ function executeDispatch(event, listener, inst) {
 functionexecuteDispatchesInOrder(event){
 constdispatchListeners=event._dispatchListeners;
 constdispatchInstances=event._dispatchInstances;
-if(Array.isArray(dispatchListeners)){
+if(isArray(dispatchListeners)){
 for(leti=0;i<dispatchListeners.length;i++){
 if(event.isPropagationStopped()){
 break;

packages/react-native-renderer/src/ReactNativeAttributePayload.js

@@ -12,6 +12,7 @@ import {
 deepDiffer,
 flattenStyle,
 }from'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
+importisArrayfrom'shared/isArray';
 
 importtype{AttributeConfiguration}from'./ReactNativeTypes';
 
@@ -51,7 +52,7 @@ function restoreDeletedValuesInNestedArray(
 node: NestedNode,
 validAttributes: AttributeConfiguration,
 ){
-if(Array.isArray(node)){
+if(isArray(node)){
 leti=node.length;
 while(i--&&removedKeyCount>0){
 restoreDeletedValuesInNestedArray(
@@ -163,12 +164,12 @@ function diffNestedProperty(
 returnupdatePayload;
 }
 
-if(!Array.isArray(prevProp)&&!Array.isArray(nextProp)){
+if(!isArray(prevProp)&&!isArray(nextProp)){
 // Both are leaves, we can diff the leaves.
 returndiffProperties(updatePayload,prevProp,nextProp,validAttributes);
 }
 
-if(Array.isArray(prevProp)&&Array.isArray(nextProp)){
+if(isArray(prevProp)&&isArray(nextProp)){
 // Both are arrays, we can diff the arrays.
 returndiffNestedArrayProperty(
 updatePayload,
@@ -178,7 +179,7 @@ function diffNestedProperty(
 );
 }
 
-if(Array.isArray(prevProp)){
+if(isArray(prevProp)){
 returndiffProperties(
 updatePayload,
 // $FlowFixMe - We know that this is always an object when the input is.
@@ -212,7 +213,7 @@ function addNestedProperty(
 returnupdatePayload;
 }
 
-if(!Array.isArray(nextProp)){
+if(!isArray(nextProp)){
 // Add each property of the leaf.
 returnaddProperties(updatePayload,nextProp,validAttributes);
 }
@@ -242,7 +243,7 @@ function clearNestedProperty(
 returnupdatePayload;
 }
 
-if(!Array.isArray(prevProp)){
+if(!isArray(prevProp)){
 // Add each property of the leaf.
 returnclearProperties(updatePayload,prevProp,validAttributes);
 }