Skip to content

Commit 2788d0d

Browse files
sebmarkbagesebmarkbage
authored
Allow empty string to be passed to formAction (#26379)
We disallow empty strings for `href` and `src` since they're common mistakes that end up loading the current page as a preload, image or link. We also disallow it for `action`. You have to pass `null` which is the same. However, for `formAction` passing `null` is not the same as passing empty string. Passing empty string overrides the form's action to be the current page even if the form's action was set to something else. There's no easy way to express the same thing `#` show up in the user visible URLs and `?` clears the search params. Since this is also not a common mistake, we can just allow this.
1 parent f828bad commit 2788d0d

3 files changed

Lines changed: 23 additions & 23 deletions

File tree

‎packages/react-dom-bindings/src/shared/DOMProperty.js‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord(
636636
false,// removeEmptyString
637637
);
638638

639-
['src','href','action','formAction'].forEach(attributeName=>{
639+
constformAction='formAction';
640+
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641+
properties[formAction]=newPropertyInfoRecord(
642+
'formAction',
643+
STRING,
644+
false,// mustUseProperty
645+
'formaction',// attributeName
646+
null,// attributeNamespace
647+
true,// sanitizeURL
648+
false,// removeEmptyString
649+
);
650+
651+
['src','href','action'].forEach(attributeName=>{
640652
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641653
properties[attributeName]=newPropertyInfoRecord(
642654
attributeName,

‎packages/react-dom/src/__tests__/ReactDOMComponent-test.js‎

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => {
533533
expect(node.hasAttribute('action')).toBe(false);
534534
});
535535

536-
it('should not add an empty formAction attribute',()=>{
536+
it('allows empty string of a formAction to override the default of a parent',()=>{
537537
constcontainer=document.createElement('div');
538-
expect(()=>
539-
ReactDOM.render(<buttonformAction=""/>,container),
540-
).toErrorDev(
541-
'An empty string ("") was passed to the formAction attribute. '+
542-
'To fix this, either do not render the element at all '+
543-
'or pass null to formAction instead of an empty string.',
544-
);
545-
constnode=container.firstChild;
546-
expect(node.hasAttribute('formAction')).toBe(false);
547-
548-
ReactDOM.render(<buttonformAction="abc"/>,container);
549-
expect(node.hasAttribute('formAction')).toBe(true);
550-
551-
expect(()=>
552-
ReactDOM.render(<buttonformAction=""/>,container),
553-
).toErrorDev(
554-
'An empty string ("") was passed to the formAction attribute. '+
555-
'To fix this, either do not render the element at all '+
556-
'or pass null to formAction instead of an empty string.',
538+
ReactDOM.render(
539+
<formaction="hello">
540+
<buttonformAction=""/>,
541+
</form>,
542+
container,
557543
);
558-
expect(node.hasAttribute('formAction')).toBe(false);
544+
constnode=container.firstChild.firstChild;
545+
expect(node.hasAttribute('formaction')).toBe(true);
546+
expect(node.getAttribute('formaction')).toBe('');
559547
});
560548

561549
it('should not filter attributes for custom elements',()=>{

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const disableInputAttributeSyncing = false;
172172
// Filter certain DOM attributes (e.g. src, href) if their values are empty
173173
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
174174
// request for certain browsers.
175-
exportconstenableFilterEmptyStringAttributesDOM=false;
175+
exportconstenableFilterEmptyStringAttributesDOM=__EXPERIMENTAL__;
176176

177177
// Changes the behavior for rendering custom elements in both server rendering
178178
// and client rendering, mostly to allow JSX attributes to apply to the custom

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Allow empty string to be passed to formAction (#26379) · react/react@2788d0d · GitHub
Skip to content
Commit 2788d0d
Browse files
sebmarkbagesebmarkbage
authored
Allow empty string to be passed to formAction (#26379)
We disallow empty strings for `href` and `src` since they're common
mistakes that end up loading the current page as a preload, image or
link. We also disallow it for `action`. You have to pass `null` which is
the same.
However, for `formAction` passing `null` is not the same as passing
empty string. Passing empty string overrides the form's action to be the
current page even if the form's action was set to something else.
There's no easy way to express the same thing `#` show up in the user
visible URLs and `?` clears the search params.
Since this is also not a common mistake, we can just allow this.
1 parent f828bad commit 2788d0d
3 files changed
Lines changed: 23 additions & 23 deletions
File tree
‎packages/react-dom-bindings/src/shared/DOMProperty.js‎
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord(
636636
false,// removeEmptyString
637637
);
638638

639-
['src','href','action','formAction'].forEach(attributeName=>{
639+
constformAction='formAction';
640+
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641+
properties[formAction]=newPropertyInfoRecord(
642+
'formAction',
643+
STRING,
644+
false,// mustUseProperty
645+
'formaction',// attributeName
646+
null,// attributeNamespace
647+
true,// sanitizeURL
648+
false,// removeEmptyString
649+
);
650+
651+
['src','href','action'].forEach(attributeName=>{
640652
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641653
properties[attributeName]=newPropertyInfoRecord(
642654
attributeName,
‎packages/react-dom/src/__tests__/ReactDOMComponent-test.js‎
Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => {
533533
expect(node.hasAttribute('action')).toBe(false);
534534
});
535535

536-
it('should not add an empty formAction attribute',()=>{
536+
it('allows empty string of a formAction to override the default of a parent',()=>{
537537
constcontainer=document.createElement('div');
538-
expect(()=>
539-
ReactDOM.render(<buttonformAction=""/>,container),
540-
).toErrorDev(
541-
'An empty string ("") was passed to the formAction attribute. '+
542-
'To fix this, either do not render the element at all '+
543-
'or pass null to formAction instead of an empty string.',
544-
);
545-
constnode=container.firstChild;
546-
expect(node.hasAttribute('formAction')).toBe(false);
547-
548-
ReactDOM.render(<buttonformAction="abc"/>,container);
549-
expect(node.hasAttribute('formAction')).toBe(true);
550-
551-
expect(()=>
552-
ReactDOM.render(<buttonformAction=""/>,container),
553-
).toErrorDev(
554-
'An empty string ("") was passed to the formAction attribute. '+
555-
'To fix this, either do not render the element at all '+
556-
'or pass null to formAction instead of an empty string.',
538+
ReactDOM.render(
539+
<formaction="hello">
540+
<buttonformAction=""/>,
541+
</form>,
542+
container,
557543
);
558-
expect(node.hasAttribute('formAction')).toBe(false);
544+
constnode=container.firstChild.firstChild;
545+
expect(node.hasAttribute('formaction')).toBe(true);
546+
expect(node.getAttribute('formaction')).toBe('');
559547
});
560548

561549
it('should not filter attributes for custom elements',()=>{
‎packages/shared/ReactFeatureFlags.js‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const disableInputAttributeSyncing = false;
172172
// Filter certain DOM attributes (e.g. src, href) if their values are empty
173173
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
174174
// request for certain browsers.
175-
exportconstenableFilterEmptyStringAttributesDOM=false;
175+
exportconstenableFilterEmptyStringAttributesDOM=__EXPERIMENTAL__;
176176

177177
// Changes the behavior for rendering custom elements in both server rendering
178178
// and client rendering, mostly to allow JSX attributes to apply to the custom
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow empty string to be passed to formAction (#26379) · react/react@2788d0d · GitHub
Skip to content
Commit 2788d0d
Browse files
sebmarkbagesebmarkbage
authored
Allow empty string to be passed to formAction (#26379)
We disallow empty strings for `href` and `src` since they're common
mistakes that end up loading the current page as a preload, image or
link. We also disallow it for `action`. You have to pass `null` which is
the same.
However, for `formAction` passing `null` is not the same as passing
empty string. Passing empty string overrides the form's action to be the
current page even if the form's action was set to something else.
There's no easy way to express the same thing `#` show up in the user
visible URLs and `?` clears the search params.
Since this is also not a common mistake, we can just allow this.
1 parent f828bad commit 2788d0d
3 files changed
Lines changed: 23 additions & 23 deletions
File tree
‎packages/react-dom-bindings/src/shared/DOMProperty.js‎
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord(
636636
false,// removeEmptyString
637637
);
638638

639-
['src','href','action','formAction'].forEach(attributeName=>{
639+
constformAction='formAction';
640+
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641+
properties[formAction]=newPropertyInfoRecord(
642+
'formAction',
643+
STRING,
644+
false,// mustUseProperty
645+
'formaction',// attributeName
646+
null,// attributeNamespace
647+
true,// sanitizeURL
648+
false,// removeEmptyString
649+
);
650+
651+
['src','href','action'].forEach(attributeName=>{
640652
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641653
properties[attributeName]=newPropertyInfoRecord(
642654
attributeName,
‎packages/react-dom/src/__tests__/ReactDOMComponent-test.js‎
Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => {
533533
expect(node.hasAttribute('action')).toBe(false);
534534
});
535535

536-
it('should not add an empty formAction attribute',()=>{
536+
it('allows empty string of a formAction to override the default of a parent',()=>{
537537
constcontainer=document.createElement('div');
538-
expect(()=>
539-
ReactDOM.render(<buttonformAction=""/>,container),
540-
).toErrorDev(
541-
'An empty string ("") was passed to the formAction attribute. '+
542-
'To fix this, either do not render the element at all '+
543-
'or pass null to formAction instead of an empty string.',
544-
);
545-
constnode=container.firstChild;
546-
expect(node.hasAttribute('formAction')).toBe(false);
547-
548-
ReactDOM.render(<buttonformAction="abc"/>,container);
549-
expect(node.hasAttribute('formAction')).toBe(true);
550-
551-
expect(()=>
552-
ReactDOM.render(<buttonformAction=""/>,container),
553-
).toErrorDev(
554-
'An empty string ("") was passed to the formAction attribute. '+
555-
'To fix this, either do not render the element at all '+
556-
'or pass null to formAction instead of an empty string.',
538+
ReactDOM.render(
539+
<formaction="hello">
540+
<buttonformAction=""/>,
541+
</form>,
542+
container,
557543
);
558-
expect(node.hasAttribute('formAction')).toBe(false);
544+
constnode=container.firstChild.firstChild;
545+
expect(node.hasAttribute('formaction')).toBe(true);
546+
expect(node.getAttribute('formaction')).toBe('');
559547
});
560548

561549
it('should not filter attributes for custom elements',()=>{
‎packages/shared/ReactFeatureFlags.js‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const disableInputAttributeSyncing = false;
172172
// Filter certain DOM attributes (e.g. src, href) if their values are empty
173173
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
174174
// request for certain browsers.
175-
exportconstenableFilterEmptyStringAttributesDOM=false;
175+
exportconstenableFilterEmptyStringAttributesDOM=__EXPERIMENTAL__;
176176

177177
// Changes the behavior for rendering custom elements in both server rendering
178178
// and client rendering, mostly to allow JSX attributes to apply to the custom
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow empty string to be passed to formAction (#26379) · react/react@2788d0d · GitHub
Skip to content
Commit 2788d0d
Browse files
sebmarkbagesebmarkbage
authored
Allow empty string to be passed to formAction (#26379)
We disallow empty strings for `href` and `src` since they're common
mistakes that end up loading the current page as a preload, image or
link. We also disallow it for `action`. You have to pass `null` which is
the same.
However, for `formAction` passing `null` is not the same as passing
empty string. Passing empty string overrides the form's action to be the
current page even if the form's action was set to something else.
There's no easy way to express the same thing `#` show up in the user
visible URLs and `?` clears the search params.
Since this is also not a common mistake, we can just allow this.
1 parent f828bad commit 2788d0d
3 files changed
Lines changed: 23 additions & 23 deletions
File tree
‎packages/react-dom-bindings/src/shared/DOMProperty.js‎
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord(
636636
false,// removeEmptyString
637637
);
638638

639-
['src','href','action','formAction'].forEach(attributeName=>{
639+
constformAction='formAction';
640+
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641+
properties[formAction]=newPropertyInfoRecord(
642+
'formAction',
643+
STRING,
644+
false,// mustUseProperty
645+
'formaction',// attributeName
646+
null,// attributeNamespace
647+
true,// sanitizeURL
648+
false,// removeEmptyString
649+
);
650+
651+
['src','href','action'].forEach(attributeName=>{
640652
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641653
properties[attributeName]=newPropertyInfoRecord(
642654
attributeName,
‎packages/react-dom/src/__tests__/ReactDOMComponent-test.js‎
Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => {
533533
expect(node.hasAttribute('action')).toBe(false);
534534
});
535535

536-
it('should not add an empty formAction attribute',()=>{
536+
it('allows empty string of a formAction to override the default of a parent',()=>{
537537
constcontainer=document.createElement('div');
538-
expect(()=>
539-
ReactDOM.render(<buttonformAction=""/>,container),
540-
).toErrorDev(
541-
'An empty string ("") was passed to the formAction attribute. '+
542-
'To fix this, either do not render the element at all '+
543-
'or pass null to formAction instead of an empty string.',
544-
);
545-
constnode=container.firstChild;
546-
expect(node.hasAttribute('formAction')).toBe(false);
547-
548-
ReactDOM.render(<buttonformAction="abc"/>,container);
549-
expect(node.hasAttribute('formAction')).toBe(true);
550-
551-
expect(()=>
552-
ReactDOM.render(<buttonformAction=""/>,container),
553-
).toErrorDev(
554-
'An empty string ("") was passed to the formAction attribute. '+
555-
'To fix this, either do not render the element at all '+
556-
'or pass null to formAction instead of an empty string.',
538+
ReactDOM.render(
539+
<formaction="hello">
540+
<buttonformAction=""/>,
541+
</form>,
542+
container,
557543
);
558-
expect(node.hasAttribute('formAction')).toBe(false);
544+
constnode=container.firstChild.firstChild;
545+
expect(node.hasAttribute('formaction')).toBe(true);
546+
expect(node.getAttribute('formaction')).toBe('');
559547
});
560548

561549
it('should not filter attributes for custom elements',()=>{
‎packages/shared/ReactFeatureFlags.js‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const disableInputAttributeSyncing = false;
172172
// Filter certain DOM attributes (e.g. src, href) if their values are empty
173173
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
174174
// request for certain browsers.
175-
exportconstenableFilterEmptyStringAttributesDOM=false;
175+
exportconstenableFilterEmptyStringAttributesDOM=__EXPERIMENTAL__;
176176

177177
// Changes the behavior for rendering custom elements in both server rendering
178178
// and client rendering, mostly to allow JSX attributes to apply to the custom
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Allow empty string to be passed to formAction (#26379) · react/react@2788d0d · GitHub
Skip to content
Commit 2788d0d
Browse files
sebmarkbagesebmarkbage
authored
Allow empty string to be passed to formAction (#26379)
We disallow empty strings for `href` and `src` since they're common
mistakes that end up loading the current page as a preload, image or
link. We also disallow it for `action`. You have to pass `null` which is
the same.
However, for `formAction` passing `null` is not the same as passing
empty string. Passing empty string overrides the form's action to be the
current page even if the form's action was set to something else.
There's no easy way to express the same thing `#` show up in the user
visible URLs and `?` clears the search params.
Since this is also not a common mistake, we can just allow this.
1 parent f828bad commit 2788d0d
3 files changed
Lines changed: 23 additions & 23 deletions
File tree
‎packages/react-dom-bindings/src/shared/DOMProperty.js‎
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord(
636636
false,// removeEmptyString
637637
);
638638

639-
['src','href','action','formAction'].forEach(attributeName=>{
639+
constformAction='formAction';
640+
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641+
properties[formAction]=newPropertyInfoRecord(
642+
'formAction',
643+
STRING,
644+
false,// mustUseProperty
645+
'formaction',// attributeName
646+
null,// attributeNamespace
647+
true,// sanitizeURL
648+
false,// removeEmptyString
649+
);
650+
651+
['src','href','action'].forEach(attributeName=>{
640652
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641653
properties[attributeName]=newPropertyInfoRecord(
642654
attributeName,
‎packages/react-dom/src/__tests__/ReactDOMComponent-test.js‎
Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => {
533533
expect(node.hasAttribute('action')).toBe(false);
534534
});
535535

536-
it('should not add an empty formAction attribute',()=>{
536+
it('allows empty string of a formAction to override the default of a parent',()=>{
537537
constcontainer=document.createElement('div');
538-
expect(()=>
539-
ReactDOM.render(<buttonformAction=""/>,container),
540-
).toErrorDev(
541-
'An empty string ("") was passed to the formAction attribute. '+
542-
'To fix this, either do not render the element at all '+
543-
'or pass null to formAction instead of an empty string.',
544-
);
545-
constnode=container.firstChild;
546-
expect(node.hasAttribute('formAction')).toBe(false);
547-
548-
ReactDOM.render(<buttonformAction="abc"/>,container);
549-
expect(node.hasAttribute('formAction')).toBe(true);
550-
551-
expect(()=>
552-
ReactDOM.render(<buttonformAction=""/>,container),
553-
).toErrorDev(
554-
'An empty string ("") was passed to the formAction attribute. '+
555-
'To fix this, either do not render the element at all '+
556-
'or pass null to formAction instead of an empty string.',
538+
ReactDOM.render(
539+
<formaction="hello">
540+
<buttonformAction=""/>,
541+
</form>,
542+
container,
557543
);
558-
expect(node.hasAttribute('formAction')).toBe(false);
544+
constnode=container.firstChild.firstChild;
545+
expect(node.hasAttribute('formaction')).toBe(true);
546+
expect(node.getAttribute('formaction')).toBe('');
559547
});
560548

561549
it('should not filter attributes for custom elements',()=>{
‎packages/shared/ReactFeatureFlags.js‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const disableInputAttributeSyncing = false;
172172
// Filter certain DOM attributes (e.g. src, href) if their values are empty
173173
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
174174
// request for certain browsers.
175-
exportconstenableFilterEmptyStringAttributesDOM=false;
175+
exportconstenableFilterEmptyStringAttributesDOM=__EXPERIMENTAL__;
176176

177177
// Changes the behavior for rendering custom elements in both server rendering
178178
// and client rendering, mostly to allow JSX attributes to apply to the custom
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow empty string to be passed to formAction (#26379) · react/react@2788d0d · GitHub
Skip to content
Commit 2788d0d
Browse files
sebmarkbagesebmarkbage
authored
Allow empty string to be passed to formAction (#26379)
We disallow empty strings for `href` and `src` since they're common
mistakes that end up loading the current page as a preload, image or
link. We also disallow it for `action`. You have to pass `null` which is
the same.
However, for `formAction` passing `null` is not the same as passing
empty string. Passing empty string overrides the form's action to be the
current page even if the form's action was set to something else.
There's no easy way to express the same thing `#` show up in the user
visible URLs and `?` clears the search params.
Since this is also not a common mistake, we can just allow this.
1 parent f828bad commit 2788d0d
3 files changed
Lines changed: 23 additions & 23 deletions
File tree
‎packages/react-dom-bindings/src/shared/DOMProperty.js‎
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord(
636636
false,// removeEmptyString
637637
);
638638

639-
['src','href','action','formAction'].forEach(attributeName=>{
639+
constformAction='formAction';
640+
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641+
properties[formAction]=newPropertyInfoRecord(
642+
'formAction',
643+
STRING,
644+
false,// mustUseProperty
645+
'formaction',// attributeName
646+
null,// attributeNamespace
647+
true,// sanitizeURL
648+
false,// removeEmptyString
649+
);
650+
651+
['src','href','action'].forEach(attributeName=>{
640652
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641653
properties[attributeName]=newPropertyInfoRecord(
642654
attributeName,
‎packages/react-dom/src/__tests__/ReactDOMComponent-test.js‎
Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => {
533533
expect(node.hasAttribute('action')).toBe(false);
534534
});
535535

536-
it('should not add an empty formAction attribute',()=>{
536+
it('allows empty string of a formAction to override the default of a parent',()=>{
537537
constcontainer=document.createElement('div');
538-
expect(()=>
539-
ReactDOM.render(<buttonformAction=""/>,container),
540-
).toErrorDev(
541-
'An empty string ("") was passed to the formAction attribute. '+
542-
'To fix this, either do not render the element at all '+
543-
'or pass null to formAction instead of an empty string.',
544-
);
545-
constnode=container.firstChild;
546-
expect(node.hasAttribute('formAction')).toBe(false);
547-
548-
ReactDOM.render(<buttonformAction="abc"/>,container);
549-
expect(node.hasAttribute('formAction')).toBe(true);
550-
551-
expect(()=>
552-
ReactDOM.render(<buttonformAction=""/>,container),
553-
).toErrorDev(
554-
'An empty string ("") was passed to the formAction attribute. '+
555-
'To fix this, either do not render the element at all '+
556-
'or pass null to formAction instead of an empty string.',
538+
ReactDOM.render(
539+
<formaction="hello">
540+
<buttonformAction=""/>,
541+
</form>,
542+
container,
557543
);
558-
expect(node.hasAttribute('formAction')).toBe(false);
544+
constnode=container.firstChild.firstChild;
545+
expect(node.hasAttribute('formaction')).toBe(true);
546+
expect(node.getAttribute('formaction')).toBe('');
559547
});
560548

561549
it('should not filter attributes for custom elements',()=>{
‎packages/shared/ReactFeatureFlags.js‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const disableInputAttributeSyncing = false;
172172
// Filter certain DOM attributes (e.g. src, href) if their values are empty
173173
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
174174
// request for certain browsers.
175-
exportconstenableFilterEmptyStringAttributesDOM=false;
175+
exportconstenableFilterEmptyStringAttributesDOM=__EXPERIMENTAL__;
176176

177177
// Changes the behavior for rendering custom elements in both server rendering
178178
// and client rendering, mostly to allow JSX attributes to apply to the custom
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Allow empty string to be passed to formAction (#26379) · react/react@2788d0d · GitHub
Skip to content
Commit 2788d0d
Browse files
sebmarkbagesebmarkbage
authored
Allow empty string to be passed to formAction (#26379)
We disallow empty strings for `href` and `src` since they're common
mistakes that end up loading the current page as a preload, image or
link. We also disallow it for `action`. You have to pass `null` which is
the same.
However, for `formAction` passing `null` is not the same as passing
empty string. Passing empty string overrides the form's action to be the
current page even if the form's action was set to something else.
There's no easy way to express the same thing `#` show up in the user
visible URLs and `?` clears the search params.
Since this is also not a common mistake, we can just allow this.
1 parent f828bad commit 2788d0d
3 files changed
Lines changed: 23 additions & 23 deletions
File tree
‎packages/react-dom-bindings/src/shared/DOMProperty.js‎
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord(
636636
false,// removeEmptyString
637637
);
638638

639-
['src','href','action','formAction'].forEach(attributeName=>{
639+
constformAction='formAction';
640+
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641+
properties[formAction]=newPropertyInfoRecord(
642+
'formAction',
643+
STRING,
644+
false,// mustUseProperty
645+
'formaction',// attributeName
646+
null,// attributeNamespace
647+
true,// sanitizeURL
648+
false,// removeEmptyString
649+
);
650+
651+
['src','href','action'].forEach(attributeName=>{
640652
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641653
properties[attributeName]=newPropertyInfoRecord(
642654
attributeName,
‎packages/react-dom/src/__tests__/ReactDOMComponent-test.js‎
Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => {
533533
expect(node.hasAttribute('action')).toBe(false);
534534
});
535535

536-
it('should not add an empty formAction attribute',()=>{
536+
it('allows empty string of a formAction to override the default of a parent',()=>{
537537
constcontainer=document.createElement('div');
538-
expect(()=>
539-
ReactDOM.render(<buttonformAction=""/>,container),
540-
).toErrorDev(
541-
'An empty string ("") was passed to the formAction attribute. '+
542-
'To fix this, either do not render the element at all '+
543-
'or pass null to formAction instead of an empty string.',
544-
);
545-
constnode=container.firstChild;
546-
expect(node.hasAttribute('formAction')).toBe(false);
547-
548-
ReactDOM.render(<buttonformAction="abc"/>,container);
549-
expect(node.hasAttribute('formAction')).toBe(true);
550-
551-
expect(()=>
552-
ReactDOM.render(<buttonformAction=""/>,container),
553-
).toErrorDev(
554-
'An empty string ("") was passed to the formAction attribute. '+
555-
'To fix this, either do not render the element at all '+
556-
'or pass null to formAction instead of an empty string.',
538+
ReactDOM.render(
539+
<formaction="hello">
540+
<buttonformAction=""/>,
541+
</form>,
542+
container,
557543
);
558-
expect(node.hasAttribute('formAction')).toBe(false);
544+
constnode=container.firstChild.firstChild;
545+
expect(node.hasAttribute('formaction')).toBe(true);
546+
expect(node.getAttribute('formaction')).toBe('');
559547
});
560548

561549
it('should not filter attributes for custom elements',()=>{
‎packages/shared/ReactFeatureFlags.js‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const disableInputAttributeSyncing = false;
172172
// Filter certain DOM attributes (e.g. src, href) if their values are empty
173173
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
174174
// request for certain browsers.
175-
exportconstenableFilterEmptyStringAttributesDOM=false;
175+
exportconstenableFilterEmptyStringAttributesDOM=__EXPERIMENTAL__;
176176

177177
// Changes the behavior for rendering custom elements in both server rendering
178178
// and client rendering, mostly to allow JSX attributes to apply to the custom
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Allow empty string to be passed to formAction (#26379) · react/react@2788d0d · GitHub
Skip to content
Commit 2788d0d
Browse files
sebmarkbagesebmarkbage
authored
Allow empty string to be passed to formAction (#26379)
We disallow empty strings for `href` and `src` since they're common
mistakes that end up loading the current page as a preload, image or
link. We also disallow it for `action`. You have to pass `null` which is
the same.
However, for `formAction` passing `null` is not the same as passing
empty string. Passing empty string overrides the form's action to be the
current page even if the form's action was set to something else.
There's no easy way to express the same thing `#` show up in the user
visible URLs and `?` clears the search params.
Since this is also not a common mistake, we can just allow this.
1 parent f828bad commit 2788d0d
3 files changed
Lines changed: 23 additions & 23 deletions
File tree
‎packages/react-dom-bindings/src/shared/DOMProperty.js‎
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,19 @@ properties[xlinkHref] = new PropertyInfoRecord(
636636
false,// removeEmptyString
637637
);
638638

639-
['src','href','action','formAction'].forEach(attributeName=>{
639+
constformAction='formAction';
640+
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641+
properties[formAction]=newPropertyInfoRecord(
642+
'formAction',
643+
STRING,
644+
false,// mustUseProperty
645+
'formaction',// attributeName
646+
null,// attributeNamespace
647+
true,// sanitizeURL
648+
false,// removeEmptyString
649+
);
650+
651+
['src','href','action'].forEach(attributeName=>{
640652
// $FlowFixMe[invalid-constructor] Flow no longer supports calling new on functions
641653
properties[attributeName]=newPropertyInfoRecord(
642654
attributeName,
‎packages/react-dom/src/__tests__/ReactDOMComponent-test.js‎
Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -533,29 +533,17 @@ describe('ReactDOMComponent', () => {
533533
expect(node.hasAttribute('action')).toBe(false);
534534
});
535535

536-
it('should not add an empty formAction attribute',()=>{
536+
it('allows empty string of a formAction to override the default of a parent',()=>{
537537
constcontainer=document.createElement('div');
538-
expect(()=>
539-
ReactDOM.render(<buttonformAction=""/>,container),
540-
).toErrorDev(
541-
'An empty string ("") was passed to the formAction attribute. '+
542-
'To fix this, either do not render the element at all '+
543-
'or pass null to formAction instead of an empty string.',
544-
);
545-
constnode=container.firstChild;
546-
expect(node.hasAttribute('formAction')).toBe(false);
547-
548-
ReactDOM.render(<buttonformAction="abc"/>,container);
549-
expect(node.hasAttribute('formAction')).toBe(true);
550-
551-
expect(()=>
552-
ReactDOM.render(<buttonformAction=""/>,container),
553-
).toErrorDev(
554-
'An empty string ("") was passed to the formAction attribute. '+
555-
'To fix this, either do not render the element at all '+
556-
'or pass null to formAction instead of an empty string.',
538+
ReactDOM.render(
539+
<formaction="hello">
540+
<buttonformAction=""/>,
541+
</form>,
542+
container,
557543
);
558-
expect(node.hasAttribute('formAction')).toBe(false);
544+
constnode=container.firstChild.firstChild;
545+
expect(node.hasAttribute('formaction')).toBe(true);
546+
expect(node.getAttribute('formaction')).toBe('');
559547
});
560548

561549
it('should not filter attributes for custom elements',()=>{
‎packages/shared/ReactFeatureFlags.js‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ export const disableInputAttributeSyncing = false;
172172
// Filter certain DOM attributes (e.g. src, href) if their values are empty
173173
// strings. This prevents e.g. <img src=""> from making an unnecessary HTTP
174174
// request for certain browsers.
175-
exportconstenableFilterEmptyStringAttributesDOM=false;
175+
exportconstenableFilterEmptyStringAttributesDOM=__EXPERIMENTAL__;
176176

177177
// Changes the behavior for rendering custom elements in both server rendering
178178
// and client rendering, mostly to allow JSX attributes to apply to the custom
0 commit comments
Comments
 (0)