Avoid .valueOf to close #20594 (#20617)

dimaqq · web-flow · commit 2e948e0d9136 · 2021-01-19T20:59:31.000-05:00
diff --git a/packages/react-reconciler/src/ReactChildFiber.new.js b/packages/react-reconciler/src/ReactChildFiber.new.js
@@ -222,14 +222,15 @@ function coerceRef(
 
 function throwOnInvalidObjectType(returnFiber: Fiber, newChild: Object) {
 if (returnFiber.type !== 'textarea') {
+ const childString = Object.prototype.toString.call(newChild);
 invariant(
 false,
 'Objects are not valid as a React child (found: %s). ' +
 'If you meant to render a collection of children, use an array ' +
 'instead.',
- Object.prototype.toString.call(newChild) === '[object Object]'
+ childString === '[object Object]'
 ? 'object with keys {' + Object.keys(newChild).join(', ') + '}'
- : newChild,
+ : childString,
 );
 }
 }
diff --git a/packages/react-reconciler/src/ReactChildFiber.old.js b/packages/react-reconciler/src/ReactChildFiber.old.js
@@ -222,14 +222,15 @@ function coerceRef(
 
 function throwOnInvalidObjectType(returnFiber: Fiber, newChild: Object) {
 if (returnFiber.type !== 'textarea') {
+ const childString = Object.prototype.toString.call(newChild);
 invariant(
 false,
 'Objects are not valid as a React child (found: %s). ' +
 'If you meant to render a collection of children, use an array ' +
 'instead.',
- Object.prototype.toString.call(newChild) === '[object Object]'
+ childString === '[object Object]'
 ? 'object with keys {' + Object.keys(newChild).join(', ') + '}'
- : newChild,
+ : childString,
 );
 }
 }

-Original file line number
+Diff line change
 functionthrowOnInvalidObjectType(returnFiber: Fiber,newChild: Object){
 if(returnFiber.type!=='textarea'){
 +constchildString=Object.prototype.toString.call(newChild);
 invariant(
 false,
 'Objects are not valid as a React child (found: %s). '+
 'If you meant to render a collection of children, use an array '+
 'instead.',
 -Object.prototype.toString.call(newChild)==='[object Object]'
 +childString==='[object Object]'
  ? 'object with keys {'+Object.keys(newChild).join(', ')+'}'
 - : newChild,
 + : childString,
 );
+}
+}