Stop tracking bundle sizes (#15404)

* [sizebot] Fail gracefully if CI returns invalid response
Moves the `response.json()` call into the catch block.
* Stop tracking bundle sizes

Author: acdlite

.circleci/config.yml

@@ -47,7 +47,7 @@ jobs:
 path: ./build.tgz
 
  - store_artifacts:
-path: ./scripts/rollup/results.json
+path: ./build/bundle-sizes.json
 
  - store_artifacts:
 path: ./scripts/error-codes/codes.json

.gitignore

@@ -1,6 +1,7 @@
 .DS_STORE
 node_modules
 scripts/flow/*/.flowconfig
+scripts/rollup/results.json
 *~
 *.pyc
 .grunt

dangerfile.js

@@ -32,15 +32,15 @@ const {generateResultsArray} = require('./scripts/rollup/stats');
 const{existsSync, readFileSync}=require('fs');
 const{exec}=require('child_process');
 
-if(!existsSync('./scripts/rollup/results.json')){
+if(!existsSync('./build/bundle-sizes.json')){
 // This indicates the build failed previously.
 // In that case, there's nothing for the Dangerfile to do.
 // Exit early to avoid leaving a redundant (and potentially confusing) PR comment.
 process.exit(0);
 }
 
 constcurrentBuildResults=JSON.parse(
-readFileSync('./scripts/rollup/results.json')
+readFileSync('./build/bundle-sizes.json')
 );
 
 /**
@@ -118,7 +118,7 @@ function git(args) {
 awaitgit('fetch upstream');
 constbaseCommit=awaitgit(`merge-base HEAD upstream/${upstreamRef}`);
 
-letresultsResponse=null;
+letpreviousBuildResults=null;
 try{
 letbaseCIBuildId=null;
 conststatusesResponse=awaitfetch(
@@ -153,8 +153,9 @@ function git(args) {
 
 for(leti=0;i<baseArtifactsInfo.length;i++){
 constinfo=baseArtifactsInfo[i];
-if(info.path==='home/circleci/project/scripts/rollup/results.json'){
-resultsResponse=awaitfetch(info.url);
+if(info.path==='home/circleci/project/build/bundle-sizes.json'){
+constresultsResponse=awaitfetch(info.url);
+previousBuildResults=awaitresultsResponse.json();
 break;
 }
 }
@@ -163,14 +164,13 @@ function git(args) {
 return;
 }
 
-if(resultsResponse===null){
+if(previousBuildResults===null){
 warn(`Could not find build artifacts for base commit: ${baseCommit}`);
 return;
 }
 
 // Take the JSON of the build response and
 // make an array comparing the results for printing
-constpreviousBuildResults=awaitresultsResponse.json();
 constresults=generateResultsArray(
 currentBuildResults,
 previousBuildResults

scripts/circleci/test_entry_point.sh

@@ -30,6 +30,7 @@ if [ $((2 % CIRCLE_NODE_TOTAL)) -eq "$CIRCLE_NODE_INDEX" ]; then
  COMMANDS_TO_RUN+=('./scripts/circleci/build.sh')
  COMMANDS_TO_RUN+=('yarn test-build --maxWorkers=2')
  COMMANDS_TO_RUN+=('yarn test-build-prod --maxWorkers=2')
+ COMMANDS_TO_RUN+=('cp ./scripts/rollup/results.json ./build/bundle-sizes.json')
  COMMANDS_TO_RUN+=('node ./scripts/tasks/danger')
  COMMANDS_TO_RUN+=('./scripts/circleci/upload_build.sh')
  COMMANDS_TO_RUN+=('./scripts/circleci/pack_and_store_artifact.sh')