Add more feature flag checks (#24037)

Author: sebmarkbage

packages/react-reconciler/src/ReactFiber.new.js

@@ -26,6 +26,7 @@ import {
 enableSyncDefaultUpdates,
 allowConcurrentByDefault,
 enableTransitionTracing,
+enableDebugTracing,
 }from'shared/ReactFeatureFlags';
 import{
 supportsPersistence,
@@ -492,10 +493,6 @@ export function createFiberFromTypeAndProps(
  getTag: switch(type){
 caseREACT_FRAGMENT_TYPE:
 returncreateFiberFromFragment(pendingProps.children,mode,lanes,key);
-caseREACT_DEBUG_TRACING_MODE_TYPE:
-fiberTag=Mode;
-mode|=DebugTracingMode;
-break;
 caseREACT_STRICT_MODE_TYPE:
 fiberTag=Mode;
 mode|=StrictLegacyMode;
@@ -529,6 +526,13 @@ export function createFiberFromTypeAndProps(
 returncreateFiberFromTracingMarker(pendingProps,mode,lanes,key);
 }
 // eslint-disable-next-line no-fallthrough
+caseREACT_DEBUG_TRACING_MODE_TYPE:
+if(enableDebugTracing){
+fiberTag=Mode;
+mode|=DebugTracingMode;
+break;
+}
+// eslint-disable-next-line no-fallthrough
 default: {
 if(typeoftype==='object'&&type!==null){
 switch(type.$$typeof){

packages/react-reconciler/src/ReactFiber.old.js

@@ -26,6 +26,7 @@ import {
 enableSyncDefaultUpdates,
 allowConcurrentByDefault,
 enableTransitionTracing,
+enableDebugTracing,
 }from'shared/ReactFeatureFlags';
 import{
 supportsPersistence,
@@ -492,10 +493,6 @@ export function createFiberFromTypeAndProps(
  getTag: switch(type){
 caseREACT_FRAGMENT_TYPE:
 returncreateFiberFromFragment(pendingProps.children,mode,lanes,key);
-caseREACT_DEBUG_TRACING_MODE_TYPE:
-fiberTag=Mode;
-mode|=DebugTracingMode;
-break;
 caseREACT_STRICT_MODE_TYPE:
 fiberTag=Mode;
 mode|=StrictLegacyMode;
@@ -529,6 +526,13 @@ export function createFiberFromTypeAndProps(
 returncreateFiberFromTracingMarker(pendingProps,mode,lanes,key);
 }
 // eslint-disable-next-line no-fallthrough
+caseREACT_DEBUG_TRACING_MODE_TYPE:
+if(enableDebugTracing){
+fiberTag=Mode;
+mode|=DebugTracingMode;
+break;
+}
+// eslint-disable-next-line no-fallthrough
 default: {
 if(typeoftype==='object'&&type!==null){
 switch(type.$$typeof){

packages/react-reconciler/src/__tests__/DebugTracing-test.internal.js

@@ -45,7 +45,7 @@ describe('DebugTracing', () => {
 });
 });
 
-// @gateexperimental || www
+// @gateenableDebugTracing
 it('should not log anything for sync render without suspends or state updates',()=>{
 ReactTestRenderer.create(
 <React.unstable_DebugTracingMode>
@@ -56,8 +56,7 @@ describe('DebugTracing', () => {
 expect(logs).toEqual([]);
 });
 
-// @gate build === 'development'
-// @gate experimental || www
+// @gate experimental && build === 'development' && enableDebugTracing
 it('should not log anything for concurrent render without suspends or state updates',()=>{
 ReactTestRenderer.act(()=>
 ReactTestRenderer.create(
@@ -376,8 +375,7 @@ describe('DebugTracing', () => {
 ]);
 });
 
-// @gate build === 'development'
-// @gate experimental || www
+// @gate experimental && build === 'development' && enableDebugTracing
 it('should not log anything outside of a unstable_DebugTracingMode subtree',()=>{
 functionExampleThatCascades(){
 const[didMount,setDidMount]=React.useState(false);

packages/shared/getComponentNameFromType.js

@@ -26,6 +26,8 @@ import {
 REACT_TRACING_MARKER_TYPE,
 }from'shared/ReactSymbols';
 
+import{enableTransitionTracing,enableCache}from'./ReactFeatureFlags';
+
 // Keep in sync with react-reconciler/getComponentNameFromFiber
 functiongetWrappedName(
 outerType: mixed,
@@ -79,9 +81,14 @@ export default function getComponentNameFromType(type: mixed): string | null {
 caseREACT_SUSPENSE_LIST_TYPE:
 return'SuspenseList';
 caseREACT_CACHE_TYPE:
-return'Cache';
+if(enableCache){
+return'Cache';
+}
+// eslint-disable-next-line no-fallthrough
 caseREACT_TRACING_MARKER_TYPE:
-return'TracingMarker';
+if(enableTransitionTracing){
+return'TracingMarker';
+}
 }
 if(typeoftype==='object'){
 switch(type.$$typeof){

packages/shared/isValidElementType.js

@@ -29,6 +29,7 @@ import {
 enableScopeAPI,
 enableCache,
 enableTransitionTracing,
+enableDebugTracing,
 }from'./ReactFeatureFlags';
 
 constREACT_MODULE_REFERENCE: Symbol=Symbol.for('react.module.reference');
@@ -42,7 +43,7 @@ export default function isValidElementType(type: mixed) {
 if(
 type===REACT_FRAGMENT_TYPE||
 type===REACT_PROFILER_TYPE||
-type===REACT_DEBUG_TRACING_MODE_TYPE||
+(enableDebugTracing&&type===REACT_DEBUG_TRACING_MODE_TYPE)||
 type===REACT_STRICT_MODE_TYPE||
 type===REACT_SUSPENSE_TYPE||
 type===REACT_SUSPENSE_LIST_TYPE||