perf(internal): optimize Subscription#add() for the common case (#4489)

This removes unnecessary checks on the `teardown` parameter upfront, and
instead moves these checks into the appropriate branches guarded by the
type check. This way we get the same behavior, but with fewer checks and
smaller code size.
Also optimize adding the child `subscription` to `this._subscriptions`
for the common case that there were no previous subscriptions.

Author: bmeurer

src/internal/Subscription.ts

@@ -143,21 +143,13 @@ export class Subscription implements SubscriptionLike {
  * list.
  */
 add(teardown: TeardownLogic): Subscription{
-if(!teardown||(teardown===Subscription.EMPTY)){
-returnSubscription.EMPTY;
-}
-
-if(teardown===this){
-returnthis;
-}
-
-letsubscription=(<Subscription>teardown);
-
+letsubscription=(<Subscription>teardown);
 switch(typeofteardown){
 case'function':
-subscription=newSubscription(<(()=>void)>teardown);
+subscription=newSubscription(<(()=>void)>teardown);
 case'object':
-if(subscription.closed||typeofsubscription.unsubscribe!=='function'){
+if(subscription===this||subscription.closed||typeofsubscription.unsubscribe!=='function'){
+// This also covers the case where `subscription` is `Subscription.EMPTY`, which is always in `closed` state.
 returnsubscription;
 }elseif(this.closed){
 subscription.unsubscribe();
@@ -168,13 +160,21 @@ export class Subscription implements SubscriptionLike {
 subscription._subscriptions=[tmp];
 }
 break;
-default:
+default: {
+if(!(<any>teardown)){
+returnSubscription.EMPTY;
+}
 thrownewError('unrecognized teardown '+teardown+' added to Subscription.');
+}
 }
 
-constsubscriptions=this._subscriptions||(this._subscriptions=[]);
-
-subscriptions.push(subscription);
+// Optimize for the common case when adding the first subscription.
+constsubscriptions=this._subscriptions;
+if(subscriptions){
+subscriptions.push(subscription);
+}else{
+this._subscriptions=[subscription];
+}
 subscription._addParent(this);
 
 returnsubscription;