Skip to content

Translation hooks-overview page - #65

Merged
another-guy merged 10 commits into
reactjs:masterfrom
sqts:master
Feb 22, 2019
Merged

Translation hooks-overview page#65
another-guy merged 10 commits into
reactjs:masterfrom
sqts:master

Conversation

@sqts

@sqtssqts commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

Вопросы, которые возникли:

  • Где нужно писать хуки с большой буквы? В заголовках, в ссылках, в самом тексте?
  • Reducer -> редьюсер или редуктор?

Еще, во втором коммите я пофиксил баги с анкорами на этой странице. Кстати, в продакшен версии они тоже есть сейчас.

@sqtssqts mentioned this pull request Feb 10, 2019
Closed
88 tasks
rlax
rlax reviewed Feb 10, 2019
View reviewed changes
Comment threadcontent/docs/hooks-overview.md Outdated
@rlax@sqts
Removing double space
2eb2566
Co-Authored-By: Hisagr <sergio.kuts@gmail.com>
@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 10, 2019
@pavelkeyzik

pavelkeyzik commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

Тоже интересовался вопросом про хуки. Только сейчас заметил, что хуки везде с маленькой https://github.com/reactjs/ru.reactjs.org/blob/master/TRANSLATION.md. И так же тут написано, что reducer -> редьюсер

lex111
lex111 reviewed Feb 12, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комментарии для улучшения перевода

Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
angryermine
angryermine reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
@another-guyanother-guy added the work in progress Author opened the pull-request but it's still being worked on label Feb 12, 2019
@another-guyanother-guy mentioned this pull request Feb 14, 2019
Closed
@lex111lex111 removed the work in progress Author opened the pull-request but it's still being worked on label Feb 16, 2019
another-guy
another-guy reviewed Feb 16, 2019
View reviewed changes

@another-guyanother-guy left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ревью готово. Некоторые предложения о грамматике/пунктуации, другие -- о стиле, а последние -- всё вместе.

Большое спасибо за перевод ❗️

Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
Comment threadcontent/docs/hooks-overview.md Outdated
@another-guyanother-guy removed the needs review A pull request ready to be reviewed label Feb 16, 2019
@lex111lex111 added the work in progress Author opened the pull-request but it's still being worked on label Feb 17, 2019
@lex111

lex111 commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

@Hisagr вы можете принять предложенные правки?

@another-guy@sqts
Updated according to@another-guyreview
7cad409
Co-Authored-By: Hisagr <sergio.kuts@gmail.com>
@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs failed.

Built with commit 7cad409

https://app.netlify.com/sites/ru-reactjs/deploys/5c6f32b427e24a0008363ebc

@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs failed.

Built with commit 7cad409

https://app.netlify.com/sites/ru-reactjs/deploys/5c6f32b55c8f85000b99065d

@another-guyanother-guy removed the work in progress Author opened the pull-request but it's still being worked on label Feb 22, 2019
@another-guy
another-guy merged commit ee58002 into reactjs:masterFeb 22, 2019
@another-guyanother-guy added the needs proofread A read-through is still needed to release the document label Feb 22, 2019
@another-guy

another-guy commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

@Hisagr 🥇

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@angryermineangryermineangryermine left review comments
@lex111lex111lex111 left review comments
@rlaxrlaxrlax left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sqts@pavelkeyzik@lex111@another-guy@angryermine@rlax