Skip to content

Improve Fiddle::Pointer#inspect for FFI backend - #179

Merged
kou merged 2 commits into
ruby:masterfrom
ankane:ffi-backend-inspect
Apr 21, 2025
Merged

Improve Fiddle::Pointer#inspect for FFI backend#179
kou merged 2 commits into
ruby:masterfrom
ankane:ffi-backend-inspect

Conversation

@ankane

@ankaneankane commented Apr 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor
pFiddle::Pointer.new(1)

CRuby

#<Fiddle::Pointer:0x0000600000983240 ptr=0x0000000000000001 size=0 free=0x0000000000000000>

JRuby before

#<Fiddle::Pointer ptr=1 size=9223372036854775807 free=nil>

JRuby after

#<Fiddle::Pointer ptr=0x0000000000000001 size=9223372036854775807 free=0x0000000000000000>

Note: size is incorrect for JRuby, which is not addressed with this PR

@ankane
ankaneforce-pushed the ffi-backend-inspect branch from a4257ee to cb7c6caCompareApril 19, 2025 23:30
kou
kou reviewed Apr 20, 2025
View reviewed changes
Comment threadlib/fiddle/ffi_backend.rb Outdated
@kou
kou merged commit 582f443 into ruby:masterApr 21, 2025
@ankane

ankane commented Apr 21, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks @kou

@ankaneankane mentioned this pull request Apr 22, 2025
Merged
kou added a commit that referenced this pull request Apr 22, 2025
@ankane@kou
Make pointer size consistent between backends (#183)
8eab55b
This PR makes the pointer size consistent between backends. Follow up to
#179.
```ruby
require "fiddle"
ptr = Fiddle::Pointer.new(0)
p ptr.size
p ptr.ref.size
ptr = Fiddle::Pointer["hello world"]
ptr.size = 0
p ptr.to_s
p ptr.to_str
```
JRuby + TruffleRuby before
```text
9223372036854775807
8
""
""
```
CRuby + JRuby + TruffleRuby after
```text
0
0
"hello world"
""
```
---------
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankane@kou