Allow seek when underlying string is frozen (#121)

headius · web-flow · commit 3f90fe44c62b · 2025-02-21T09:37:35.000+09:00
Fixes #119. Adds a test for this expectation.
diff --git a/ext/java/org/jruby/ext/stringio/StringIO.java b/ext/java/org/jruby/ext/stringio/StringIO.java
@@ -1356,8 +1356,6 @@ public IRubyObject seek(ThreadContext context, IRubyObject arg0, IRubyObject arg
 }
 
 private RubyFixnum seekCommon(ThreadContext context, int argc, IRubyObject arg0, IRubyObject arg1) {
- checkModifiable();
-
 Ruby runtime = context.runtime;
 
 IRubyObject whence = context.nil;
@@ -1367,10 +1365,10 @@ private RubyFixnum seekCommon(ThreadContext context, int argc, IRubyObject arg0,
 whence = arg1;
 }
 
- checkOpen();
-
 StringIOData ptr = this.getPtr();
 
+ checkOpen();
+
 boolean locked = lock(context, ptr);
 try {
 switch (whence.isNil() ? 0 : RubyNumeric.num2int(whence)) {
diff --git a/test/stringio/test_stringio.rb b/test/stringio/test_stringio.rb
@@ -483,6 +483,11 @@ def test_seek
 f.close unless f.closed?
 end
 
+ def test_seek_frozen_string
+ f = StringIO.new(-"1234")
+ assert_equal(0, f.seek(1))
+ end
+
 def test_each_byte
 f = StringIO.new("1234")
 a = []

-Original file line number
+Diff line change
+ }
 privateRubyFixnumseekCommon(ThreadContextcontext, intargc, IRubyObjectarg0, IRubyObjectarg1) {
 -checkModifiable();
+-
 Rubyruntime = context.runtime;
 IRubyObjectwhence = context.nil;
 whence = arg1;
+ }
 -checkOpen();
+-
 StringIODataptr = this.getPtr();
 +checkOpen();
++
 booleanlocked = lock(context, ptr);
 try {
 switch (whence.isNil() ? 0 : RubyNumeric.num2int(whence)) {
-Original file line number
+Diff line change
 f.closeunlessf.closed?
 end
 +deftest_seek_frozen_string
 +f=StringIO.new(-"1234")
 +assert_equal(0,f.seek(1))
 +end
++
 deftest_each_byte
 f=StringIO.new("1234")
 a=[]