Rollup merge of #118886 - GuillaumeGomez:clean-up-search-vars, r=notriddle

Clean up variables in `search.js`
While reviewing #118402, I saw a few small clean ups that were needed, mostly about variables creation.
r? ```@notriddle```

Author: workingjubilee

src/librustdoc/html/static/js/search.js

@@ -2100,8 +2100,6 @@ function initSearch(rawSearchIndex) {
 }
 
 functioninnerRunQuery(){
-letelem,i,nSearchWords,in_returned,row;
-
 letqueryLen=0;
 for(constelemofparsedQuery.elems){
 queryLen+=elem.name.length;
@@ -2227,8 +2225,8 @@ function initSearch(rawSearchIndex) {
 
 if(parsedQuery.foundElems===1){
 if(parsedQuery.elems.length===1){
-elem=parsedQuery.elems[0];
-for(i=0,nSearchWords=searchWords.length;i<nSearchWords;++i){
+constelem=parsedQuery.elems[0];
+for(leti=0,nSearchWords=searchWords.length;i<nSearchWords;++i){
 // It means we want to check for this element everywhere (in names, args and
 // returned).
 handleSingleArg(
@@ -2243,10 +2241,9 @@ function initSearch(rawSearchIndex) {
 }
 }elseif(parsedQuery.returned.length===1){
 // We received one returned argument to check, so looking into returned values.
-elem=parsedQuery.returned[0];
-for(i=0,nSearchWords=searchWords.length;i<nSearchWords;++i){
-row=searchIndex[i];
-in_returned=row.type&&unifyFunctionTypes(
+for(leti=0,nSearchWords=searchWords.length;i<nSearchWords;++i){
+constrow=searchIndex[i];
+constin_returned=row.type&&unifyFunctionTypes(
 row.type.output,
 parsedQuery.returned,
 row.type.where_clause
@@ -2264,7 +2261,7 @@ function initSearch(rawSearchIndex) {
 }
 }
 }elseif(parsedQuery.foundElems>0){
-for(i=0,nSearchWords=searchWords.length;i<nSearchWords;++i){
+for(leti=0,nSearchWords=searchWords.length;i<nSearchWords;++i){
 handleArgs(searchIndex[i],i,results_others);
 }
 }
@@ -2420,7 +2417,6 @@ function initSearch(rawSearchIndex) {
 constextraClass=display ? " active" : "";
 
 constoutput=document.createElement("div");
-letlength=0;
 if(array.length>0){
 output.className="search-results "+extraClass;
 
@@ -2430,8 +2426,6 @@ function initSearch(rawSearchIndex) {
 constlongType=longItemTypes[item.ty];
 consttypeName=longType.length!==0 ? `${longType}` : "?";
 
-length+=1;
-
 constlink=document.createElement("a");
 link.className="result-"+type;
 link.href=item.href;
@@ -2479,7 +2473,7 @@ ${item.displayPath}<span class="${type}">${name}</span>\
 "href=\"https://docs.rs\">Docs.rs</a> for documentation of crates released on"+
 " <a href=\"https://crates.io/\">crates.io</a>.</li></ul>";
 }
-return[output,length];
+return[output,array.length];
 }
 
 functionmakeTabHeader(tabNb,text,nbElems){