Reduce visibilities, and add warn(unreachable_pub).

Lots of unnecessary `pub`s in this crate. Most are downgraded to
`pub(super)`, though some don't need any visibility.

Author: nnethercote

compiler/rustc_mir_transform/src/abort_unwinding_calls.rs

@@ -20,7 +20,7 @@ use rustc_target::spec::PanicStrategy;
 /// This forces all unwinds, in panic=abort mode happening in foreign code, to
 /// trigger a process abort.
 #[derive(PartialEq)]
-pubstructAbortUnwindingCalls;
+pub(super)structAbortUnwindingCalls;
 
 impl<'tcx>crate::MirPass<'tcx>forAbortUnwindingCalls{
 fnrun_pass(&self,tcx:TyCtxt<'tcx>,body:&mutBody<'tcx>){

compiler/rustc_mir_transform/src/add_call_guards.rs

@@ -4,11 +4,11 @@ use rustc_middle::ty::TyCtxt;
 use tracing::debug;
 
 #[derive(PartialEq)]
-pubenumAddCallGuards{
+pub(super)enumAddCallGuards{
 AllCallEdges,
 CriticalCallEdges,
 }
-pubuseself::AddCallGuards::*;
+pub(super)useself::AddCallGuards::*;
 
 /**
  * Breaks outgoing critical edges for call terminators in the MIR.
@@ -37,7 +37,7 @@ impl<'tcx> crate::MirPass<'tcx> for AddCallGuards {
 }
 
 implAddCallGuards{
-pubfnadd_call_guards(&self,body:&mutBody<'_>){
+pub(super)fnadd_call_guards(&self,body:&mutBody<'_>){
 letmut pred_count:IndexVec<_,_> =
  body.basic_blocks.predecessors().iter().map(|ps| ps.len()).collect();
  pred_count[START_BLOCK] += 1;

compiler/rustc_mir_transform/src/add_moves_for_packed_drops.rs

@@ -35,7 +35,7 @@ use crate::util;
 ///
 /// The storage instructions are required to avoid stack space
 /// blowup.
-pubstructAddMovesForPackedDrops;
+pub(super)structAddMovesForPackedDrops;
 
 impl<'tcx>crate::MirPass<'tcx>forAddMovesForPackedDrops{
 fnrun_pass(&self,tcx:TyCtxt<'tcx>,body:&mutBody<'tcx>){
@@ -44,7 +44,7 @@ impl<'tcx> crate::MirPass<'tcx> for AddMovesForPackedDrops {
 }
 }
 
-pubfnadd_moves_for_packed_drops<'tcx>(tcx:TyCtxt<'tcx>,body:&mutBody<'tcx>){
+fnadd_moves_for_packed_drops<'tcx>(tcx:TyCtxt<'tcx>,body:&mutBody<'tcx>){
 let patch = add_moves_for_packed_drops_patch(tcx, body);
  patch.apply(body);
 }

compiler/rustc_mir_transform/src/add_retag.rs

@@ -8,7 +8,7 @@ use rustc_hir::LangItem;
 use rustc_middle::mir::*;
 use rustc_middle::ty::{self,Ty,TyCtxt};
 
-pubstructAddRetag;
+pub(super)structAddRetag;
 
 /// Determine whether this type may contain a reference (or box), and thus needs retagging.
 /// We will only recurse `depth` times into Tuples/ADTs to bound the cost of this.

compiler/rustc_mir_transform/src/add_subtyping_projections.rs

@@ -4,9 +4,9 @@ use rustc_middle::mir::visit::MutVisitor;
 use rustc_middle::mir::*;
 use rustc_middle::ty::TyCtxt;
 
-pubstructSubtyper;
+pub(super)structSubtyper;
 
-pubstructSubTypeChecker<'a,'tcx>{
+structSubTypeChecker<'a,'tcx>{
 tcx:TyCtxt<'tcx>,
 patcher:MirPatch<'tcx>,
 local_decls:&'aIndexVec<Local,LocalDecl<'tcx>>,
@@ -52,7 +52,7 @@ impl<'a, 'tcx> MutVisitor<'tcx> for SubTypeChecker<'a, 'tcx> {
 // // gets transformed to
 // let temp: rval_ty = rval;
 // let place: place_ty = temp as place_ty;
-pubfnsubtype_finder<'tcx>(tcx:TyCtxt<'tcx>,body:&mutBody<'tcx>){
+fnsubtype_finder<'tcx>(tcx:TyCtxt<'tcx>,body:&mutBody<'tcx>){
 let patch = MirPatch::new(body);
 letmut checker = SubTypeChecker{ tcx,patcher: patch,local_decls:&body.local_decls};
 

compiler/rustc_mir_transform/src/check_alignment.rs

@@ -7,7 +7,7 @@ use rustc_middle::ty::{self, ParamEnv, Ty, TyCtxt};
 use rustc_session::Session;
 use tracing::{debug, trace};
 
-pubstructCheckAlignment;
+pub(super)structCheckAlignment;
 
 impl<'tcx>crate::MirPass<'tcx>forCheckAlignment{
 fnis_enabled(&self,sess:&Session) -> bool{

compiler/rustc_mir_transform/src/check_const_item_mutation.rs

@@ -8,7 +8,7 @@ use rustc_span::Span;
 
 usecrate::errors;
 
-pubstructCheckConstItemMutation;
+pub(super)structCheckConstItemMutation;
 
 impl<'tcx>crate::MirLint<'tcx>forCheckConstItemMutation{
 fnrun_lint(&self,tcx:TyCtxt<'tcx>,body:&Body<'tcx>){

compiler/rustc_mir_transform/src/check_packed_ref.rs

@@ -5,7 +5,7 @@ use rustc_middle::ty::{self, TyCtxt};
 
 usecrate::{errors, util};
 
-pubstructCheckPackedRef;
+pub(super)structCheckPackedRef;
 
 impl<'tcx>crate::MirLint<'tcx>forCheckPackedRef{
 fnrun_lint(&self,tcx:TyCtxt<'tcx>,body:&Body<'tcx>){

compiler/rustc_mir_transform/src/cleanup_post_borrowck.rs

@@ -21,7 +21,7 @@ use rustc_middle::mir::{Body, BorrowKind, CastKind, Rvalue, StatementKind, Termi
 use rustc_middle::ty::adjustment::PointerCoercion;
 use rustc_middle::ty::TyCtxt;
 
-pubstructCleanupPostBorrowck;
+pub(super)structCleanupPostBorrowck;
 
 impl<'tcx>crate::MirPass<'tcx>forCleanupPostBorrowck{
 fnrun_pass(&self,_tcx:TyCtxt<'tcx>,body:&mutBody<'tcx>){

compiler/rustc_mir_transform/src/copy_prop.rs

@@ -17,7 +17,7 @@ use crate::ssa::SsaLocals;
 /// where each of the locals is only assigned once.
 ///
 /// We want to replace all those locals by `_a`, either copied or moved.
-pubstructCopyProp;
+pub(super)structCopyProp;
 
 impl<'tcx>crate::MirPass<'tcx>forCopyProp{
 fnis_enabled(&self,sess:&rustc_session::Session) -> bool{