tidy: add tidy check agains \.rs files inside tests/crashes that are missing "//@ known-bug: "

Author: matthiaskrgr

src/tools/compiletest/src/runtest.rs

@@ -354,7 +354,7 @@ impl<'test> TestCx<'test> {
 ifself.props.should_ice{
 match proc_res.status.code(){
 Some(101) => (),
- _ => self.fatal("expected ICE"),
+ _ => self.fatal("test no longer crashes/triggers ICE! Please annotate it and add it as test to tests/ui or wherever you see fit"),
 }
 }
 

src/tools/tidy/src/known_bug.rs

@@ -0,0 +1,17 @@
+//! Tidy check to ensure that tests inside 'tests/crashes' have a '@known-bug' directive.
+
+usecrate::walk::*;
+use std::path::Path;
+
+pubfncheck(filepath:&Path,bad:&mutbool){
+walk(filepath, |path, _is_dir| filter_not_rust(path),&mut |entry, contents| {
+let file = entry.path();
+if !contents.lines().any(|line| line.starts_with("//@ known-bug: ")){
+tidy_error!(
+ bad,
+"{} crash/ice test does not have a \"//@ known-bug: \" directive",
+ file.display()
+);
+}
+});
+}

src/tools/tidy/src/lib.rs

@@ -67,6 +67,7 @@ pub mod features;
 pubmod fluent_alphabetical;
 mod fluent_used;
 pub(crate)mod iter_header;
+pubmod known_bug;
 pubmod mir_opt_tests;
 pubmod pal;
 pubmod run_make_tests;

src/tools/tidy/src/main.rs

@@ -35,6 +35,7 @@ fn main() {
 let library_path = root_path.join("library");
 let compiler_path = root_path.join("compiler");
 let librustdoc_path = src_path.join("librustdoc");
+let crashes_path = tests_path.join("crashes");
 
 let args:Vec<String> = env::args().skip(1).collect();
 let(cfg_args, pos_args) = match args.iter().position(|arg| arg == "--"){
@@ -108,6 +109,7 @@ fn main() {
 check!(mir_opt_tests,&tests_path, bless);
 check!(rustdoc_gui_tests,&tests_path);
 check!(rustdoc_css_themes,&librustdoc_path);
+check!(known_bug,&crashes_path);
 
 // Checks that only make sense for the compiler.
 check!(error_codes,&root_path,&[&compiler_path,&librustdoc_path], verbose);