Rollup merge of #129981 - nnethercote:rm-serialize_bitcode, r=antoyo,tmiasko

Remove `serialized_bitcode` from `LtoModuleCodegen`.
It's unused.
r? ``@bjorn3``

Author: workingjubilee

compiler/rustc_codegen_gcc/src/back/lto.rs

@@ -272,7 +272,6 @@ fn fat_lto(
  }*/
 }
 };
-letmut serialized_bitcode = Vec::new();
 {
 info!("using {:?} as a base module", module.name);
 
@@ -317,7 +316,6 @@ fn fat_lto(
 unimplemented!("from uncompressed file")
 }
 }
- serialized_bitcode.push(bc_decoded);
 }
 save_temp_bitcode(cgcx,&module,"lto.input");
 
@@ -337,7 +335,7 @@ fn fat_lto(
 // of now.
  module.module_llvm.temp_dir = Some(tmp_path);
 
-Ok(LtoModuleCodegen::Fat{module,_serialized_bitcode: serialized_bitcode })
+Ok(LtoModuleCodegen::Fat(module))
 }
 
 pubstructModuleBuffer(PathBuf);

compiler/rustc_codegen_llvm/src/back/lto.rs

@@ -314,7 +314,6 @@ fn fat_lto(
 }
 }
 };
-letmut serialized_bitcode = Vec::new();
 {
 let(llcx, llmod) = {
 let llvm = &module.module_llvm;
@@ -342,9 +341,7 @@ fn fat_lto(
  serialized_modules.sort_by(|module1, module2| module1.1.cmp(&module2.1));
 
 // For all serialized bitcode files we parse them and link them in as we did
-// above, this is all mostly handled in C++. Like above, though, we don't
-// know much about the memory management here so we err on the side of being
-// save and persist everything with the original module.
+// above, this is all mostly handled in C++.
 letmut linker = Linker::new(llmod);
 for(bc_decoded, name)in serialized_modules {
 let _timer = cgcx
@@ -355,7 +352,6 @@ fn fat_lto(
 info!("linking {:?}", name);
 let data = bc_decoded.data();
  linker.add(data).map_err(|()| write::llvm_err(dcx,LlvmError::LoadBitcode{ name }))?;
- serialized_bitcode.push(bc_decoded);
 }
 drop(linker);
 save_temp_bitcode(cgcx,&module,"lto.input");
@@ -372,7 +368,7 @@ fn fat_lto(
 }
 }
 
-Ok(LtoModuleCodegen::Fat{module,_serialized_bitcode: serialized_bitcode })
+Ok(LtoModuleCodegen::Fat(module))
 }
 
 pub(crate)structLinker<'a>(&'amut llvm::Linker<'a>);

compiler/rustc_codegen_ssa/src/back/lto.rs

@@ -41,18 +41,14 @@ pub struct ThinShared<B: WriteBackendMethods> {
 }
 
 pubenumLtoModuleCodegen<B:WriteBackendMethods>{
-Fat{
-module:ModuleCodegen<B::Module>,
-_serialized_bitcode:Vec<SerializedModule<B::ModuleBuffer>>,
-},
-
+Fat(ModuleCodegen<B::Module>),
 Thin(ThinModule<B>),
 }
 
 impl<B:WriteBackendMethods>LtoModuleCodegen<B>{
 pubfnname(&self) -> &str{
 match*self{
-LtoModuleCodegen::Fat{ .. } => "everything",
+LtoModuleCodegen::Fat(_) => "everything",
 LtoModuleCodegen::Thin(ref m) => m.name(),
 }
 }
@@ -68,7 +64,7 @@ impl<B: WriteBackendMethods> LtoModuleCodegen<B> {
 cgcx:&CodegenContext<B>,
 ) -> Result<ModuleCodegen<B::Module>,FatalError>{
 matchself{
-LtoModuleCodegen::Fat{mut module, .. } => {
+LtoModuleCodegen::Fat(mut module) => {
 B::optimize_fat(cgcx,&mut module)?;
 Ok(module)
 }
@@ -81,7 +77,7 @@ impl<B: WriteBackendMethods> LtoModuleCodegen<B> {
 pubfncost(&self) -> u64{
 match*self{
 // Only one module with fat LTO, so the cost doesn't matter.
-LtoModuleCodegen::Fat{ .. } => 0,
+LtoModuleCodegen::Fat(_) => 0,
 LtoModuleCodegen::Thin(ref m) => m.cost(),
 }
 }