Dogfood double_ended_iterator_last

Author: qsantos

clippy_lints/src/attrs/mixed_attributes_style.rs

@@ -66,7 +66,7 @@ pub(super) fn check(cx: &EarlyContext<'_>, item_span: Span, attrs: &[Attribute])
 
 fnlint_mixed_attrs(cx:&EarlyContext<'_>,attrs:&[Attribute]){
 letmut attrs_iter = attrs.iter().filter(|attr| !attr.span.from_expansion());
-let span = iflet(Some(first),Some(last)) = (attrs_iter.next(), attrs_iter.last()){
+let span = iflet(Some(first),Some(last)) = (attrs_iter.next(), attrs_iter.next_back()){
  first.span.with_hi(last.span.hi())
 }else{
 return;

clippy_lints/src/methods/double_ended_iterator_last.rs

@@ -24,7 +24,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &'_ Expr<'_>, self_expr: &'_ Exp
  && letOk(Some(fn_def)) = Instance::try_resolve(cx.tcx, cx.typing_env(), id, args)
 // find the provided definition of Iterator::last
  && letSome(item) = cx.tcx.get_diagnostic_item(sym::Iterator)
- && letSome(last_def) = cx.tcx.provided_trait_methods(item).find(|m| m.name == sym!(last))
+ && letSome(last_def) = cx.tcx.provided_trait_methods(item).find(|m| m.name.as_str() == "last")
 // if the resolved method is the same as the provided definition
  && fn_def.def_id() == last_def.def_id
 {

clippy_utils/src/msrvs.rs

@@ -130,7 +130,7 @@ impl Msrv {
 letmut msrv_attrs = attrs.iter().filter(|attr| attr.path_matches(&[sym::clippy, sym_msrv]));
 
 ifletSome(msrv_attr) = msrv_attrs.next(){
-ifletSome(duplicate) = msrv_attrs.last(){
+ifletSome(duplicate) = msrv_attrs.next_back(){
  sess.dcx()
 .struct_span_err(duplicate.span(),"`clippy::msrv` is defined multiple times")
 .with_span_note(msrv_attr.span(),"first definition found here")