Apply fixes from lint

Author: GnomedDev

clippy_lints/src/casts/cast_ptr_alignment.rs

@@ -20,7 +20,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>) {
 );
 lint_cast_ptr_alignment(cx, expr, cast_from, cast_to);
 }elseifletExprKind::MethodCall(method_path, self_arg,[], _) = &expr.kind{
-if method_path.ident.name == sym!(cast)
+if method_path.ident.name.as_str() == "cast"
  && letSome(generic_args) = method_path.args
  && let[GenericArg::Type(cast_to)] = generic_args.args
 // There probably is no obvious reason to do this, just to be consistent with `as` cases.

clippy_lints/src/explicit_write.rs

@@ -58,7 +58,7 @@ impl<'tcx> LateLintPass<'tcx> for ExplicitWrite {
 // match call to write_fmt
  && letExprKind::MethodCall(write_fun, write_recv,[write_arg], _) = *look_in_block(cx,&write_call.kind)
  && letExprKind::Call(write_recv_path,[]) = write_recv.kind
- && write_fun.ident.name == sym!(write_fmt)
+ && write_fun.ident.name.as_str() == "write_fmt"
  && letSome(def_id) = path_def_id(cx, write_recv_path)
 {
 // match calls to std::io::stdout() / std::io::stderr ()

clippy_lints/src/from_raw_with_void_ptr.rs

@@ -41,7 +41,7 @@ impl LateLintPass<'_> for FromRawWithVoidPtr {
 fncheck_expr(&mutself,cx:&LateContext<'_>,expr:&Expr<'_>){
 ifletExprKind::Call(box_from_raw,[arg]) = expr.kind
  && letExprKind::Path(QPath::TypeRelative(ty, seg)) = box_from_raw.kind
- && seg.ident.name == sym!(from_raw)
+ && seg.ident.name.as_str() == "from_raw"
  && letSome(type_str) = path_def_id(cx, ty).and_then(|id| def_id_matches_type(cx, id))
  && let arg_kind = cx.typeck_results().expr_ty(arg).kind()
  && let ty::RawPtr(ty, _) = arg_kind

clippy_lints/src/implicit_hasher.rs

@@ -340,7 +340,7 @@ impl<'tcx> Visitor<'tcx> for ImplicitHasherConstructorVisitor<'_, '_, 'tcx> {
 ifself.cx.tcx.is_diagnostic_item(sym::HashMap, ty_did){
 if method.ident.name == sym::new {
 self.suggestions.insert(e.span,"HashMap::default()".to_string());
-}elseif method.ident.name == sym!(with_capacity){
+}elseif method.ident.name.as_str() == "with_capacity"{
 self.suggestions.insert(
  e.span,
 format!(
@@ -352,7 +352,7 @@ impl<'tcx> Visitor<'tcx> for ImplicitHasherConstructorVisitor<'_, '_, 'tcx> {
 }elseifself.cx.tcx.is_diagnostic_item(sym::HashSet, ty_did){
 if method.ident.name == sym::new {
 self.suggestions.insert(e.span,"HashSet::default()".to_string());
-}elseif method.ident.name == sym!(with_capacity){
+}elseif method.ident.name.as_str() == "with_capacity"{
 self.suggestions.insert(
  e.span,
 format!(

clippy_lints/src/infinite_iter.rs

@@ -157,7 +157,7 @@ fn is_infinite(cx: &LateContext<'_>, expr: &Expr<'_>) -> Finiteness {
 .and(cap);
 }
 }
-if method.ident.name == sym!(flat_map) && args.len() == 1{
+if method.ident.name.as_str() == "flat_map" && args.len() == 1{
 ifletExprKind::Closure(&Closure{ body, .. }) = args[0].kind{
 let body = cx.tcx.hir().body(body);
 returnis_infinite(cx, body.value);
@@ -224,7 +224,7 @@ fn complete_infinite_iter(cx: &LateContext<'_>, expr: &Expr<'_>) -> Finiteness {
 returnMaybeInfinite.and(is_infinite(cx, receiver));
 }
 }
-if method.ident.name == sym!(last) && args.is_empty(){
+if method.ident.name.as_str() == "last" && args.is_empty(){
 let not_double_ended = cx
 .tcx
 .get_diagnostic_item(sym::DoubleEndedIterator)
@@ -234,7 +234,7 @@ fn complete_infinite_iter(cx: &LateContext<'_>, expr: &Expr<'_>) -> Finiteness {
 if not_double_ended {
 returnis_infinite(cx, receiver);
 }
-}elseif method.ident.name == sym!(collect){
+}elseif method.ident.name.as_str() == "collect"{
 let ty = cx.typeck_results().expr_ty(expr);
 ifmatches!(
  get_type_diagnostic_name(cx, ty),

clippy_lints/src/iter_without_into_iter.rs

@@ -142,7 +142,7 @@ impl LateLintPass<'_> for IterWithoutIntoIter {
  ty.peel_refs().is_slice() || get_adt_inherent_method(cx, ty, expected_method_name).is_some()
 })
  && letSome(iter_assoc_span) = imp.items.iter().find_map(|item| {
-if item.ident.name == sym!(IntoIter){
+if item.ident.name.as_str() == "IntoIter"{
 Some(cx.tcx.hir().impl_item(item.id).expect_type().span)
 }else{
 None

clippy_lints/src/manual_hash_one.rs

@@ -68,7 +68,7 @@ impl LateLintPass<'_> for ManualHashOne {
  && letSome(init) = local.init
  && !init.span.from_expansion()
  && letExprKind::MethodCall(seg, build_hasher,[], _) = init.kind
- && seg.ident.name == sym!(build_hasher)
+ && seg.ident.name.as_str() == "build_hasher"
 
  && letNode::Stmt(local_stmt) = cx.tcx.parent_hir_node(local.hir_id)
  && letNode::Block(block) = cx.tcx.parent_hir_node(local_stmt.hir_id)
@@ -96,7 +96,7 @@ impl LateLintPass<'_> for ManualHashOne {
  && letNode::Expr(finish_expr) = cx.tcx.parent_hir_node(path_expr.hir_id)
  && !finish_expr.span.from_expansion()
  && letExprKind::MethodCall(seg, _,[], _) = finish_expr.kind
- && seg.ident.name == sym!(finish)
+ && seg.ident.name.as_str() == "finish"
 
  && self.msrv.meets(msrvs::BUILD_HASHER_HASH_ONE)
 {

clippy_lints/src/manual_is_ascii_check.rs

@@ -105,7 +105,7 @@ impl<'tcx> LateLintPass<'tcx> for ManualIsAsciiCheck {
 check_is_ascii(cx, macro_call.span, recv,&range,None);
 }
 }elseifletExprKind::MethodCall(path, receiver,[arg], ..) = expr.kind
- && path.ident.name == sym!(contains)
+ && path.ident.name.as_str() == "contains"
  && letSome(higher::Range{
 start:Some(start),
 end:Some(end),

clippy_lints/src/matches/redundant_guards.rs

@@ -10,7 +10,7 @@ use rustc_hir::def::{DefKind, Res};
 use rustc_hir::{Arm,BinOpKind,Expr,ExprKind,MatchSource,Node,PatKind,UnOp};
 use rustc_lint::LateContext;
 use rustc_span::symbol::Ident;
-use rustc_span::{Span,Symbol,sym};
+use rustc_span::{Span, sym};
 use std::borrow::Cow;
 use std::ops::ControlFlow;
 
@@ -95,15 +95,15 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, arms: &'tcx [Arm<'tcx>], msrv:
 }elseifletExprKind::MethodCall(path, recv, args, ..) = guard.kind
  && letSome(binding) = get_pat_binding(cx, recv, outer_arm)
 {
-check_method_calls(cx, outer_arm, path.ident.name, recv, args, guard,&binding);
+check_method_calls(cx, outer_arm, path.ident.name.as_str(), recv, args, guard,&binding);
 }
 }
 }
 
 fncheck_method_calls<'tcx>(
 cx:&LateContext<'tcx>,
 arm:&Arm<'tcx>,
-method:Symbol,
+method:&str,
 recv:&Expr<'_>,
 args:&[Expr<'_>],
 if_expr:&Expr<'_>,
@@ -112,7 +112,7 @@ fn check_method_calls<'tcx>(
 let ty = cx.typeck_results().expr_ty(recv).peel_refs();
 let slice_like = ty.is_slice() || ty.is_array();
 
-let sugg = if method == sym!(is_empty){
+let sugg = if method == "is_empty"{
 // `s if s.is_empty()` becomes ""
 // `arr if arr.is_empty()` becomes []
 
@@ -137,9 +137,9 @@ fn check_method_calls<'tcx>(
 
 if needles.is_empty(){
  sugg.insert_str(1,"..");
-}elseif method == sym!(starts_with){
+}elseif method == "starts_with"{
  sugg.insert_str(sugg.len() - 1,", ..");
-}elseif method == sym!(ends_with){
+}elseif method == "ends_with"{
  sugg.insert_str(1,".., ");
 }else{
 return;

clippy_lints/src/methods/filter_map.rs

@@ -234,12 +234,12 @@ impl<'tcx> OffendingFilterExpr<'tcx> {
 // the latter only calls `effect` once
 let side_effect_expr_span = receiver.can_have_side_effects().then_some(receiver.span);
 
-if cx.tcx.is_diagnostic_item(sym::Option, recv_ty.did()) && path.ident.name == sym!(is_some){
+if cx.tcx.is_diagnostic_item(sym::Option, recv_ty.did()) && path.ident.name.as_str() == "is_some"{
 Some(Self::IsSome{
  receiver,
  side_effect_expr_span,
 })
-}elseif cx.tcx.is_diagnostic_item(sym::Result, recv_ty.did()) && path.ident.name == sym!(is_ok){
+}elseif cx.tcx.is_diagnostic_item(sym::Result, recv_ty.did()) && path.ident.name.as_str() == "is_ok"{
 Some(Self::IsOk{
  receiver,
  side_effect_expr_span,