Rename image property of CI jobs to name

The `image` part didn't really make sense, especially since we started splitting CI jobs.

Author: Kobzol

src/ci/github-actions/ci.py

@@ -27,13 +27,18 @@
 Job=Dict[str, Any]
 
 
-defname_jobs(jobs: List[Dict], prefix: str) ->List[Job]:
+defadd_job_properties(jobs: List[Dict], prefix: str) ->List[Job]:
 """
- Add a `name` attribute to each job, based on its image and the given `prefix`.
+ Modify the `name` attribute of each job, based on its base name and the given `prefix`.
+ Add an `image` attribute to each job, base don its image.
  """
+modified_jobs= []
 forjobinjobs:
-job["name"] =f"{prefix} - {job['image']}"
-returnjobs
+job=dict(job)
+job["image"] =get_job_image(job)
+job["name"] =f"{prefix} - {job['name']}"
+modified_jobs.append(job)
+returnmodified_jobs
 
 
 defadd_base_env(jobs: List[Job], environment: Dict[str, str]) ->List[Job]:
@@ -118,7 +123,7 @@ def find_run_type(ctx: GitHubCtx) -> Optional[WorkflowRunType]:
 
 defcalculate_jobs(run_type: WorkflowRunType, job_data: Dict[str, Any]) ->List[Job]:
 ifisinstance(run_type, PRRunType):
-returnadd_base_env(name_jobs(job_data["pr"], "PR"), job_data["envs"]["pr"])
+returnadd_base_env(add_job_properties(job_data["pr"], "PR"), job_data["envs"]["pr"])
 elifisinstance(run_type, TryRunType):
 jobs=job_data["try"]
 custom_jobs=run_type.custom_jobs
@@ -132,7 +137,7 @@ def calculate_jobs(run_type: WorkflowRunType, job_data: Dict[str, Any]) -> List[
 jobs= []
 unknown_jobs= []
 forcustom_jobincustom_jobs:
-job= [jforjinjob_data["auto"] ifj["image"] ==custom_job]
+job= [jforjinjob_data["auto"] ifj["name"] ==custom_job]
 ifnotjob:
 unknown_jobs.append(custom_job)
 continue
@@ -142,10 +147,10 @@ def calculate_jobs(run_type: WorkflowRunType, job_data: Dict[str, Any]) -> List[
 f"Custom job(s) `{unknown_jobs}` not found in auto jobs"
  )
 
-returnadd_base_env(name_jobs(jobs, "try"), job_data["envs"]["try"])
+returnadd_base_env(add_job_properties(jobs, "try"), job_data["envs"]["try"])
 elifisinstance(run_type, AutoRunType):
 returnadd_base_env(
-name_jobs(job_data["auto"], "auto"), job_data["envs"]["auto"]
+add_job_properties(job_data["auto"], "auto"), job_data["envs"]["auto"]
  )
 
 return []
@@ -183,27 +188,34 @@ def format_run_type(run_type: WorkflowRunType) -> str:
 raiseAssertionError()
 
 
+defget_job_image(job) ->str:
+"""
+ By default, the Docker image of a job is based on its name.
+ However, it can be overridden by its IMAGE environment variable.
+ """
+returnjob.get("env", {}).get("IMAGE", job["name"])
+
+
 defrun_workflow_locally(job_data: Dict[str, Any], job_name: str):
 DOCKER_DIR=Path(__file__).absolute().parent.parent/"docker"
 
 jobs=list(job_data["auto"])
 jobs.extend(job_data["pr"])
 
-jobs= [jobforjobinjobsifjob.get("image") ==job_name]
+jobs= [jobforjobinjobsifjob.get("name") ==job_name]
 iflen(jobs) ==0:
 raiseException(f"Job `{job_name}` not found")
 job=jobs[0]
 if"ubuntu"notinjob["os"]:
 raiseException("Only Linux jobs can be executed locally")
 
-image=job.get("env", {}).get("IMAGE", job["image"])
 custom_env= {}
 custom_env["DEPLOY"] ="1"
 custom_env.update({k: str(v) for (k, v) injob.get("env", {}).items()})
 
 args= [
 str(DOCKER_DIR/"run.sh"),
-image
+get_job_image(job)
  ]
 env_formatted= [f"{k}={v}"for (k, v) insorted(custom_env.items())]
 print(f"Executing `{' '.join(env_formatted)}{' '.join(args)}`")