Rollup merge of #132569 - lolbinarycat:rustdoc-search-path-end-empty-v2, r=notriddle

rustdoc search: allow queries to end in an empty path segment
fixes#129707
this can be used to show all items in a module,
or all associated items for a type.
currently sufferes slightly due to case insensitivity, so `Option::` will also show items in the `option::` module.
it disables the checking of the last path element, otherwise only items with short names will be shown
r? `@notriddle`

Author: matthiaskrgr

src/librustdoc/html/static/js/search.js

@@ -692,8 +692,6 @@ function createQueryElement(query, parserState, name, generics, isInGenerics) {
 constquadcolon=/::\s*::/.exec(path);
 if(path.startsWith("::")){
 throw["Paths cannot start with ","::"];
-}elseif(path.endsWith("::")){
-throw["Paths cannot end with ","::"];
 }elseif(quadcolon!==null){
 throw["Unexpected ",quadcolon[0]];
 }
@@ -3974,18 +3972,19 @@ class DocSearch {
 
 if(parsedQuery.foundElems===1&&!parsedQuery.hasReturnArrow){
 constelem=parsedQuery.elems[0];
-for(constidofthis.nameTrie.search(elem.normalizedPathLast,this.tailTable)){
+// use arrow functions to preserve `this`.
+consthandleNameSearch=id=>{
 constrow=this.searchIndex[id];
 if(!typePassesFilter(elem.typeFilter,row.ty)||
 (filterCrates!==null&&row.crate!==filterCrates)){
-continue;
+return;
 }
 
 letpathDist=0;
 if(elem.fullPath.length>1){
 pathDist=checkPath(elem.pathWithoutLast,row);
 if(pathDist===null){
-continue;
+return;
 }
 }
 
@@ -4008,9 +4007,20 @@ class DocSearch {
 maxEditDistance,
 );
 }
+};
+if(elem.normalizedPathLast!==""){
+constlast=elem.normalizedPathLast;
+for(constidofthis.nameTrie.search(last,this.tailTable)){
+handleNameSearch(id);
+}
 }
 constlength=this.searchIndex.length;
+
 for(leti=0,nSearchIndex=length;i<nSearchIndex;++i){
+// queries that end in :: bypass the trie
+if(elem.normalizedPathLast===""){
+handleNameSearch(i);
+}
 constrow=this.searchIndex[i];
 if(filterCrates!==null&&row.crate!==filterCrates){
 continue;

tests/rustdoc-js-std/parser-errors.js

@@ -143,14 +143,6 @@ const PARSED = [
 returned: [],
 error: "Unexpected `:: ::`",
 },
-{
-query: "a::b::",
-elems: [],
-foundElems: 0,
-userQuery: "a::b::",
-returned: [],
-error: "Paths cannot end with `::`",
-},
 {
 query: ":a",
 elems: [],

tests/rustdoc-js-std/path-end-empty.js

@@ -0,0 +1,6 @@
+constEXPECTED={
+'query': 'Option::',
+'others': [
+{'path': 'std::option::Option','name': 'get_or_insert_default'},
+],
+}