Skip to content

fix(oracle): validate input with TO_TIMESTAMP_TZ and TO_DATE - #17516

Merged
WikiRik merged 5 commits into
v6from
WikiRik/oracle-workaround
Oct 2, 2024
Merged

fix(oracle): validate input with TO_TIMESTAMP_TZ and TO_DATE#17516
WikiRik merged 5 commits into
v6from
WikiRik/oracle-workaround

Conversation

@WikiRik

@WikiRikWikiRik commented Sep 29, 2024

Copy link
Copy Markdown
Member

Description of Changes

This adds input validation as a workaround to prevent SQL injection using TO_TIMESTAMP or TO_DATE. It's not pretty, but it should do the trick while we fix it properly in v7 where the internals should be more suitable. This fix is the least intrusive.

sdepold
sdepold reviewed Sep 30, 2024
View reviewed changes
Comment threadsrc/sql-string.js
Comment threadsrc/sql-string.js Outdated
Comment threadsrc/sql-string.js Outdated
Comment threadsrc/sql-string.js Outdated
@WikiRik
WikiRik requested a review from sdepoldOctober 1, 2024 06:59
@WikiRik
WikiRik merged commit 5deadd2 into v6Oct 2, 2024
@WikiRik
WikiRik deleted the WikiRik/oracle-workaround branch October 2, 2024 12:01
@github-actions

github-actionsBot commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.37.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Oct 27, 2024
Merged
Merged
@TheLastArchiveTheLastArchive mentioned this pull request Oct 28, 2024
Open
@GLOBAL-FINTECHGLOBAL-FINTECH mentioned this pull request Oct 28, 2024
Open
@sayasmitosayasmito mentioned this pull request Oct 28, 2024
Open
@denizd1denizd1 mentioned this pull request Oct 29, 2024
Open
@brilianaringgabrilianaringga mentioned this pull request Oct 30, 2024
Open
@20kaushik0220kaushik02 mentioned this pull request Oct 30, 2024
Merged
@CpanoCpano mentioned this pull request Oct 30, 2024
Open
@BodhithaWBodhithaW mentioned this pull request Oct 30, 2024
Open
@Dmitry-WhiteDmitry-White mentioned this pull request Oct 30, 2024
Open
@evelynedsevelyneds mentioned this pull request Oct 30, 2024
Open
@GustavoEGPerezGustavoEGPerez mentioned this pull request Oct 30, 2024
Open
@AlexJLPAlexJLP mentioned this pull request Oct 30, 2024
Open
@LohenlLohenl mentioned this pull request Oct 31, 2024
Merged
@kaifkh20kaifkh20 mentioned this pull request Nov 1, 2024
Open
@AntonUrbAntonUrb mentioned this pull request Nov 1, 2024
Open
@adikurniawanidadikurniawanid mentioned this pull request Nov 1, 2024
Merged
@TheLastArchiveTheLastArchive mentioned this pull request Nov 4, 2024
Open
@num8ernum8er mentioned this pull request Nov 4, 2024
Open
@MoJassorMoJassor mentioned this pull request Nov 5, 2024
Open
@GustavoEGPerezGustavoEGPerez mentioned this pull request Nov 6, 2024
Open
@snykshanesnykshane mentioned this pull request Nov 7, 2024
Open
@oMaestro174oMaestro174 mentioned this pull request Nov 9, 2024
Open
@TheLastArchiveTheLastArchive mentioned this pull request Nov 11, 2024
Open
@ArijKoukiArijKouki mentioned this pull request Nov 11, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdepoldsdepoldsdepold approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WikiRik@sdepold