fix(tests): clean NUnit 3->4 conversion from release/9.3 baseline

Re-checkout all 261 test files from origin/release/9.3 and run
scripts/tests/convert_nunit.py with corrected comparison logic.
This fixes swapped argument order in Greater/Less assertions that
were introduced during the SDK migration rebase (43d1fd5).
The previous conversion incorrectly produced:
Assert.That(0, Is.GreaterThan(value)) // WRONG - always false
Now correctly produces:
Assert.That(value, Is.GreaterThan(0)) // CORRECT
Also restores 3 test files that were unintentionally deleted during
the SDK migration:
- Lib/src/ScrChecks/ScrChecksTests/SentenceFinalPunctCapitalizationCheckUnitTest.cs
- Src/Common/ViewsInterfaces/ViewsInterfacesTests/ExtraComInterfacesTests.cs
- Src/FwCoreDlgs/FwCoreDlgsTests/FwWritingSystemSetupDlgTests.cs

Author: johnml1135

Lib/src/ScrChecks/ScrChecksTests/ChapterVerseTests.cs

@@ -4,10 +4,10 @@
 
 usingSystem;
 usingSystem.Collections.Generic;
-usingSystem.Diagnostics;
 usingNUnit.Framework;
-usingSIL.FieldWorks.Common.FwUtils;
+usingSystem.Diagnostics;
 usingSILUBS.ScriptureChecks;
+usingSILUBS.SharedScrUtils;
 
 namespaceSILUBS.ScriptureChecks
 {
@@ -18,7 +18,9 @@ public class RepeatedWordsCheckUnitTest
 UnitTestChecksDataSourcesource=newUnitTestChecksDataSource();
 
 [SetUp]
-publicvoidRunBeforeEachTest(){}
+publicvoidRunBeforeEachTest()
+{
+}
 
 voidTest(string[]result,stringtext)
 {
@@ -30,20 +32,13 @@ void Test(string[] result, string text, string desiredKey)
 source.Text=text;
 
 RepeatedWordsCheckcheck=newRepeatedWordsCheck(source);
-List<TextTokenSubstring>tts=check.GetReferences(source.TextTokens(),desiredKey);
+List<TextTokenSubstring>tts=
+check.GetReferences(source.TextTokens(),desiredKey);
 
-Assert.That(
-tts.Count,
-Is.EqualTo(result.GetUpperBound(0)+1),
-"A different number of results was returned than what was expected."
-);
+Assert.That(tts.Count,Is.EqualTo(result.GetUpperBound(0)+1),"A different number of results was returned than what was expected.");
 
 for(inti=0;i<=result.GetUpperBound(0);++i)
-Assert.That(
-tts[i].InventoryText,
-Is.EqualTo(result[i]),
-"Result number: "+i.ToString()
-);
+Assert.That(tts[i].InventoryText,Is.EqualTo(result[i]),"Result number: "+i.ToString());
 }
 
 [Test]
@@ -68,21 +63,16 @@ public void DifferentCase()
 [Ignore("Text needs to be normalized to NFC (or maybe NFD) before check is run.")]
 publicvoidDifferentNormalization()
 {
-Test(
-newstring[]{"B\u00E3r","B\u00E3r"},
-"\\p \\v 1 B\u00E3r Ba\u0303r and Ba\u0303r B\u00E3r "
-);
+Test(newstring[]{"B\u00E3r","B\u00E3r"},
+"\\p \\v 1 B\u00E3r Ba\u0303r and Ba\u0303r B\u00E3r ");
 }
 
 [Test]
 [Ignore("Text needs to be normalized to NFC (or maybe NFD) before check is run.")]
 publicvoidFindingDifferentNormalization()
 {
-Test(
-newstring[]{"B\u00E3r","B\u00E3r"},
-"\\p \\v 1 B\u00E3r Ba\u0303r and and Ba\u0303r B\u00E3r ",
-"B\u00E3r"
-);
+Test(newstring[]{"B\u00E3r","B\u00E3r"},
+"\\p \\v 1 B\u00E3r Ba\u0303r and and Ba\u0303r B\u00E3r ","B\u00E3r");
 }
 
 [Test]

Lib/src/ScrChecks/ScrChecksTests/RepeatedWordsCheckUnitTest.cs

@@ -0,0 +1,127 @@
+// Copyright (c) 2015 SIL International
+// This software is licensed under the LGPL, version 2.1 or later
+// (http://www.gnu.org/licenses/lgpl-2.1.html)
+
+usingSystem;
+usingSystem.Collections.Generic;
+usingSystem.Text;
+usingNUnit.Framework;
+usingSystem.Diagnostics;
+usingSystem.IO;
+usingSILUBS.SharedScrUtils;
+
+namespaceSILUBS.ScriptureChecks
+{
+#if DEBUG
+[TestFixture]
+publicclassSentenceFinalPunctCapitalizationCheckUnitTest
+{
+UnitTestChecksDataSourcesource=newUnitTestChecksDataSource();
+
+[SetUp]
+publicvoidRunBeforeEachTest()
+{
+source.SetParameterValue("ValidPunctuation","._ !_ ?_");
+}
+
+voidTest(string[]result,stringtext)
+{
+source.Text=text;
+
+SentenceFinalPunctCapitalizationCheckcheck=newSentenceFinalPunctCapitalizationCheck(source);
+List<TextTokenSubstring>tts=
+check.GetReferences(source.TextTokens(),"");
+
+Assert.That(tts.Count,Is.EqualTo(result.GetUpperBound(0)+1),"A different number of results was returned than what was expected.");
+
+for(inti=0;i<=result.GetUpperBound(0);++i)
+Assert.That(tts[i].InventoryText,Is.EqualTo(result[i]),"Result number: "+i.ToString());
+}
+
+[Test]
+publicvoidUpperCase()
+{
+Test(newstring[]{},@"\p \v 1 Foo. Bar");
+}
+
+[Test]
+publicvoidLowerCase()
+{
+Test(newstring[]{"."},@"\p \v 1 Foo. bar");
+}
+
+[Test]
+publicvoidNoCaseNonRoman()
+{
+Test(newstring[]{},"\\p \\v 1 Foo. \u0E01");
+}
+
+[Test]
+publicvoidNoCasePUA()
+{
+Test(newstring[]{},"\\p \\v 1 Foo. \uEE00");
+}
+
+[Test]
+publicvoidTitleCase()
+{
+Test(newstring[]{},"\\p \\v 1 Foo. \u01C5");
+}
+
+[Test]
+publicvoidMultipleUpperCase()
+{
+Test(newstring[]{},@"\p \v 1 Foo. Bar! Baz");
+}
+
+[Test]
+publicvoidMultipleLowerCase()
+{
+Test(newstring[]{".","!"},@"\p \v 1 Foo. bar! baz");
+}
+
+[Test]
+publicvoidMultipleMixedCase()
+{
+Test(newstring[]{"!"},@"\p \v 1 Foo. Bar! baz");
+}
+
+[Test]
+publicvoidMultiplePunctUpperCase()
+{
+Test(newstring[]{},@"\p \v 1 Foo!? Bar");
+}
+
+[Test]
+publicvoidMultiplePunctLowerCase()
+{
+Test(newstring[]{"!","?"},@"\p \v 1 Foo!? bar");
+}
+
+[Test]
+publicvoidQuotes()
+{
+Test(newstring[]{"!"},"\\p \\v 1 \u201CFoo!\u201D bar");
+}
+
+[Test]
+publicvoidDigits()
+{
+Test(newstring[]{},@"\p \v 1 Foo 1.2 bar");
+}
+
+[Test]
+publicvoidAbbreviationError()
+{
+Test(newstring[]{"."},@"\p \v 1 The E.U. headquarters.");
+}
+
+[Test]
+publicvoidAbbreviationOK()
+{
+source.SetParameterValue("Abbreviations","E.U.");
+Test(newstring[]{},@"\p \v 1 The E.U. headquarters.");
+}
+}
+#endif
+}

Lib/src/ScrChecks/ScrChecksTests/SentenceFinalPunctCapitalizationCheckUnitTest.cs

@@ -586,7 +586,7 @@ public void AllMultiStringPropTest()
 SilDataAccess.SetMultiStringAlt(hvo,tag,2,tss);
 
 vartsms=SilDataAccess.get_MultiStringProp(hvo,tag);
-Assert.That(2,Is.EqualTo(tsms.StringCount));
+Assert.That(tsms.StringCount,Is.EqualTo(2));
 }
 
 /// <summary>

Src/CacheLight/CacheLightTests/RealDataCacheTests.cs

@@ -178,7 +178,7 @@ public void LabelAbbreviations()
 // are abbreviated by being truncated to 4 characters.
 Assert.That((m_dtree.Controls[0]asSlice).Label,Is.EqualTo("CitationForm"));
 stringabbr1=StringTable.Table.GetString((m_dtree.Controls[0]asSlice).Label,"LabelAbbreviations");
-Assert.That("*"+(m_dtree.Controls[0]asSlice).Label+"*",Is.EqualTo(abbr1));// verify it's not in the table.
+Assert.That(abbr1,Is.EqualTo("*"+(m_dtree.Controls[0]asSlice).Label+"*"));// verify it's not in the table.
 Assert.That((m_dtree.Controls[0]asSlice).Abbreviation,Is.EqualTo("Cita"));// verify truncation took place.
 // 2) Test that a label in "LabelAbbreviations" defaults to its string table entry.
 Assert.That((m_dtree.Controls[1]asSlice).Label,Is.EqualTo("Citation Form"));
@@ -187,7 +187,7 @@ public void LabelAbbreviations()
 Assert.That((m_dtree.Controls[1]asSlice).Abbreviation,Is.EqualTo(abbr2));// should be identical
 // 3) Test that a label with an "abbr" attribute overrides default abbreviation.
 Assert.That((m_dtree.Controls[2]asSlice).Label,Is.EqualTo("Citation Form"));
-Assert.That("!?",Is.EqualTo((m_dtree.Controls[2]asSlice).Abbreviation));
+Assert.That((m_dtree.Controls[2]asSlice).Abbreviation,Is.EqualTo("!?"));
 Assert.That(abbr2==(m_dtree.Controls[2]asSlice).Abbreviation,Is.False);
 }