Reinstate gecko downloads through GitHub

Remove a bunch of old scripts

Author: johnml1135

.GitHub/agents/fieldworks.cpp-expert.agent.md

@@ -16,8 +16,8 @@ Your goals:
 
 ## FieldWorks-specific workflow (critical)
 - Always use the repo scripts unless explicitly instructed otherwise:
-- Build: `./build.ps1` (native must build before managed; traversal handles phases)
-- Native tests: `./test.ps1 -Native` (dispatches to `scripts/Agent/Invoke-CppTest.ps1`)
+- Build: `./build.ps1` (native must build before managed; traversal handles phases)
+- Native tests: `./test.ps1 -Native` (dispatches to `Build/scripts/Invoke-CppTest.ps1`)
 - Do not rely on `dotnet build` for native projects.
 
 ## Default native “fix loop”

.github/instructions/testing.instructions.md

@@ -33,7 +33,7 @@ Use `.\test.ps1` for all managed (C#) tests.
 
 ## Running Tests (Native C++)
 
-Use `.\test.ps1 -Native` for native (C++) tests. This wraps `scripts/Agent/Invoke-CppTest.ps1`.
+Use `.\test.ps1 -Native` for native (C++) tests. This wraps `Build/scripts/Invoke-CppTest.ps1`.
 
 ```powershell
 # Build and run TestGeneric (default)
@@ -55,14 +55,14 @@ Tests are built automatically by `test.ps1`. To build explicitly without running
 .\build.ps1 -BuildTests
 
 # Build native tests (via Invoke-CppTest backend)
-.\scripts\Agent\Invoke-CppTest.ps1 -Action Build -TestProject TestViews
+.\Build\scripts\Invoke-CppTest.ps1 -Action Build -TestProject TestViews
 ```
 
 ## Script Architecture
 
 The testing infrastructure relies on shared PowerShell modules for consistency:
 -**`test.ps1`**: Main entry point. Dispatches to VSTest (managed) or `Invoke-CppTest.ps1` (native).
--**`scripts/Agent/Invoke-CppTest.ps1`**: Backend for native C++ tests (MSBuild/NMake).
+-**`Build/scripts/Invoke-CppTest.ps1`**: Backend for native C++ tests (MSBuild/NMake).
 -**`Build/Agent/FwBuildHelpers.psm1`**: Shared logic for VS environment, and process cleanup.
 
 ## Debugging & Logs

.vscode/tasks.json

@@ -337,7 +337,7 @@
 "type": "shell",
 "command": "./test.ps1 -Native -Configuration ${input:testConfiguration}",
 "group": "test",
-"detail": "Run native tests via test.ps1 (dispatches to scripts/Agent/Invoke-CppTest.ps1)",
+"detail": "Run native tests via test.ps1 (dispatches to Build/scripts/Invoke-CppTest.ps1)",
 "options": {
 "shell": {
 "executable": "powershell.exe",

AGENTS.md

@@ -111,7 +111,7 @@ JIRA_PAT_TOKEN=<your-personal-access-token>
 
 ### Build & Test ordering
 - Native C++ (Phase 2 of `FieldWorks.proj`) must succeed before managed assemblies build. Let `.\build.ps1` enforce this.
-- Managed tests come from NUnit/VSTest. Native tests are driven via `scripts/Agent/Invoke-CppTest.ps1`; use `.\test.ps1 -Native` to stay consistent.
+- Managed tests come from NUnit/VSTest. Native tests are driven via `Build/scripts/Invoke-CppTest.ps1`; use `.\test.ps1 -Native` to stay consistent.
 
 ### COM and Registry
 - FieldWorks relies on registration-free COM. Do not register COM components globally or edit the Windows registry unless a spec explicitly directs it.

Build/PackageRestore.targets

@@ -28,6 +28,8 @@
 	<ImportProject="$(MSBuildThisFileDirectory)SilVersions.props" />
 	<PropertyGroup>
  <DownloadsDir>$(fwrt)/Downloads</DownloadsDir>
+<!-- GeckofxHtmlToPdf: download from GitHub release (https://github.com/sillsdev/geckofxHtmlToPdf/releases) -->
+ <GeckofxHtmlToPdfVersion>1.1.0</GeckofxHtmlToPdfVersion>
 <!-- PackagesDir: Use local packages folder. -->
  <PackagesDir>$(fwrt)/packages</PackagesDir>
 	</PropertyGroup>
@@ -261,12 +263,25 @@
  Condition="'$(UseLocalLibraries)'=='Y'"
  />
 <!-- ExCss.dll is now provided by the SIL.ExCSS NuGet package (no TeamCity download needed). -->
-<!-- GeckofxHtmlToPdf binaries must be pre-populated in Downloads/ (TeamCity server decommissioned).
- Build from https://github.com/sillsdev/geckofxHtmlToPdf and place output in Downloads directory. -->
- <Warning
- Text="GeckofxHtmlToPdf.exe not found in $(DownloadsDir) - PDF export will not work. Build from https://github.com/sillsdev/geckofxHtmlToPdf and place output in Downloads directory."
+<!-- GeckofxHtmlToPdf binaries downloaded from GitHub release (replaces decommissioned TeamCity server). -->
+ <DownloadFile
+ Address="https://github.com/sillsdev/geckofxHtmlToPdf/releases/download/$(GeckofxHtmlToPdfVersion)/GeckofxHtmlToPdf.exe"
+ LocalFilename="GeckofxHtmlToPdf.exe"
+ DownloadsDir="$(DownloadsDir)"
  Condition="'$(OS)'=='Windows_NT' AND !Exists('$(DownloadsDir)/GeckofxHtmlToPdf.exe')"
  />
+ <DownloadFile
+ Address="https://github.com/sillsdev/geckofxHtmlToPdf/releases/download/$(GeckofxHtmlToPdfVersion)/GeckofxHtmlToPdf.exe.config"
+ LocalFilename="GeckofxHtmlToPdf.exe.config"
+ DownloadsDir="$(DownloadsDir)"
+ Condition="'$(OS)'=='Windows_NT' AND !Exists('$(DownloadsDir)/GeckofxHtmlToPdf.exe.config')"
+ />
+ <DownloadFile
+ Address="https://github.com/sillsdev/geckofxHtmlToPdf/releases/download/$(GeckofxHtmlToPdfVersion)/Args.dll"
+ LocalFilename="Args.dll"
+ DownloadsDir="$(DownloadsDir)"
+ Condition="'$(OS)'=='Windows_NT' AND !Exists('$(DownloadsDir)/Args.dll')"
+ />
 	</Target>
 
 <!-- ======================================================================================== -->

scripts/Agent/Invoke-CppTest.ps1 Build/scripts/Invoke-CppTest.ps1scripts/Agent/Invoke-CppTest.ps1 renamed to Build/scripts/Invoke-CppTest.ps1

@@ -65,7 +65,7 @@ $script:LastLocalOutDir = $null
 # Import Shared Module
 # =============================================================================
 
-$helpersPath=Join-Path$PSScriptRoot"../../Build/Agent/FwBuildHelpers.psm1"
+$helpersPath=Join-Path$PSScriptRoot"../Agent/FwBuildHelpers.psm1"
 if (-not (Test-Path$helpersPath)) {
 Write-Host"[ERROR] FwBuildHelpers.psm1 not found at $helpersPath"-ForegroundColor Red
 exit1
@@ -148,7 +148,7 @@ function Build-FwBuildTasks {
 '/p:Platform=x64',
 '/nologo'
  )
-$cmd="cd /d `"$WorktreePath`" && $msbuild$($args-join'')"
+$cmd="cd /d `\"$WorktreePath`\" && $msbuild$($args-join'')"
  cmd /c $cmd
 if ($LASTEXITCODE-ne0) { throw"FwBuildTasks build failed with exit code $LASTEXITCODE" }
 }
@@ -165,7 +165,7 @@ function Build-NativeArtifacts {
 '/nologo',
 '/m'
  )
-$cmd="cd /d `"$WorktreePath`" && $msbuild$($args-join'')"
+$cmd="cd /d `\"$WorktreePath`\" && $msbuild$($args-join'')"
  cmd /c $cmd
 if ($LASTEXITCODE-ne0) { throw"Native build failed with exit code $LASTEXITCODE" }
 }
@@ -182,7 +182,7 @@ function Build-ViewsInterfacesArtifacts {
 '/nologo',
 '/v:minimal'
  )
-$cmd="cd /d `"$WorktreePath`" && $msbuild$($args-join'')"
+$cmd="cd /d `\"$WorktreePath`\" && $msbuild$($args-join'')"
  cmd /c $cmd
 if ($LASTEXITCODE-ne0) { throw"ViewsInterfaces build failed with exit code $LASTEXITCODE" }
 }
@@ -251,7 +251,7 @@ function Invoke-Build {
 $msbuildCmd="$msbuild$($msbuildArgs-join'')"
 Write-Host"(cd $WorktreePath) $msbuildCmd"-ForegroundColor Gray
 
-$cmdLine="cd /d `"$WorktreePath`" && $msbuildCmd"
+$cmdLine="cd /d `\"$WorktreePath`\" && $msbuildCmd"
  cmd /c $cmdLine
 if ($LASTEXITCODE-ne0) { throw"MSBuild failed with exit code $LASTEXITCODE" }
 
@@ -307,8 +307,8 @@ function Invoke-Build {
 
 # VsDevCmd is already initialized by Initialize-VsDevEnvironment
 
-$cmd="cd /d `"$makeDir`" && nmake /nologo BUILD_CONFIG=$Configuration BUILD_TYPE=$buildType BUILD_ROOT=$WorktreePath\ BUILD_ARCH=x64 /f $makefile"
-Write-Host"cmd /c `"$cmd`""-ForegroundColor Gray
+$cmd="cd /d `\"$makeDir`\" && nmake /nologo BUILD_CONFIG=$Configuration BUILD_TYPE=$buildType BUILD_ROOT=$WorktreePath\ BUILD_ARCH=x64 /f $makefile"
+Write-Host"cmd /c `\"$cmd`\""-ForegroundColor Gray
  cmd /c $cmd
 if ($LASTEXITCODE-ne0) { throw"NMake failed with exit code $LASTEXITCODE" }
  }

ReadMe.md

@@ -97,12 +97,4 @@ requirements and troubleshooting tips.
 We maintain a human-facing `.github/AGENTS.md` plus a small curated set of
 `*.instructions.md` files under `.github/instructions/` for prescriptive constraints.
 
-See [.github/AI_GOVERNANCE.md](.github/AI_GOVERNANCE.md) for the documentation taxonomy and “source of truth” rules.
-
-## Recent Changes
-
-**MSBuild Traversal SDK**: FieldWorks now uses Microsoft.Build.Traversal SDK with declarative dependency ordering across 110+ projects organized into 21 build phases. This provides automatic parallel builds, better incremental builds, and clearer dependency management.
-
-**64-bit only + Registration-free COM**: FieldWorks now builds and runs as x64-only with registration-free COM activation. No administrator privileges or COM registration required. See [Docs/64bit-regfree-migration.md](Docs/64bit-regfree-migration.md) for details.
-
-**Unified launcher**: FieldWorks.exe is now the single supported executable. The historical `Flex.exe` stub (LexTextExe) has been removed; shortcuts and scripts should invoke `FieldWorks.exe` directly.
+See [.github/AI_GOVERNANCE.md](.github/AI_GOVERNANCE.md) for the documentation taxonomy and “source of truth” rules.