From 4e12dcc1bde52dfd81eb05ce2f9d8bbaea42898f Mon Sep 17 00:00:00 2001 From: Justin Blumencranz <96924014+j15z@users.noreply.github.com> Date: Mon, 10 Aug 2026 18:10:32 -0700 Subject: [PATCH] fix(knowledge): pluralize the module header and root breadcrumb --- .../knowledge/[id]/[documentId]/document.tsx | 8 ++++---- .../[workspaceId]/knowledge/[id]/[documentId]/loading.tsx | 2 +- .../app/workspace/[workspaceId]/knowledge/[id]/base.tsx | 6 +++--- .../workspace/[workspaceId]/knowledge/[id]/loading.tsx | 2 +- .../app/workspace/[workspaceId]/knowledge/knowledge.tsx | 2 +- .../sim/app/workspace/[workspaceId]/knowledge/loading.tsx | 2 +- apps/sim/app/workspace/[workspaceId]/knowledge/page.tsx | 2 +- 7 files changed, 12 insertions(+), 12 deletions(-) diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx index b8588c68527..4309bf32eba 100644 --- a/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx +++ b/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx @@ -510,7 +510,7 @@ export function Document({ () => combinedError ? [ - { label: 'Knowledge Base', icon: Database, onClick: handleNavToKB }, + { label: 'Knowledge bases', icon: Database, onClick: handleNavToKB }, { label: knowledgeBaseCrumbLabel, icon: Database, @@ -519,7 +519,7 @@ export function Document({ { label: 'Error' }, ] : [ - { label: 'Knowledge Base', icon: Database, onClick: handleNavToKB }, + { label: 'Knowledge bases', icon: Database, onClick: handleNavToKB }, { label: knowledgeBaseCrumbLabel, icon: Database, @@ -989,7 +989,7 @@ export function Document({ const editorBreadcrumbBase = useMemo( () => [ - { label: 'Knowledge Base', icon: Database, onClick: handleNavToKB }, + { label: 'Knowledge bases', icon: Database, onClick: handleNavToKB }, { label: knowledgeBaseCrumbLabel, icon: Database, @@ -1022,7 +1022,7 @@ export function Document({ const loadingBreadcrumbs = useMemo( () => [ - { label: 'Knowledge Base', icon: Database, onClick: handleNavToKB }, + { label: 'Knowledge bases', icon: Database, onClick: handleNavToKB }, { label: knowledgeBaseCrumbLabel, icon: Database, diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/loading.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/loading.tsx index cbb1fdc6009..f73a9167d08 100644 --- a/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/loading.tsx +++ b/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/loading.tsx @@ -19,7 +19,7 @@ const COLUMNS = [ const ACTIONS: ChromeActionSpec[] = [{ text: 'New chunk', icon: Plus, variant: 'primary' }] const BREADCRUMBS: BreadcrumbItem[] = [ - { label: 'Knowledge Base', icon: Database, onClick: noop }, + { label: 'Knowledge bases', icon: Database, onClick: noop }, { label: '…', icon: Database }, { label: '…', terminal: true }, ] diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx index 2ae02bbec87..43255e696f7 100644 --- a/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx +++ b/apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx @@ -444,7 +444,7 @@ export function KnowledgeBase({ /** * Breadcrumb leaf label. Falls back to the canonical '…' placeholder while * the name loads (mirroring loading.tsx) instead of duplicating the root - * "Knowledge Base" crumb. + * "Knowledge bases" crumb. */ const knowledgeBaseCrumbLabel = knowledgeBase?.name || passedKnowledgeBaseName || '…' const error = knowledgeBaseError || documentsError @@ -872,7 +872,7 @@ export function KnowledgeBase({ const breadcrumbs: BreadcrumbItem[] = [ { - label: 'Knowledge Base', + label: 'Knowledge bases', icon: Database, onClick: () => router.push(`/workspace/${workspaceId}/knowledge`), }, @@ -1182,7 +1182,7 @@ export function KnowledgeBase({