[fix] Remove any reference to the global variable

Related: socketio/socket.io-client#1166

Author: darrachequesne

binary.js

@@ -7,8 +7,8 @@
 varisArray=require('isarray');
 varisBuf=require('./is-buffer');
 vartoString=Object.prototype.toString;
-varwithNativeBlob=typeofglobal.Blob==='function'||toString.call(global.Blob)==='[object BlobConstructor]';
-varwithNativeFile=typeofglobal.File==='function'||toString.call(global.File)==='[object FileConstructor]';
+varwithNativeBlob=typeofBlob==='function'||(typeofBlob!=='undefined'&&toString.call(Blob)==='[object BlobConstructor]');
+varwithNativeFile=typeofFile==='function'||(typeofFile!=='undefined'&&toString.call(File)==='[object FileConstructor]');
 
 /**
  * Replaces every Buffer | ArrayBuffer in packet with a numbered placeholder.

is-buffer.js

@@ -1,16 +1,12 @@
 
 module.exports=isBuf;
 
-varwithNativeBuffer=typeofglobal.Buffer==='function'&&typeofglobal.Buffer.isBuffer==='function';
-varwithNativeArrayBuffer=typeofglobal.ArrayBuffer==='function';
+varwithNativeBuffer=typeofBuffer==='function'&&typeofBuffer.isBuffer==='function';
+varwithNativeArrayBuffer=typeofArrayBuffer==='function';
 
-varisView=(function(){
-if(withNativeArrayBuffer&&typeofglobal.ArrayBuffer.isView==='function'){
-returnglobal.ArrayBuffer.isView;
-}else{
-returnfunction(obj){returnobj.bufferinstanceofglobal.ArrayBuffer;};
-}
-})();
+varisView=function(obj){
+returntypeofArrayBuffer.isView==='function' ? ArrayBuffer.isView(obj) : (obj.bufferinstanceofArrayBuffer);
+};
 
 /**
  * Returns true if obj is a buffer or an arraybuffer.
@@ -19,6 +15,6 @@ var isView = (function () {
  */
 
 functionisBuf(obj){
-return(withNativeBuffer&&global.Buffer.isBuffer(obj))||
-(withNativeArrayBuffer&&(objinstanceofglobal.ArrayBuffer||isView(obj)));
+return(withNativeBuffer&&Buffer.isBuffer(obj))||
+(withNativeArrayBuffer&&(objinstanceofArrayBuffer||isView(obj)));
 }

test/blob.js

@@ -1,10 +1,10 @@
 varparser=require('../index.js');
-varexpect=require('expect.js');
 varhelpers=require('./helpers.js');
-varencode=parser.encode;
-vardecode=parser.decode;
 
-varBlobBuilder=global.BlobBuilder||global.WebKitBlobBuilder||global.MSBlobBuilder||global.MozBlobBuilder;
+varBlobBuilder=typeofBlobBuilder!=='undefined' ? BlobBuilder :
+typeofWebKitBlobBuilder!=='undefined' ? WebKitBlobBuilder :
+typeofMSBlobBuilder!=='undefined' ? MSBlobBuilder :
+typeofMozBlobBuilder!=='undefined' ? MozBlobBuilder : false;
 
 describe('parser',function(){
 it('encodes a Blob',function(){

test/index.js

@@ -12,7 +12,10 @@ var blobSupported = (function() {
  * Create a blob builder even when vendor prefixes exist
  */
 
-varBlobBuilder=global.BlobBuilder||global.WebKitBlobBuilder||global.MSBlobBuilder||global.MozBlobBuilder;
+varBlobBuilder=typeofBlobBuilder!=='undefined' ? BlobBuilder :
+typeofWebKitBlobBuilder!=='undefined' ? WebKitBlobBuilder :
+typeofMSBlobBuilder!=='undefined' ? MSBlobBuilder :
+typeofMozBlobBuilder!=='undefined' ? MozBlobBuilder : false;
 varblobBuilderSupported=!!BlobBuilder&&!!BlobBuilder.prototype.append&&!!BlobBuilder.prototype.getBlob;
 
 require('./parser.js');
@@ -21,7 +24,7 @@ if (!env.browser) {
 require('./buffer.js');
 }
 
-if(global.ArrayBuffer){
+if(typeofArrayBuffer!=='undefined'){
 require('./arraybuffer.js');
 }
 

test/support/env.js

@@ -2,4 +2,4 @@
 // we only do this in our tests because we need to test engine.io-client
 // support in browsers and in node.js
 // some tests do not yet work in both
-module.exports.browser=!!global.window;
+module.exports.browser=typeofwindow!=='undefined';