Skip to content

fix: Prefix ui-http port endpoints with http:// - #368

Merged
sbernauer merged 3 commits into
mainfrom
chore/hbase-listener
Apr 10, 2025
Merged

fix: Prefix ui-http port endpoints with http://#368
sbernauer merged 3 commits into
mainfrom
chore/hbase-listener

Conversation

@sbernauer

@sbernauersbernauer commented Apr 9, 2025

Copy link
Copy Markdown
Member

Description

Noticed in stackabletech/hbase-operator#639

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauersbernauer changed the title Prefix ui-http port endpoints with http://fix: Prefix ui-http port endpoints with http://Apr 9, 2025
@sbernauersbernauer moved this to Development: Waiting for Review in Stackable EngineeringApr 9, 2025
@sbernauersbernauer self-assigned this Apr 9, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Apr 10, 2025
View reviewed changes

@NickLarsenNZNickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZNickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable EngineeringApr 10, 2025
@sbernauer
sbernauer added this pull request to the merge queueApr 10, 2025
@sbernauersbernauer moved this from Development: In Review to Development: Done in Stackable EngineeringApr 10, 2025
Merged via the queue into main with commit 3c84831Apr 10, 2025
@sbernauer
sbernauer deleted the chore/hbase-listener branch April 10, 2025 09:51
@lfranckelfrancke moved this from Development: Done to Done in Stackable EngineeringApr 23, 2025
@TechassiTechassi mentioned this pull request Jun 2, 2025
Merged
@sbernauersbernauer mentioned this pull request Jul 11, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZNickLarsenNZNickLarsenNZ approved these changes

Assignees

@sbernauersbernauer

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer@NickLarsenNZ@lfrancke