Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

fix(alert detected type): don't default to leaked secret - #208

Merged
kantord merged 23 commits into
mainfrom
fix/issue-detected-type/don't-default-to-leaked-secret
Jan 27, 2025
Merged

fix(alert detected type): don't default to leaked secret#208
kantord merged 23 commits into
mainfrom
fix/issue-detected-type/don't-default-to-leaked-secret

Conversation

@lxmcgvrn

@lxmcgvrnlxmcgvrn commented Jan 27, 2025

Copy link
Copy Markdown
Contributor
  • fixes a minor nit in getIssueDetectedType where we were defaulting to "leaked" secret if an alert was not malicious
  • fixes a failing test in AlertsTable caused by isColumnHeader being applied to the time, rather than the "type" of alert

Base automatically changed from alerts-table-refactor to mainJanuary 27, 2025 12:07
@kantord
kantord enabled auto-merge (squash) January 27, 2025 13:14
@coveralls

coveralls commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 12990646744

Details

  • 6 of 7(85.71%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 68.305%

Changes Missing CoverageCovered LinesChanged/Added Lines%
src/lib/utils.ts2366.67%
TotalsCoverage Status
Change from base Build 12988609897:0.07%
Covered Lines:768
Relevant Lines:1023

💛 - Coveralls

@kantord
kantord merged commit 0e64263 into mainJan 27, 2025
@kantord
kantord deleted the fix/issue-detected-type/don't-default-to-leaked-secret branch January 27, 2025 14:09
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lxmcgvrn@coveralls@peppescg@kantord