Uh oh!
There was an error while loading. Please reload this page.
[6.x] Support taggable comboboxes when multiple is false - #15064
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the
Comboboxcomponent did not support adding new options (via thetaggableprop) whenmultipleisfalse.This was happening because the taggable handlers assumed the model value was an array: pressing enter committed an array into the string model, the duplicate check used
.includes()(which does a substring match on strings), and pasting was hijacked to split the pasted text into tags.This PR fixes it by committing the raw string when
multipleisfalse, comparing against the current value with strict equality, closing the dropdown after committing, and leaving paste alone for single selects.This PR also adds interaction tests covering the new single-select behaviour, along with the existing multiple behaviour, to protect against regressions.