Uh oh!
There was an error while loading. Please reload this page.
[6.x] Fix non-localizable button group fields being editable in localizations - #15151
Merged
jasonvarga merged 3 commits intoAug 11, 2026
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
button_groupfield withlocalizable: falsestayed clickable in a localization, and clicking an option desynced the field and wrote the new value into the localization's own content file instead of leaving it to resolve from the origin.This used to work. fb4f58b swapped the fieldtype's
:disabled="isReadOnly"for:read-only="isReadOnly", butButtonwas never given areadOnlyprop, so since then the binding has landed on the element as an inert attribute and the click handler has stayed live.Added the prop and folded it into the button's disabled state, the same way the
Radiocomponent handles it. The control appearance fieldtype and the revealer fieldtype's button mode pass the same prop toButton, so those are covered too.Fixes#15149