Uh oh!
There was an error while loading. Please reload this page.
[6.x] Fix nav entry links across sites losing their domain - #15239
Merged
jasonvarga merged 3 commits intoAug 21, 2026
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a multi-site install with sites on different domains, a nav item linking to an entry on another site rendered
{{ url }}without that entry's scheme and host, so the browser resolved it against the current site and 404'd.Page::url()always fell back to the linked entry's relative URL, even when the nav hadselect_across_sitesturned on, so only{{ permalink }}picked up the right domain. The same relative URL fedis_currentandis_parent, so a cross-site item could get flagged as active whenever the two sites happened to share a path.Page::url()andurlWithoutRedirect()now check the nav'sselect_across_sitessetting and return the entry's absolute URL when it's enabled, mirroring the fix already applied to Bard entry links in #12694.AugmentedPageneeded its ownurl()/urlWithoutRedirect()overrides too, since the augmentedurlkey was resolving straight off the underlying entry instead of going through the page.Fixes#15237