From c6d4c0e22e9563faf5df364a1e0b061968e071d4 Mon Sep 17 00:00:00 2001 From: Duncan McClean Date: Mon, 27 Jul 2026 06:57:20 -0400 Subject: [PATCH] remove stale phpstan ignore patterns PHPStan no longer reports the `valueRetriever()`/`$items` errors for the `keyByWithKey` macro in `CollectionsServiceProvider`, so the ignore patterns for them go unmatched and fail the run. Co-Authored-By: Claude Opus 5 --- phpstan.dist.neon | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/phpstan.dist.neon b/phpstan.dist.neon index f15f7c292ef..516f3cd17db 100644 --- a/phpstan.dist.neon +++ b/phpstan.dist.neon @@ -48,16 +48,3 @@ parameters: identifier: staticMethod.notFound message: '#^Call to an undefined static method Statamic\\Providers\\AppServiceProvider::this\(\)\.$#' path: src/Providers/AppServiceProvider.php - - # keyByWithKey() is a public Collection macro kept for third-party/addon backward - # compatibility even though Statamic's own code no longer calls it, so its use of - # Collection's protected valueRetriever()/$items internals is left as-is rather than - # rewritten to public equivalents. - - - identifier: method.protected - message: '#^Call to protected method valueRetriever\(\) of class Illuminate\\Support\\Collection(<.*>)?\.$#' - path: src/Providers/CollectionsServiceProvider.php - - - identifier: property.protected - message: '#^Access to protected property Illuminate\\Support\\Collection::\$items\.$#' - path: src/Providers/CollectionsServiceProvider.php