Conversation
Automated sync from stranske/Workflows Template hash: 73606b58133d Changes synced from sync-manifest.yml
Contributor
Contributor
🤖 Keepalive Loop StatusPR #5112 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
Contributor
Keepalive Work Log (click to expand)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs workflow templates from stranske/Workflows by extending the weekly metrics workflow to also preflight bot-comment App auth coverage, and updating artifact selection to include the new auth-coverage artifacts.
Changes:
- Add a “Bot-comment auth coverage preflight” step and include its outputs in uploaded artifacts + hard-block enforcement.
- Extend weekly metrics artifact selection to recognize/prioritize bot-comment auth coverage artifact families.
- Introduce
.github/scripts/bot_comment_auth_coverage.jsto summarize/enforce bot-comment auth coverage from downloaded artifacts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/agents-weekly-metrics.yml | Runs bot-comment auth coverage preflight, uploads its reports, and hard-blocks when configured. |
| .github/scripts/weekly_metrics_artifacts.js | Includes bot-comment auth coverage artifacts in the selection contract. |
| .github/scripts/bot_comment_auth_coverage.js | New Node helper that scans downloaded artifacts, builds a coverage summary, and optionally fails in hard-block mode. |
Comment on lines
+1
to
+35
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const COVERAGE_SCHEMA = 'workflows-bot-comment-auth-coverage-summary/v1'; | ||
| const AUTH_SCHEMA = 'workflows-bot-comment-auth-coverage/v1'; | ||
| const DEFAULT_MODE = 'warning-only'; | ||
| const HARD_BLOCK_MODE = 'hard-block'; | ||
| const AUTH_ARTIFACT_FAMILIES = new Set([ | ||
| 'bot-comment-auth-coverage-wrapper', | ||
| 'bot-comment-auth-coverage-reusable', | ||
| ]); | ||
|
|
||
| const COMPONENT_POLICIES = { | ||
| 'agents-bot-comment-handler-wrapper': { | ||
| expected_mode: 'client-id', | ||
| allowed_modes: ['client-id'], | ||
| missing_record_severity: 'no-data', | ||
| }, | ||
| 'reusable-bot-comment-handler': { | ||
| expected_mode: '', | ||
| allowed_modes: ['client-id', 'none'], | ||
| missing_record_severity: 'no-data', | ||
| }, | ||
| }; | ||
|
|
||
| function cleanString(value) { | ||
| if (value === null || value === undefined) return ''; | ||
| return String(value).trim(); | ||
| } | ||
|
|
||
| function normalizeBoolean(value) { | ||
| if (typeof value === 'boolean') return value; | ||
| const text = cleanString(value).toLowerCase(); | ||
| return ['1', 'true', 'yes', 'y', 'approved', 'approve', 'on'].includes(text); | ||
| } |
There was a problem hiding this comment.
New workflow helper script is introduced without corresponding unit tests. Per .github/scripts/README.md this repo expects lightweight tests for helper utilities under .github/scripts/__tests__; please add coverage for key behaviors (e.g., file discovery via collectJsonFiles/isPotentialAuthCoverageFile, and reporting/enforcement logic in summarizeBotCommentAuthCoverage).
7 tasks
7 tasks
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Manifest:
.github/sync-manifest.yml