fix: address shared sync review blockers - #2778
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (7)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Automated Status SummaryHead SHA: 72bf064
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
| response.raise_for_status() | ||
| return response.json() | ||
| request = Request(url, headers=headers) | ||
| with urlopen(request, timeout=30) as response: # noqa: S310 - caller URLs are fixed |
There was a problem hiding this comment.
Pull request overview
This PR addresses consumer sync review blockers by making model selection more resilient to malformed slot profiles, removing a direct requests dependency from catalog discovery, tightening credential-like evidence detection, and pinning critical GitHub Actions to immutable SHAs.
Changes:
- Adjust slot-driven model selection to skip malformed slot profiles and fall back to provider-level reviewed selection.
- Replace
requestsusage in model catalog discovery withurllib.requestand update tests accordingly. - Expand credential-like evidence segment detection to include
#and@delimiters; pinagent-run-basecomposite action dependencies to commit SHAs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/llm_registry.py | Skip malformed slot selections so they don’t mask provider-level reviewed selection/fallback. |
| templates/consumer-repo/tools/llm_registry.py | Mirrors the slot-selection behavior change in the consumer template copy. |
| tests/tools/test_llm_registry_selection.py | Updates the expected behavior for unknown slot profiles to use reviewed fallback selection. |
| tools/discover_model_catalog.py | Removes requests by switching to urllib for fixed-URL catalog fetching and error handling. |
| tests/tools/test_discover_model_catalog.py | Updates request mocking/assertions for the new urllib-based fetch path. |
| scripts/runner_lib/core.py | Tightens secret-like evidence detection to reject segments following # or @. |
| .github/actions/agent-run-base/action.yml | Pins actions/create-github-app-token and actions/checkout to immutable commit SHAs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e870f2399e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Runner dispatch state for codex on PR #2778. Do not edit. |
|
Runner dispatch state for autofix on PR #2778. Do not edit. |
Addresses active non-outdated review feedback on the current consumer sync wave at its source of truth.
Validated: focused pytest (62 passed), template sync/completeness, and git diff --check.