Skip to content

makes copy of original configuration and use original callbacks - #112

Merged
outsideris merged 2 commits into
outsideris:masterfrom
shadybones:master
Feb 20, 2016
Merged

makes copy of original configuration and use original callbacks#112
outsideris merged 2 commits into
outsideris:masterfrom
shadybones:master

Conversation

@shadybones

Copy link
Copy Markdown
Contributor

so that a global configuration object can be used
related to #111

@outsideris

Copy link
Copy Markdown
Owner

I understand what you intend in this PR (#111).
I feel it is too complex, and it is not efficient both callbacks, an original callback and a callback from attributes, are invoked in every callback.
So, I fixed such as https://gist.github.com/outsideris/4045c5912d116511d3b2. How do you think about that?
I wanted it use basically callbacks in summernote config object and overwrite it if a user specifies callback in an attribute.

@shadybones

Copy link
Copy Markdown
ContributorAuthor

That would work, as long as you still make a copy of the original config object (I can't see it in the gist you made):

var currentElement, summernoteConfig = angular.copy($scope.summernoteConfig) || {};

@outsideris

Copy link
Copy Markdown
Owner

@shadybones I make the diff in gist on top of your commit so, I ommit the making a copy parts.
If you agreed with the diff, please update your PR. After that I will merge it.
Let me know if you are busy. I will modify it after I merge your current PR.

change listener configuration to have attribute listeners overwrite listeners from the configuration object.
@shadybones

Copy link
Copy Markdown
ContributorAuthor

@outsideris I'm wondering, was there a reason onChange was done differently than the rest of the callbacks? I've implemented your changes into the PR.

@outsideris

Copy link
Copy Markdown
Owner

Thank you.
onChange is defferent because it have to sync with ngModel.

outsideris added a commit that referenced this pull request Feb 20, 2016
makes copy of original configuration and use original callbacks
@outsideris
outsideris merged commit ee89dcc into outsideris:masterFeb 20, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shadybones@outsideris