makes copy of original configuration and use original callbacks - #112
Conversation
outsideris
commented
Feb 13, 2016
I understand what you intend in this PR (#111). |
shadybones
commented
Feb 16, 2016
That would work, as long as you still make a copy of the original config object (I can't see it in the gist you made): |
outsideris
commented
Feb 18, 2016
@shadybones I make the diff in gist on top of your commit so, I ommit the making a copy parts. |
change listener configuration to have attribute listeners overwrite listeners from the configuration object.
shadybones
commented
Feb 19, 2016
@outsideris I'm wondering, was there a reason onChange was done differently than the rest of the callbacks? I've implemented your changes into the PR. |
outsideris
commented
Feb 20, 2016
Thank you. |
makes copy of original configuration and use original callbacks
so that a global configuration object can be used
related to #111