Uh oh!
There was an error while loading. Please reload this page.
fix: construct supabaseAdmin lazily on first access - #124
Merged
Conversation
commit: |
spydon
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withSupabasefolded the admin client entry eagerly, socreateAdminClientran on every request and a project with no secret key configured got a 500 on every request, even when the handler never touchedctx.supabaseAdmin. The entry now contributes a lazy, per-request memoized Proxy (newlazyClienthelper insrc/core/lazy-client.ts): construction happens on the first property access, so handlers that never use the admin client need no secret key, and a missing key surfaces as anEnvErrorat the point of use instead of a blanket 500. Proxy methods are bound to the real instance so supabase-js internals (private fields, prototype getters) keep working. The non-admin client entry, thecreateAdminClientpublic API, and the client-phase error mapping are unchanged; tests cover the new contract and docs reflect when the secret key is required.