Ensure all properties have a type

Author: nicolas-grekas

Pipes/AbstractPipes.php

@@ -23,19 +23,18 @@ abstract class AbstractPipes implements PipesInterface
 publicarray$pipes = [];
 
 privatestring$inputBuffer = '';
+/** @var resource|string|\Iterator */
 private$input;
 privatebool$blocked = true;
 private ?string$lastError = null;
 
 /**
- * @param resource|string|int|float|bool|\Iterator|null $input
+ * @param resource|string|\Iterator $input
  */
-publicfunction__construct(mixed$input)
+publicfunction__construct($input)
  {
 if (\is_resource($input) || $inputinstanceof \Iterator) {
 $this->input = $input;
- } elseif (\is_string($input)) {
-$this->inputBuffer = $input;
  } else {
 $this->inputBuffer = (string) $input;
  }

Process.php

@@ -54,6 +54,7 @@ class Process implements \IteratorAggregate
 privatearray|string$commandline;
 private ?string$cwd;
 privatearray$env = [];
+/** @var resource|string|\Iterator|null */
 private$input;
 private ?float$starttime = null;
 private ?float$lastOutputTime = null;
@@ -63,8 +64,11 @@ class Process implements \IteratorAggregate
 privatearray$fallbackStatus = [];
 privatearray$processInformation;
 privatebool$outputDisabled = false;
+/** @var resource */
 private$stdout;
+/** @var resource */
 private$stderr;
+/** @var resource|null */
 private$process;
 privatestring$status = self::STATUS_READY;
 privateint$incrementalOutputOffset = 0;
@@ -345,11 +349,12 @@ public function start(callable $callback = null, array $env = [])
 thrownewRuntimeException(sprintf('The provided cwd "%s" does not exist.', $this->cwd));
  }
 
-$this->process = @proc_open($commandline, $descriptors, $this->processPipes->pipes, $this->cwd, $envPairs, $this->options);
+$process = @proc_open($commandline, $descriptors, $this->processPipes->pipes, $this->cwd, $envPairs, $this->options);
 
-if (!\is_resource($this->process)) {
+if (!\is_resource($process)) {
 thrownewRuntimeException('Unable to launch a new process.');
  }
+$this->process = $process;
 $this->status = self::STATUS_STARTED;
 
 if (isset($descriptors[3])) {
@@ -1118,7 +1123,7 @@ public function getInput()
  *
  * This content will be passed to the underlying process standard input.
  *
- * @param string|int|float|bool|resource|\Traversable|null $input The content
+ * @param string|resource|\Traversable|self|null $input The content
  *
  * @return $this
  *

ProcessUtils.php

@@ -43,9 +43,6 @@ public static function validateInput(string $caller, mixed $input): mixed
 if (\is_resource($input)) {
 return$input;
  }
-if (\is_string($input)) {
-return$input;
- }
 if (\is_scalar($input)) {
 return (string) $input;
  }