Add types to private and internal properties

Author: nicolas-grekas

Exception/ProcessFailedException.php

@@ -20,7 +20,7 @@
  */
 class ProcessFailedException extends RuntimeException
 {
-private$process;
+privateProcess$process;
 
 publicfunction__construct(Process$process)
  {

Exception/ProcessSignaledException.php

@@ -20,7 +20,7 @@
  */
 finalclass ProcessSignaledException extends RuntimeException
 {
-private$process;
+privateProcess$process;
 
 publicfunction__construct(Process$process)
  {

Exception/ProcessTimedOutException.php

@@ -23,8 +23,8 @@ class ProcessTimedOutException extends RuntimeException
 publicconstTYPE_GENERAL = 1;
 publicconstTYPE_IDLE = 2;
 
-private$process;
-private$timeoutType;
+privateProcess$process;
+privateint$timeoutType;
 
 publicfunction__construct(Process$process, int$timeoutType)
  {

ExecutableFinder.php

@@ -19,7 +19,7 @@
  */
 class ExecutableFinder
 {
-private$suffixes = ['.exe', '.bat', '.cmd', '.com'];
+privatearray$suffixes = ['.exe', '.bat', '.cmd', '.com'];
 
 /**
  * Replaces default suffixes of executable.

InputStream.php

@@ -22,10 +22,9 @@
  */
 class InputStream implements \IteratorAggregate
 {
-/** @var callable|null */
-private$onEmpty;
-private$input = [];
-private$open = true;
+private ?\Closure$onEmpty = null;
+privatearray$input = [];
+privatebool$open = true;
 
 /**
  * Sets a callback that is called when the write buffer becomes empty.
@@ -34,7 +33,7 @@ class InputStream implements \IteratorAggregate
  */
 publicfunctiononEmpty(callable$onEmpty = null)
  {
-$this->onEmpty = $onEmpty;
+$this->onEmpty = null !== $onEmpty ? $onEmpty(...) : null;
  }
 
 /**

PhpExecutableFinder.php

@@ -19,7 +19,7 @@
  */
 class PhpExecutableFinder
 {
-private$executableFinder;
+privateExecutableFinder$executableFinder;
 
 publicfunction__construct()
  {

Pipes/AbstractPipes.php

@@ -22,10 +22,10 @@ abstract class AbstractPipes implements PipesInterface
 {
 publicarray$pipes = [];
 
-private$inputBuffer = '';
+privatestring$inputBuffer = '';
 private$input;
-private$blocked = true;
-private$lastError;
+privatebool$blocked = true;
+private?string$lastError = null;
 
 /**
  * @param resource|string|int|float|bool|\Iterator|null $input

Pipes/UnixPipes.php

@@ -22,9 +22,9 @@
  */
 class UnixPipes extends AbstractPipes
 {
-private$ttyMode;
-private$ptyMode;
-private$haveReadSupport;
+private?bool$ttyMode;
+privatebool$ptyMode;
+privatebool$haveReadSupport;
 
 publicfunction__construct(?bool$ttyMode, bool$ptyMode, mixed$input, bool$haveReadSupport)
  {

Pipes/WindowsPipes.php

@@ -26,14 +26,14 @@
  */
 class WindowsPipes extends AbstractPipes
 {
-private$files = [];
-private$fileHandles = [];
-private$lockHandles = [];
-private$readBytes = [
+privatearray$files = [];
+privatearray$fileHandles = [];
+privatearray$lockHandles = [];
+privatearray$readBytes = [
  Process::STDOUT => 0,
  Process::STDERR => 0,
  ];
-private$haveReadSupport;
+privatebool$haveReadSupport;
 
 publicfunction__construct(mixed$input, bool$haveReadSupport)
  {

Process.php

@@ -17,7 +17,6 @@
 useSymfony\Component\Process\Exception\ProcessSignaledException;
 useSymfony\Component\Process\Exception\ProcessTimedOutException;
 useSymfony\Component\Process\Exception\RuntimeException;
-useSymfony\Component\Process\Pipes\PipesInterface;
 useSymfony\Component\Process\Pipes\UnixPipes;
 useSymfony\Component\Process\Pipes\WindowsPipes;
 
@@ -51,37 +50,35 @@ class Process implements \IteratorAggregate
 publicconstITER_SKIP_OUT = 4; // Use this flag to skip STDOUT while iterating
 publicconstITER_SKIP_ERR = 8; // Use this flag to skip STDERR while iterating
 
-private$callback;
-private$hasCallback = false;
-private$commandline;
-private$cwd;
-private$env = [];
+private ?\Closure$callback = null;
+privatearray|string$commandline;
+private ?string$cwd;
+privatearray$env = [];
 private$input;
-private$starttime;
-private$lastOutputTime;
-private$timeout;
-private$idleTimeout;
-private$exitcode;
-private$fallbackStatus = [];
-private$processInformation;
-private$outputDisabled = false;
+private?float$starttime = null;
+private?float$lastOutputTime = null;
+private?float$timeout = null;
+private?float$idleTimeout = null;
+private?int$exitcode = null;
+privatearray$fallbackStatus = [];
+privatearray$processInformation;
+privatebool$outputDisabled = false;
 private$stdout;
 private$stderr;
 private$process;
-private$status = self::STATUS_READY;
-private$incrementalOutputOffset = 0;
-private$incrementalErrorOutputOffset = 0;
-private$tty = false;
-private$pty;
-private$options = ['suppress_errors' => true, 'bypass_shell' => true];
+privatestring$status = self::STATUS_READY;
+privateint$incrementalOutputOffset = 0;
+privateint$incrementalErrorOutputOffset = 0;
+privatebool$tty = false;
+privatebool$pty;
+privatearray$options = ['suppress_errors' => true, 'bypass_shell' => true];
 
-private$useFileHandles = false;
-/** @var PipesInterface */
-private$processPipes;
+privatebool$useFileHandles;
+privateWindowsPipes|UnixPipes$processPipes;
 
-private$latestSignal;
+private?int$latestSignal = null;
 
-privatestatic$sigchild;
+privatestatic?bool$sigchild = null;
 
 /**
  * Exit codes translation table.
@@ -303,7 +300,6 @@ public function start(callable $callback = null, array $env = [])
 $this->resetProcessData();
 $this->starttime = $this->lastOutputTime = microtime(true);
 $this->callback = $this->buildCallback($callback);
-$this->hasCallback = null !== $callback;
 $descriptors = $this->getDescriptors();
 
 if ($this->env) {
@@ -1245,9 +1241,9 @@ private function getDescriptors(): array
 $this->input->rewind();
  }
 if ('\\' === \DIRECTORY_SEPARATOR) {
-$this->processPipes = newWindowsPipes($this->input, !$this->outputDisabled || $this->hasCallback);
+$this->processPipes = newWindowsPipes($this->input, !$this->outputDisabled || $this->callback);
  } else {
-$this->processPipes = newUnixPipes($this->isTty(), $this->isPty(), $this->input, !$this->outputDisabled || $this->hasCallback);
+$this->processPipes = newUnixPipes($this->isTty(), $this->isPty(), $this->input, !$this->outputDisabled || $this->callback);
  }
 
 return$this->processPipes->getDescriptors();
@@ -1424,7 +1420,7 @@ private function resetProcessData(): void
 $this->callback = null;
 $this->exitcode = null;
 $this->fallbackStatus = [];
-$this->processInformation = null;
+$this->processInformation = [];
 $this->stdout = fopen('php://temp/maxmemory:'.(1024 * 1024), 'w+');
 $this->stderr = fopen('php://temp/maxmemory:'.(1024 * 1024), 'w+');
 $this->process = null;