Uh oh!
There was an error while loading. Please reload this page.
Fix #33 - #36
Closed
emberian wants to merge 2 commits into
Closed
Conversation
isaacs
commented
Jan 7, 2012
Member
Yes, can you please have it test against 0100, then 0010 if the gid matches and you can call process.getgid, then 1 if the uid matches and you can call process.getuid. The getuid/getgid functions will be missing if the system doesn't support it. Also, 2 space indent, not 4. Other than that, +1. |
emberian
commented
Jan 9, 2012
Author
I wish I could add more tests but I really can't, not with the way git preserves permissions. Perhaps a pretest hook of some sort that creates files with various permissions (or does git save /which/ executable bit is set?) |
emberian
commented
Jul 31, 2012
Author
Bump |
isaacs
commented
Jul 31, 2012
Member
Landed in master, thanks! |
isaacs
commented
Jul 31, 2012
Member
Landed in master, thanks! |
isaacs pushed a commit
that referenced
this pull request
Sep 1, 2023
Also drop the dev dependency rimraf in favor of fs.rm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tap-runner.js no longer tries to execute scripts if they don't have the executable bit set for anyone. Is kinda dirty as it doesn't check if the user can execute the file. I'll add that in if you want, I just don't have time right now.
Adds two tests, executed.sh and not-executed.sh. not-executed.sh will always fail, if it is run.