Fix #1985: embed no_kg fixture via include_str to survive worktree deletion by AlexMikhalev · Pull Request #890 · terraphim/terraphim-ai

AlexMikhalev · 2026-06-02T06:27:27Z

Summary

Root cause: validate_with_no_kg_exits_3 used concat!(env!("CARGO_MANIFEST_DIR"), "/tests/no_kg_config.json"), a compile-time path. When the shared target directory holds a binary compiled from a now-deleted worktree, the baked-in path does not exist at runtime — the test exits 1 (file not found) instead of 3 (KG not configured).
Fix: replace with include_str!("no_kg_config.json") to embed fixture bytes at compile time, written to a tempfile at runtime. Resilient to any worktree lifetime.

Test plan

cargo test -p terraphim_agent --test exit_codes — 11/11 pass
cargo fmt -p terraphim_agent -- --check — clean
cargo clippy -p terraphim_agent — clean

Refs terraphim/terraphim-ai#1985 (Gitea)

🤖 Generated with Claude Code

Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978

…rktree deletion The validate_with_no_kg_exits_3 test used concat!(env!("CARGO_MANIFEST_DIR"), ...) to construct a compile-time path to the fixture file. When the target directory is shared across worktrees, a binary compiled from a deleted worktree retains the old path, causing the test to fail with exit code 1 (file not found) instead of 3 (KG not configured). Fix: use include_str!() to embed the fixture content at compile time, then write it to a tempfile at runtime. This is resilient to worktree cleanup because the fixture bytes are embedded in the test binary itself. Refs #1985

AlexMikhalev · 2026-08-29T23:24:19Z

Closing as superseded. This PR is a Fix #1985: embed no_kg fixture... patch based on an older state of main. The substantive intent has been overtaken by the polyrepo fleet-batch + the recent rebase wave (17+ PRs merged 2026-08-28/29). A rebase would require resolving hundreds of conflicts against substantial refactors. Per the user instruction "fully functional and green," these stale PRs are being closed rather than re-rebased.

Closes per Shimaguru mass-rebase pass, 2026-08-29.

AlexMikhalev · 2026-06-02T06:27:27Z

Summary

Root cause: validate_with_no_kg_exits_3 used concat!(env!("CARGO_MANIFEST_DIR"), "/tests/no_kg_config.json"), a compile-time path. When the shared target directory holds a binary compiled from a now-deleted worktree, the baked-in path does not exist at runtime — the test exits 1 (file not found) instead of 3 (KG not configured).
Fix: replace with include_str!("no_kg_config.json") to embed fixture bytes at compile time, written to a tempfile at runtime. Resilient to any worktree lifetime.

Test plan

cargo test -p terraphim_agent --test exit_codes — 11/11 pass
cargo fmt -p terraphim_agent -- --check — clean
cargo clippy -p terraphim_agent — clean

Refs terraphim/terraphim-ai#1985 (Gitea)

🤖 Generated with Claude Code

Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978

…rktree deletion The validate_with_no_kg_exits_3 test used concat!(env!("CARGO_MANIFEST_DIR"), ...) to construct a compile-time path to the fixture file. When the target directory is shared across worktrees, a binary compiled from a deleted worktree retains the old path, causing the test to fail with exit code 1 (file not found) instead of 3 (KG not configured). Fix: use include_str!() to embed the fixture content at compile time, then write it to a tempfile at runtime. This is resilient to worktree cleanup because the fixture bytes are embedded in the test binary itself. Refs #1985

AlexMikhalev · 2026-08-29T23:24:19Z

Closing as superseded. This PR is a Fix #1985: embed no_kg fixture... patch based on an older state of main. The substantive intent has been overtaken by the polyrepo fleet-batch + the recent rebase wave (17+ PRs merged 2026-08-28/29). A rebase would require resolving hundreds of conflicts against substantial refactors. Per the user instruction "fully functional and green," these stale PRs are being closed rather than re-rebased.

Closes per Shimaguru mass-rebase pass, 2026-08-29.

AlexMikhalev · 2026-06-02T06:27:27Z

Summary

Root cause: validate_with_no_kg_exits_3 used concat!(env!("CARGO_MANIFEST_DIR"), "/tests/no_kg_config.json"), a compile-time path. When the shared target directory holds a binary compiled from a now-deleted worktree, the baked-in path does not exist at runtime — the test exits 1 (file not found) instead of 3 (KG not configured).
Fix: replace with include_str!("no_kg_config.json") to embed fixture bytes at compile time, written to a tempfile at runtime. Resilient to any worktree lifetime.

Test plan

cargo test -p terraphim_agent --test exit_codes — 11/11 pass
cargo fmt -p terraphim_agent -- --check — clean
cargo clippy -p terraphim_agent — clean

Refs terraphim/terraphim-ai#1985 (Gitea)

🤖 Generated with Claude Code

Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978

…rktree deletion The validate_with_no_kg_exits_3 test used concat!(env!("CARGO_MANIFEST_DIR"), ...) to construct a compile-time path to the fixture file. When the target directory is shared across worktrees, a binary compiled from a deleted worktree retains the old path, causing the test to fail with exit code 1 (file not found) instead of 3 (KG not configured). Fix: use include_str!() to embed the fixture content at compile time, then write it to a tempfile at runtime. This is resilient to worktree cleanup because the fixture bytes are embedded in the test binary itself. Refs #1985

AlexMikhalev · 2026-08-29T23:24:19Z

Closing as superseded. This PR is a Fix #1985: embed no_kg fixture... patch based on an older state of main. The substantive intent has been overtaken by the polyrepo fleet-batch + the recent rebase wave (17+ PRs merged 2026-08-28/29). A rebase would require resolving hundreds of conflicts against substantial refactors. Per the user instruction "fully functional and green," these stale PRs are being closed rather than re-rebased.

Closes per Shimaguru mass-rebase pass, 2026-08-29.

AlexMikhalev · 2026-06-02T06:27:27Z

Summary

Root cause: validate_with_no_kg_exits_3 used concat!(env!("CARGO_MANIFEST_DIR"), "/tests/no_kg_config.json"), a compile-time path. When the shared target directory holds a binary compiled from a now-deleted worktree, the baked-in path does not exist at runtime — the test exits 1 (file not found) instead of 3 (KG not configured).
Fix: replace with include_str!("no_kg_config.json") to embed fixture bytes at compile time, written to a tempfile at runtime. Resilient to any worktree lifetime.

Test plan

cargo test -p terraphim_agent --test exit_codes — 11/11 pass
cargo fmt -p terraphim_agent -- --check — clean
cargo clippy -p terraphim_agent — clean

Refs terraphim/terraphim-ai#1985 (Gitea)

🤖 Generated with Claude Code

Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978

…rktree deletion The validate_with_no_kg_exits_3 test used concat!(env!("CARGO_MANIFEST_DIR"), ...) to construct a compile-time path to the fixture file. When the target directory is shared across worktrees, a binary compiled from a deleted worktree retains the old path, causing the test to fail with exit code 1 (file not found) instead of 3 (KG not configured). Fix: use include_str!() to embed the fixture content at compile time, then write it to a tempfile at runtime. This is resilient to worktree cleanup because the fixture bytes are embedded in the test binary itself. Refs #1985

AlexMikhalev · 2026-08-29T23:24:19Z

Closing as superseded. This PR is a Fix #1985: embed no_kg fixture... patch based on an older state of main. The substantive intent has been overtaken by the polyrepo fleet-batch + the recent rebase wave (17+ PRs merged 2026-08-28/29). A rebase would require resolving hundreds of conflicts against substantial refactors. Per the user instruction "fully functional and green," these stale PRs are being closed rather than re-rebased.

Closes per Shimaguru mass-rebase pass, 2026-08-29.

AlexMikhalev · 2026-06-02T06:27:27Z

Summary

Root cause: validate_with_no_kg_exits_3 used concat!(env!("CARGO_MANIFEST_DIR"), "/tests/no_kg_config.json"), a compile-time path. When the shared target directory holds a binary compiled from a now-deleted worktree, the baked-in path does not exist at runtime — the test exits 1 (file not found) instead of 3 (KG not configured).
Fix: replace with include_str!("no_kg_config.json") to embed fixture bytes at compile time, written to a tempfile at runtime. Resilient to any worktree lifetime.

Test plan

cargo test -p terraphim_agent --test exit_codes — 11/11 pass
cargo fmt -p terraphim_agent -- --check — clean
cargo clippy -p terraphim_agent — clean

Refs terraphim/terraphim-ai#1985 (Gitea)

🤖 Generated with Claude Code

Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978

…rktree deletion The validate_with_no_kg_exits_3 test used concat!(env!("CARGO_MANIFEST_DIR"), ...) to construct a compile-time path to the fixture file. When the target directory is shared across worktrees, a binary compiled from a deleted worktree retains the old path, causing the test to fail with exit code 1 (file not found) instead of 3 (KG not configured). Fix: use include_str!() to embed the fixture content at compile time, then write it to a tempfile at runtime. This is resilient to worktree cleanup because the fixture bytes are embedded in the test binary itself. Refs #1985

AlexMikhalev · 2026-08-29T23:24:19Z

Closing as superseded. This PR is a Fix #1985: embed no_kg fixture... patch based on an older state of main. The substantive intent has been overtaken by the polyrepo fleet-batch + the recent rebase wave (17+ PRs merged 2026-08-28/29). A rebase would require resolving hundreds of conflicts against substantial refactors. Per the user instruction "fully functional and green," these stale PRs are being closed rather than re-rebased.

Closes per Shimaguru mass-rebase pass, 2026-08-29.

AlexMikhalev · 2026-06-02T06:27:27Z

Summary

Root cause: validate_with_no_kg_exits_3 used concat!(env!("CARGO_MANIFEST_DIR"), "/tests/no_kg_config.json"), a compile-time path. When the shared target directory holds a binary compiled from a now-deleted worktree, the baked-in path does not exist at runtime — the test exits 1 (file not found) instead of 3 (KG not configured).
Fix: replace with include_str!("no_kg_config.json") to embed fixture bytes at compile time, written to a tempfile at runtime. Resilient to any worktree lifetime.

Test plan

cargo test -p terraphim_agent --test exit_codes — 11/11 pass
cargo fmt -p terraphim_agent -- --check — clean
cargo clippy -p terraphim_agent — clean

Refs terraphim/terraphim-ai#1985 (Gitea)

🤖 Generated with Claude Code

Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978

…rktree deletion The validate_with_no_kg_exits_3 test used concat!(env!("CARGO_MANIFEST_DIR"), ...) to construct a compile-time path to the fixture file. When the target directory is shared across worktrees, a binary compiled from a deleted worktree retains the old path, causing the test to fail with exit code 1 (file not found) instead of 3 (KG not configured). Fix: use include_str!() to embed the fixture content at compile time, then write it to a tempfile at runtime. This is resilient to worktree cleanup because the fixture bytes are embedded in the test binary itself. Refs #1985

AlexMikhalev · 2026-08-29T23:24:19Z

Closing as superseded. This PR is a Fix #1985: embed no_kg fixture... patch based on an older state of main. The substantive intent has been overtaken by the polyrepo fleet-batch + the recent rebase wave (17+ PRs merged 2026-08-28/29). A rebase would require resolving hundreds of conflicts against substantial refactors. Per the user instruction "fully functional and green," these stale PRs are being closed rather than re-rebased.

Closes per Shimaguru mass-rebase pass, 2026-08-29.

AlexMikhalev · 2026-06-02T06:27:27Z

Summary

Root cause: validate_with_no_kg_exits_3 used concat!(env!("CARGO_MANIFEST_DIR"), "/tests/no_kg_config.json"), a compile-time path. When the shared target directory holds a binary compiled from a now-deleted worktree, the baked-in path does not exist at runtime — the test exits 1 (file not found) instead of 3 (KG not configured).
Fix: replace with include_str!("no_kg_config.json") to embed fixture bytes at compile time, written to a tempfile at runtime. Resilient to any worktree lifetime.

Test plan

cargo test -p terraphim_agent --test exit_codes — 11/11 pass
cargo fmt -p terraphim_agent -- --check — clean
cargo clippy -p terraphim_agent — clean

Refs terraphim/terraphim-ai#1985 (Gitea)

🤖 Generated with Claude Code

Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978

…rktree deletion The validate_with_no_kg_exits_3 test used concat!(env!("CARGO_MANIFEST_DIR"), ...) to construct a compile-time path to the fixture file. When the target directory is shared across worktrees, a binary compiled from a deleted worktree retains the old path, causing the test to fail with exit code 1 (file not found) instead of 3 (KG not configured). Fix: use include_str!() to embed the fixture content at compile time, then write it to a tempfile at runtime. This is resilient to worktree cleanup because the fixture bytes are embedded in the test binary itself. Refs #1985

AlexMikhalev · 2026-08-29T23:24:19Z

Closing as superseded. This PR is a Fix #1985: embed no_kg fixture... patch based on an older state of main. The substantive intent has been overtaken by the polyrepo fleet-batch + the recent rebase wave (17+ PRs merged 2026-08-28/29). A rebase would require resolving hundreds of conflicts against substantial refactors. Per the user instruction "fully functional and green," these stale PRs are being closed rather than re-rebased.

Closes per Shimaguru mass-rebase pass, 2026-08-29.

AlexMikhalev · 2026-06-02T06:27:27Z

Summary

Root cause: validate_with_no_kg_exits_3 used concat!(env!("CARGO_MANIFEST_DIR"), "/tests/no_kg_config.json"), a compile-time path. When the shared target directory holds a binary compiled from a now-deleted worktree, the baked-in path does not exist at runtime — the test exits 1 (file not found) instead of 3 (KG not configured).
Fix: replace with include_str!("no_kg_config.json") to embed fixture bytes at compile time, written to a tempfile at runtime. Resilient to any worktree lifetime.

Test plan

cargo test -p terraphim_agent --test exit_codes — 11/11 pass
cargo fmt -p terraphim_agent -- --check — clean
cargo clippy -p terraphim_agent — clean

Refs terraphim/terraphim-ai#1985 (Gitea)

🤖 Generated with Claude Code

Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978

…rktree deletion The validate_with_no_kg_exits_3 test used concat!(env!("CARGO_MANIFEST_DIR"), ...) to construct a compile-time path to the fixture file. When the target directory is shared across worktrees, a binary compiled from a deleted worktree retains the old path, causing the test to fail with exit code 1 (file not found) instead of 3 (KG not configured). Fix: use include_str!() to embed the fixture content at compile time, then write it to a tempfile at runtime. This is resilient to worktree cleanup because the fixture bytes are embedded in the test binary itself. Refs #1985

AlexMikhalev · 2026-08-29T23:24:19Z

Closing as superseded. This PR is a Fix #1985: embed no_kg fixture... patch based on an older state of main. The substantive intent has been overtaken by the polyrepo fleet-batch + the recent rebase wave (17+ PRs merged 2026-08-28/29). A rebase would require resolving hundreds of conflicts against substantial refactors. Per the user instruction "fully functional and green," these stale PRs are being closed rather than re-rebased.

Closes per Shimaguru mass-rebase pass, 2026-08-29.

Test User added 3 commits June 2, 2026 04:57

fix: cargo fmt failure in terraphim_orchestrator (src/lib.rs)
28e7646
Reformat active_compound_review field type and two reconcile_tick tracing macros to satisfy cargo fmt --check. The fmt gate was RED on main, blocking the merge pipeline (WIG-4). Refs #1978