Skip to content

fix(core): Typing in version - #701

Merged
alexanderankin merged 1 commit into
testcontainers:mainfrom
Tranquility2:typed_version
May 4, 2025
Merged

fix(core): Typing in version#701
alexanderankin merged 1 commit into
testcontainers:mainfrom
Tranquility2:typed_version

Conversation

@Tranquility2

@Tranquility2Tranquility2 commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

Supports: #305
Related : #691#692#700

poetry run mypy --config-file pyproject.toml core/testcontainers/core/version.py Success: no issues found in 1 source file

Old

 Error Summary ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┓
┃ File Path ┃ Errors ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━┩
│ core/testcontainers/core/version.py │ 12 │
│ core/testcontainers/core/docker_client.py │ 14 │
│ core/testcontainers/core/image.py │ 17 │
│ core/testcontainers/core/waiting_utils.py │ 8 │
│ core/testcontainers/core/container.py │ 20 │
│ core/tests/test_new_docker_api.py │ 4 │
│ core/tests/test_docker_in_docker.py │ 2 │
│ core/testcontainers/compose/compose.py │ 22 │
│ core/testcontainers/compose/__init__.py │ 2 │
│ core/tests/test_version.py │ 2 │
│ core/tests/test_ryuk.py │ 2 │
│ core/tests/test_registry.py │ 1 │
│ core/tests/test_image.py │ 3 │
│ core/tests/test_compose.py │ 7 │
└───────────────────────────────────────────┴────────┘
Found 116 errors in 14 files.

New

 Error Summary ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┓
┃ File Path ┃ Errors ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━┩
│ core/testcontainers/core/docker_client.py │ 14 │
│ core/testcontainers/core/image.py │ 17 │
│ core/testcontainers/core/waiting_utils.py │ 8 │
│ core/testcontainers/core/container.py │ 20 │
│ core/tests/test_new_docker_api.py │ 4 │
│ core/tests/test_docker_in_docker.py │ 2 │
│ core/testcontainers/compose/compose.py │ 22 │
│ core/testcontainers/compose/__init__.py │ 2 │
│ core/tests/test_ryuk.py │ 2 │
│ core/tests/test_registry.py │ 1 │
│ core/tests/test_image.py │ 3 │
│ core/tests/test_compose.py │ 7 │
└───────────────────────────────────────────┴────────┘
Found 102 errors in 12 files.

@codecov

codecovBot commented Sep 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e9e40f9). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@## main #701 +/- ##
=======================================
Coverage ? 85.54% =======================================
Files ? 12 Lines ? 678 Branches ? 106 =======================================
Hits ? 580 Misses ? 75 Partials ? 23 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tranquility2Tranquility2 changed the title fix(core): Typing in versionfix(core): Typed versionSep 16, 2024
@Tranquility2Tranquility2 changed the title fix(core): Typed versionfix(core): Typing in versionSep 16, 2024
@alexanderankin
alexanderankin merged commit 9dc2a02 into testcontainers:mainMay 4, 2025
alexanderankin pushed a commit that referenced this pull request Jun 16, 2025
🤖 I have created a release *beep* *boop*
---
##
[4.11.0](testcontainers-v4.10.0...testcontainers-v4.11.0)
(2025-06-15)
### Features
* **core:** Protocol support for container port bind and expose
([#690](#690))
([a0d4317](a0d4317))
* DockerContainer initializer to accept its private members as kwargs
([#809](#809))
([e7feb53](e7feb53))
### Bug Fixes
* **compose:** use provided docker command instead of default
([#785](#785))
([0ae704a](0ae704a))
* **core:** Add kwargs to image build
([#708](#708))
([cc02f94](cc02f94))
* **core:** change with_command type to include list of strings
([#789](#789))
([f7c29cb](f7c29cb))
* **core:** Determine docker socket for rootless docker
([#779](#779))
([6817582](6817582))
* **core:** Typing in docker_client
([#702](#702))
([e8bf224](e8bf224))
* **core:** Typing in generic + network
([#700](#700))
([2061912](2061912))
* **core:** Typing in version
([#701](#701))
([9dc2a02](9dc2a02))
* **core:** wait in test core registry
([#812](#812))
([b574c0e](b574c0e))
* **modules:** fix cosmosdb failure
([#827](#827))
([dafcbed](dafcbed))
* **modules:** update chroma version
([#826](#826))
([b7d41dd](b7d41dd))
* **rabbitmq:** correct pika pypi reference
([#817](#817))
([e90d308](e90d308))
* **registry:** module typed
([#811](#811))
([6b11268](6b11268))
* use connection mode override function in config
([#775](#775))
([ab2a1ab](ab2a1ab)),
closes
[#774](#774)
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Tranquility2@alexanderankin