Skip to content

feat(valkey): add Valkey module - #947

Merged
alexanderankin merged 8 commits into
testcontainers:mainfrom
daric93:valkey_test_container
Apr 9, 2026
Merged

feat(valkey): add Valkey module#947
alexanderankin merged 8 commits into
testcontainers:mainfrom
daric93:valkey_test_container

Conversation

@daric93

@daric93daric93 commented Jan 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

I’d like to add Valkey, the open-source fork of Redis, as a dedicated Testcontainers module.

@daric93

daric93 commented Feb 9, 2026

Copy link
Copy Markdown
ContributorAuthor

Hi @alexanderankin, I opened this PR to add Valkey test container as mentioned in this ticket. Would appreciate a review when you have a moment. Thanks!

@Tranquility2Tranquility2 changed the title Valkey Test Containerfeat(valkey): add Valkey moduleApr 3, 2026
@codecov

codecovBot commented Apr 3, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.05%. Comparing base (6ecf347) to head (2108a20).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #947 +/- ##
=======================================
Coverage 83.05% 83.05% =======================================
Files 16 16 Lines 1700 1700 Branches 186 186 =======================================
Hits 1412 1412 Misses 234 234 Partials 54 54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tranquility2Tranquility2 linked an issue Apr 3, 2026 that may be closed by this pull request
New Container: TestContainer for Valkey #936
Closed
@Tranquility2Tranquility2 added 🛠️ needs more work Need to invest more time, can be a rebase or code updates and removed ✨ feat labels Apr 3, 2026
@daric93
valkey test container
3ec8609
@daric93
address comments
4b73002
@daric93
address code review issues
21ec9f8
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
@daric93
daric93force-pushed the valkey_test_container branch from 4c8007b to 21ec9f8CompareApril 7, 2026 19:52
@daric93
fix formatting in valkey module
a0cd2a0
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
@daric93

daric93 commented Apr 7, 2026

Copy link
Copy Markdown
ContributorAuthor

@Tranquility2, please take another look when you have a chance: rebased onto latest main, addressed auto code review feedback, fixed CI issues.

@Tranquility2Tranquility2 removed the 🛠️ needs more work Need to invest more time, can be a rebase or code updates label Apr 8, 2026
@daric93
address ci failures
8a895cf
Signed-off-by: Daria Korenieva <daric2612@gmail.com>
@daric93
Merge branch 'valkey_test_container' of github.com:daric93/testcontai…
570c6cf
…ners-python into valkey_test_container
@daric93
update uv.lock for version 4.15.0-rc.1
2108a20
@daric93

daric93 commented Apr 8, 2026

Copy link
Copy Markdown
ContributorAuthor

@Tranquility2, please take another look when you have a chance: fixed ci failures

alexanderankin
alexanderankin reviewed Apr 9, 2026
View reviewed changes
Comment threadmodules/valkey/testcontainers/valkey/__init__.py
self.waiting_for(ExecWaitStrategy(["valkey-cli", "-a", password, "ping"]))
return self

def with_image_tag(self, tag: str) -> "ValkeyContainer":

@alexanderankinalexanderankinApr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if this code gets merged now, which im inclined to do to just clear the backlog, this will not survive into v5 which i want to do asap. this is a method that belongs on the docker image datastructure not on container (or even base container)

@alexanderankin
alexanderankin merged commit fc09dc1 into testcontainers:mainApr 9, 2026
12 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Apr 9, 2026
Merged
alexanderankin added a commit that referenced this pull request Apr 30, 2026
@github-actions@alexanderankin
chore(main): release testcontainers 4.15.0-rc2 (#1004)
79d920e
🤖 I have created a release *beep* *boop*
---
##
[4.15.0-rc2](testcontainers-v4.15.0-rc.1...testcontainers-v4.15.0-rc2)
(2026-04-30)
### Features
* **core:** support TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX
([#961](#961))
([be9a0a6](be9a0a6))
* **mongodb:** Add Atlas Local for MongoDb
([#873](#873))
([73aeb43](73aeb43))
* support with_copy_to
([#976](#976))
([59ec1ce](59ec1ce))
* **valkey:** add Valkey module
([#947](#947))
([fc09dc1](fc09dc1))
### Bug Fixes
* **azurite:** use `HttpWaitStrategy` instead of deprecated
`wait_container_is_ready`
([#1003](#1003))
([9fe6b07](9fe6b07)),
closes
[#874](#874)
* fix pr
[#961](#961)
([#1011](#1011))
([8eff908](8eff908))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: David Ankin <daveankin@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexanderankinalexanderankinalexanderankin approved these changes

Assignees

No one assigned

Labels

✨ package: new

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New Container: TestContainer for Valkey

3 participants

@daric93@alexanderankin@Tranquility2