Uh oh!
There was an error while loading. Please reload this page.
feat(keycloak): support for relative path and management relative path - #982
Merged
Tranquility2 merged 3 commits intoApr 1, 2026
Merged
Conversation
When these parameters were set, the functions get_url() and get_management_url() did return the wrong URLs (without the prefix) Now the implementation checks if the parameter is checked and adds it to the returned URL
JotBePunkt
commented
Mar 18, 2026
ContributorAuthor
@alexanderankin it would be great, if this change is in one of the next releases. What do we need to do to have this PR merged? |
alexanderankin
commented
Mar 18, 2026
Member
i started rebasing a bigger PR yesterday, working through merging all the things |
themavik
left a comment
There was a problem hiding this comment.
Reviewed the changes — the Keycloak relative path support aligns with the container configuration. The management relative path addition provides flexibility for different deployment setups.
alexanderankin
approved these changes
Apr 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #982 +/- ##
=======================================
Coverage 79.54% 79.54% =======================================
Files 15 15 Lines 1281 1281 Branches 151 151 =======================================
Hits 1019 1019 Misses 218 218 Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
alexanderankin added a commit
that referenced
this pull request
Apr 7, 2026
🤖 I have created a release *beep* *boop* --- ## [4.15.0-rc.1](testcontainers-v4.14.2...testcontainers-v4.15.0-rc.1) (2026-04-07) ### Features * **compose:** add structured container inspect information ([#897](#897)) ([58459a1](58459a1)) * **core:** support SSH-based DOCKER_HOST ([#993](#993)) ([d48115d](d48115d)) * **generic:** Reintroducing the generic SQL module ([#892](#892)) ([2ca2321](2ca2321)) * **keycloak:** support for relative path and management relative path ([#982](#982)) ([898faf6](898faf6)) * **mqtt:** MosquittoContainer: Add version 2.1.2 ([#978](#978)) ([af382f7](af382f7)) ### Bug Fixes * **azurite:** make visible to type checkers ([#927](#927)) ([baa5668](baa5668)) * **clickhouse:** add `HttpWaitStrategy` instead of deprecated `wait_container_is_ready` ([#962](#962)) ([8034541](8034541)) * **compose:** return type in get_service_port docstring ([#939](#939)) ([fed65fe](fed65fe)) * **core:** Refactor copy file ([#996](#996)) ([0e0bb24](0e0bb24)) * **core:** wait for ryuk more reliably, improve tests: long_running, filter logs ([#984](#984)) ([b12ae13](b12ae13)) * **generic:** Migrate ServerContainer from deprecated decorator to HttpWaitStrategy ([#971](#971)) ([460b0d8](460b0d8)) * **kafka:** Use wait strategy instead of deprecated wait_for_logs ([#903](#903)) ([87332c1](87332c1)) * **postgres:** add py.typed marker to postgres module ([#849](#849)) ([c8a5bbd](c8a5bbd)) * **qdrant:** migrate Qdrant from deprecated decorator. ([#963](#963)) ([407f798](407f798)) * **redis:** Use wait strategy instead of deprecated decorator ([#914](#914)) ([e25713a](e25713a)) * **sftp:** Avoid using wait_for_logs in module. ([#995](#995)) ([83157eb](83157eb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: David Ankin <daveankin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When these parameters were set, the functions get_url() and get_management_url() did return the wrong URLs (without the prefix)
Now the implementation checks if the parameter is checked and adds it to the returned URL
This solves #964