♻ Refactor internal statements to simplify code by yezz123 · Pull Request #53 · fastapi/sqlmodel

yezz123 · 2021-08-28T15:44:03Z

Merges multiply nested if conditions into one in this Function SQLModel.__setattr__

Reading deeply nested code is confusing since you have to keep track of which conditions relate to which levels. We, therefore, strive to reduce nesting where possible, and the situation where two if conditions can be combined using and is an easy win.

Replaces conditional assignment to a variable with an if expression in this Function SQLModel.from_orm

Once the change is made there's only one statement where x is defined as opposed to having to read two statements plus the if-else lines.

Removes unnecessarily verbose boolean comparisons in this Function SQLModel._calculate_keys

It is unnecessary to compare boolean values to True or False in the test of an if condition. Removing these unnecessary checks makes the code slightly shorter and easier to parse.

Hoist repeated code outside conditional statement and Swap if/else to remove empty if body in this Function GUID.process_result_value

By taking the assignment outside of the conditional we have removed a duplicate line of code, and made it clearer what the conditional is actually controlling.

Chore: Merges multiple nested if conditions into one

tiangolo

Thanks for the interest! I have some comments, all this is mainly about taste. 🤷 😅

codecov · 2022-08-27T21:34:16Z

Codecov Report

Merging #53 (0c054ab) into main (7d3bf70) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #53 +/- ##
==========================================
- Coverage 97.58% 97.58% -0.01% 
==========================================
Files 182 182 Lines 6054 6053 -1 ==========================================
- Hits 5908 5907 -1 
Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/main.py	`83.58% <100.00%> (-0.05%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T21:34:51Z

📝 Docs preview for commit 2a91647 at: https://630a8dd6fbefa94700c71038--sqlmodel.netlify.app

yezz123 · 2022-08-27T21:46:43Z

Hello @tiangolo all the changes you asked for are done 🍰

github-actions · 2022-08-27T21:48:12Z

📝 Docs preview for commit 0c054ab at: https://630a90e8801d6f48588c8617--sqlmodel.netlify.app

tiangolo · 2022-08-27T23:52:55Z

Awesome, thanks @yezz123! 🍰

yezz123 · 2021-08-28T15:44:03Z

Merges multiply nested if conditions into one in this Function SQLModel.__setattr__

Reading deeply nested code is confusing since you have to keep track of which conditions relate to which levels. We, therefore, strive to reduce nesting where possible, and the situation where two if conditions can be combined using and is an easy win.

Replaces conditional assignment to a variable with an if expression in this Function SQLModel.from_orm

Once the change is made there's only one statement where x is defined as opposed to having to read two statements plus the if-else lines.

Removes unnecessarily verbose boolean comparisons in this Function SQLModel._calculate_keys

It is unnecessary to compare boolean values to True or False in the test of an if condition. Removing these unnecessary checks makes the code slightly shorter and easier to parse.

Hoist repeated code outside conditional statement and Swap if/else to remove empty if body in this Function GUID.process_result_value

By taking the assignment outside of the conditional we have removed a duplicate line of code, and made it clearer what the conditional is actually controlling.

Chore: Merges multiple nested if conditions into one

tiangolo

Thanks for the interest! I have some comments, all this is mainly about taste. 🤷 😅

codecov · 2022-08-27T21:34:16Z

Codecov Report

Merging #53 (0c054ab) into main (7d3bf70) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #53 +/- ##
==========================================
- Coverage 97.58% 97.58% -0.01% 
==========================================
Files 182 182 Lines 6054 6053 -1 ==========================================
- Hits 5908 5907 -1 
Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/main.py	`83.58% <100.00%> (-0.05%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T21:34:51Z

📝 Docs preview for commit 2a91647 at: https://630a8dd6fbefa94700c71038--sqlmodel.netlify.app

yezz123 · 2022-08-27T21:46:43Z

Hello @tiangolo all the changes you asked for are done 🍰

github-actions · 2022-08-27T21:48:12Z

📝 Docs preview for commit 0c054ab at: https://630a90e8801d6f48588c8617--sqlmodel.netlify.app

tiangolo · 2022-08-27T23:52:55Z

Awesome, thanks @yezz123! 🍰

yezz123 · 2021-08-28T15:44:03Z

Merges multiply nested if conditions into one in this Function SQLModel.__setattr__

Reading deeply nested code is confusing since you have to keep track of which conditions relate to which levels. We, therefore, strive to reduce nesting where possible, and the situation where two if conditions can be combined using and is an easy win.

Replaces conditional assignment to a variable with an if expression in this Function SQLModel.from_orm

Once the change is made there's only one statement where x is defined as opposed to having to read two statements plus the if-else lines.

Removes unnecessarily verbose boolean comparisons in this Function SQLModel._calculate_keys

It is unnecessary to compare boolean values to True or False in the test of an if condition. Removing these unnecessary checks makes the code slightly shorter and easier to parse.

Hoist repeated code outside conditional statement and Swap if/else to remove empty if body in this Function GUID.process_result_value

By taking the assignment outside of the conditional we have removed a duplicate line of code, and made it clearer what the conditional is actually controlling.

Chore: Merges multiple nested if conditions into one

tiangolo

Thanks for the interest! I have some comments, all this is mainly about taste. 🤷 😅

codecov · 2022-08-27T21:34:16Z

Codecov Report

Merging #53 (0c054ab) into main (7d3bf70) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #53 +/- ##
==========================================
- Coverage 97.58% 97.58% -0.01% 
==========================================
Files 182 182 Lines 6054 6053 -1 ==========================================
- Hits 5908 5907 -1 
Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/main.py	`83.58% <100.00%> (-0.05%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T21:34:51Z

📝 Docs preview for commit 2a91647 at: https://630a8dd6fbefa94700c71038--sqlmodel.netlify.app

yezz123 · 2022-08-27T21:46:43Z

Hello @tiangolo all the changes you asked for are done 🍰

github-actions · 2022-08-27T21:48:12Z

📝 Docs preview for commit 0c054ab at: https://630a90e8801d6f48588c8617--sqlmodel.netlify.app

tiangolo · 2022-08-27T23:52:55Z

Awesome, thanks @yezz123! 🍰

yezz123 · 2021-08-28T15:44:03Z

Merges multiply nested if conditions into one in this Function SQLModel.__setattr__

Reading deeply nested code is confusing since you have to keep track of which conditions relate to which levels. We, therefore, strive to reduce nesting where possible, and the situation where two if conditions can be combined using and is an easy win.

Replaces conditional assignment to a variable with an if expression in this Function SQLModel.from_orm

Once the change is made there's only one statement where x is defined as opposed to having to read two statements plus the if-else lines.

Removes unnecessarily verbose boolean comparisons in this Function SQLModel._calculate_keys

It is unnecessary to compare boolean values to True or False in the test of an if condition. Removing these unnecessary checks makes the code slightly shorter and easier to parse.

Hoist repeated code outside conditional statement and Swap if/else to remove empty if body in this Function GUID.process_result_value

By taking the assignment outside of the conditional we have removed a duplicate line of code, and made it clearer what the conditional is actually controlling.

Chore: Merges multiple nested if conditions into one

tiangolo

Thanks for the interest! I have some comments, all this is mainly about taste. 🤷 😅

codecov · 2022-08-27T21:34:16Z

Codecov Report

Merging #53 (0c054ab) into main (7d3bf70) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #53 +/- ##
==========================================
- Coverage 97.58% 97.58% -0.01% 
==========================================
Files 182 182 Lines 6054 6053 -1 ==========================================
- Hits 5908 5907 -1 
Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/main.py	`83.58% <100.00%> (-0.05%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T21:34:51Z

📝 Docs preview for commit 2a91647 at: https://630a8dd6fbefa94700c71038--sqlmodel.netlify.app

yezz123 · 2022-08-27T21:46:43Z

Hello @tiangolo all the changes you asked for are done 🍰

github-actions · 2022-08-27T21:48:12Z

📝 Docs preview for commit 0c054ab at: https://630a90e8801d6f48588c8617--sqlmodel.netlify.app

tiangolo · 2022-08-27T23:52:55Z

Awesome, thanks @yezz123! 🍰

yezz123 · 2021-08-28T15:44:03Z

Merges multiply nested if conditions into one in this Function SQLModel.__setattr__

Reading deeply nested code is confusing since you have to keep track of which conditions relate to which levels. We, therefore, strive to reduce nesting where possible, and the situation where two if conditions can be combined using and is an easy win.

Replaces conditional assignment to a variable with an if expression in this Function SQLModel.from_orm

Once the change is made there's only one statement where x is defined as opposed to having to read two statements plus the if-else lines.

Removes unnecessarily verbose boolean comparisons in this Function SQLModel._calculate_keys

It is unnecessary to compare boolean values to True or False in the test of an if condition. Removing these unnecessary checks makes the code slightly shorter and easier to parse.

Hoist repeated code outside conditional statement and Swap if/else to remove empty if body in this Function GUID.process_result_value

By taking the assignment outside of the conditional we have removed a duplicate line of code, and made it clearer what the conditional is actually controlling.

Chore: Merges multiple nested if conditions into one

tiangolo

Thanks for the interest! I have some comments, all this is mainly about taste. 🤷 😅

codecov · 2022-08-27T21:34:16Z

Codecov Report

Merging #53 (0c054ab) into main (7d3bf70) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #53 +/- ##
==========================================
- Coverage 97.58% 97.58% -0.01% 
==========================================
Files 182 182 Lines 6054 6053 -1 ==========================================
- Hits 5908 5907 -1 
Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/main.py	`83.58% <100.00%> (-0.05%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T21:34:51Z

📝 Docs preview for commit 2a91647 at: https://630a8dd6fbefa94700c71038--sqlmodel.netlify.app

yezz123 · 2022-08-27T21:46:43Z

Hello @tiangolo all the changes you asked for are done 🍰

github-actions · 2022-08-27T21:48:12Z

📝 Docs preview for commit 0c054ab at: https://630a90e8801d6f48588c8617--sqlmodel.netlify.app

tiangolo · 2022-08-27T23:52:55Z

Awesome, thanks @yezz123! 🍰

yezz123 · 2021-08-28T15:44:03Z

Merges multiply nested if conditions into one in this Function SQLModel.__setattr__

Reading deeply nested code is confusing since you have to keep track of which conditions relate to which levels. We, therefore, strive to reduce nesting where possible, and the situation where two if conditions can be combined using and is an easy win.

Replaces conditional assignment to a variable with an if expression in this Function SQLModel.from_orm

Once the change is made there's only one statement where x is defined as opposed to having to read two statements plus the if-else lines.

Removes unnecessarily verbose boolean comparisons in this Function SQLModel._calculate_keys

It is unnecessary to compare boolean values to True or False in the test of an if condition. Removing these unnecessary checks makes the code slightly shorter and easier to parse.

Hoist repeated code outside conditional statement and Swap if/else to remove empty if body in this Function GUID.process_result_value

By taking the assignment outside of the conditional we have removed a duplicate line of code, and made it clearer what the conditional is actually controlling.

Chore: Merges multiple nested if conditions into one

tiangolo

Thanks for the interest! I have some comments, all this is mainly about taste. 🤷 😅

codecov · 2022-08-27T21:34:16Z

Codecov Report

Merging #53 (0c054ab) into main (7d3bf70) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #53 +/- ##
==========================================
- Coverage 97.58% 97.58% -0.01% 
==========================================
Files 182 182 Lines 6054 6053 -1 ==========================================
- Hits 5908 5907 -1 
Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/main.py	`83.58% <100.00%> (-0.05%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T21:34:51Z

📝 Docs preview for commit 2a91647 at: https://630a8dd6fbefa94700c71038--sqlmodel.netlify.app

yezz123 · 2022-08-27T21:46:43Z

Hello @tiangolo all the changes you asked for are done 🍰

github-actions · 2022-08-27T21:48:12Z

📝 Docs preview for commit 0c054ab at: https://630a90e8801d6f48588c8617--sqlmodel.netlify.app

tiangolo · 2022-08-27T23:52:55Z

Awesome, thanks @yezz123! 🍰

yezz123 · 2021-08-28T15:44:03Z

Merges multiply nested if conditions into one in this Function SQLModel.__setattr__

Reading deeply nested code is confusing since you have to keep track of which conditions relate to which levels. We, therefore, strive to reduce nesting where possible, and the situation where two if conditions can be combined using and is an easy win.

Replaces conditional assignment to a variable with an if expression in this Function SQLModel.from_orm

Once the change is made there's only one statement where x is defined as opposed to having to read two statements plus the if-else lines.

Removes unnecessarily verbose boolean comparisons in this Function SQLModel._calculate_keys

It is unnecessary to compare boolean values to True or False in the test of an if condition. Removing these unnecessary checks makes the code slightly shorter and easier to parse.

Hoist repeated code outside conditional statement and Swap if/else to remove empty if body in this Function GUID.process_result_value

By taking the assignment outside of the conditional we have removed a duplicate line of code, and made it clearer what the conditional is actually controlling.

Chore: Merges multiple nested if conditions into one

tiangolo

Thanks for the interest! I have some comments, all this is mainly about taste. 🤷 😅

codecov · 2022-08-27T21:34:16Z

Codecov Report

Merging #53 (0c054ab) into main (7d3bf70) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #53 +/- ##
==========================================
- Coverage 97.58% 97.58% -0.01% 
==========================================
Files 182 182 Lines 6054 6053 -1 ==========================================
- Hits 5908 5907 -1 
Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/main.py	`83.58% <100.00%> (-0.05%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T21:34:51Z

📝 Docs preview for commit 2a91647 at: https://630a8dd6fbefa94700c71038--sqlmodel.netlify.app

yezz123 · 2022-08-27T21:46:43Z

Hello @tiangolo all the changes you asked for are done 🍰

github-actions · 2022-08-27T21:48:12Z

📝 Docs preview for commit 0c054ab at: https://630a90e8801d6f48588c8617--sqlmodel.netlify.app

tiangolo · 2022-08-27T23:52:55Z

Awesome, thanks @yezz123! 🍰

yezz123 · 2021-08-28T15:44:03Z

Merges multiply nested if conditions into one in this Function SQLModel.__setattr__

Reading deeply nested code is confusing since you have to keep track of which conditions relate to which levels. We, therefore, strive to reduce nesting where possible, and the situation where two if conditions can be combined using and is an easy win.

Replaces conditional assignment to a variable with an if expression in this Function SQLModel.from_orm

Once the change is made there's only one statement where x is defined as opposed to having to read two statements plus the if-else lines.

Removes unnecessarily verbose boolean comparisons in this Function SQLModel._calculate_keys

It is unnecessary to compare boolean values to True or False in the test of an if condition. Removing these unnecessary checks makes the code slightly shorter and easier to parse.

Hoist repeated code outside conditional statement and Swap if/else to remove empty if body in this Function GUID.process_result_value

By taking the assignment outside of the conditional we have removed a duplicate line of code, and made it clearer what the conditional is actually controlling.

Chore: Merges multiple nested if conditions into one

tiangolo

Thanks for the interest! I have some comments, all this is mainly about taste. 🤷 😅

codecov · 2022-08-27T21:34:16Z

Codecov Report

Merging #53 (0c054ab) into main (7d3bf70) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #53 +/- ##
==========================================
- Coverage 97.58% 97.58% -0.01% 
==========================================
Files 182 182 Lines 6054 6053 -1 ==========================================
- Hits 5908 5907 -1 
Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/main.py	`83.58% <100.00%> (-0.05%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T21:34:51Z

📝 Docs preview for commit 2a91647 at: https://630a8dd6fbefa94700c71038--sqlmodel.netlify.app

yezz123 · 2022-08-27T21:46:43Z

Hello @tiangolo all the changes you asked for are done 🍰

github-actions · 2022-08-27T21:48:12Z

📝 Docs preview for commit 0c054ab at: https://630a90e8801d6f48588c8617--sqlmodel.netlify.app

tiangolo · 2022-08-27T23:52:55Z

Awesome, thanks @yezz123! 🍰

yezz123 added 3 commits August 28, 2021 16:38

chore : Hoist repeated code outside conditional statement
52b5c12

Merges multiple nested if conditions into one
0a5460b

Merge pull request#1from yezz123/chore
ff2beb7
Chore: Merges multiple nested if conditions into one

tiangolo requested changes Aug 27, 2022
View reviewed changes

Comment threadsqlmodel/main.py
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/sql/sqltypes.py Outdated

Merge branch 'main' into main
2a91647

yezz123 added 2 commits August 27, 2022 22:45

🔧 changes
eda3d8a

Merge branch 'main' into main
0c054ab

yezz123 requested a review from tiangolo August 27, 2022 21:46

tiangolo changed the title ~~Chore: Merges multiply nested if conditions into one and Replaces conditional assignment~~♻ Refactor internal statements to simplify codeAug 27, 2022

tiangolo merged commit 6216409 into fastapi:mainAug 27, 2022

yezz123 added 3 commits August 28, 2021 16:38

chore : Hoist repeated code outside conditional statement
52b5c12

Merges multiple nested if conditions into one
0a5460b

Merge pull request#1from yezz123/chore
ff2beb7
Chore: Merges multiple nested if conditions into one

tiangolo requested changes Aug 27, 2022
View reviewed changes

Comment threadsqlmodel/main.py
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/sql/sqltypes.py Outdated

Merge branch 'main' into main
2a91647

yezz123 added 2 commits August 27, 2022 22:45

🔧 changes
eda3d8a

Merge branch 'main' into main
0c054ab

yezz123 requested a review from tiangolo August 27, 2022 21:46

tiangolo changed the title ~~Chore: Merges multiply nested if conditions into one and Replaces conditional assignment~~♻ Refactor internal statements to simplify codeAug 27, 2022

tiangolo merged commit 6216409 into fastapi:mainAug 27, 2022

yezz123 added 3 commits August 28, 2021 16:38

chore : Hoist repeated code outside conditional statement
52b5c12

Merges multiple nested if conditions into one
0a5460b

Merge pull request#1from yezz123/chore
ff2beb7
Chore: Merges multiple nested if conditions into one

tiangolo requested changes Aug 27, 2022
View reviewed changes

Comment threadsqlmodel/main.py
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/sql/sqltypes.py Outdated

Merge branch 'main' into main
2a91647

yezz123 added 2 commits August 27, 2022 22:45

🔧 changes
eda3d8a

Merge branch 'main' into main
0c054ab

yezz123 requested a review from tiangolo August 27, 2022 21:46

tiangolo changed the title ~~Chore: Merges multiply nested if conditions into one and Replaces conditional assignment~~♻ Refactor internal statements to simplify codeAug 27, 2022

tiangolo merged commit 6216409 into fastapi:mainAug 27, 2022

yezz123 added 3 commits August 28, 2021 16:38

chore : Hoist repeated code outside conditional statement
52b5c12

Merges multiple nested if conditions into one
0a5460b

Merge pull request#1from yezz123/chore
ff2beb7
Chore: Merges multiple nested if conditions into one

tiangolo requested changes Aug 27, 2022
View reviewed changes

Comment threadsqlmodel/main.py
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/sql/sqltypes.py Outdated

Merge branch 'main' into main
2a91647

yezz123 added 2 commits August 27, 2022 22:45

🔧 changes
eda3d8a

Merge branch 'main' into main
0c054ab

yezz123 requested a review from tiangolo August 27, 2022 21:46

tiangolo changed the title ~~Chore: Merges multiply nested if conditions into one and Replaces conditional assignment~~♻ Refactor internal statements to simplify codeAug 27, 2022

tiangolo merged commit 6216409 into fastapi:mainAug 27, 2022

yezz123 added 3 commits August 28, 2021 16:38

chore : Hoist repeated code outside conditional statement
52b5c12

Merges multiple nested if conditions into one
0a5460b

Merge pull request#1from yezz123/chore
ff2beb7
Chore: Merges multiple nested if conditions into one

tiangolo requested changes Aug 27, 2022
View reviewed changes

Comment threadsqlmodel/main.py
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/sql/sqltypes.py Outdated

Merge branch 'main' into main
2a91647

yezz123 added 2 commits August 27, 2022 22:45

🔧 changes
eda3d8a

Merge branch 'main' into main
0c054ab

yezz123 requested a review from tiangolo August 27, 2022 21:46

tiangolo changed the title ~~Chore: Merges multiply nested if conditions into one and Replaces conditional assignment~~♻ Refactor internal statements to simplify codeAug 27, 2022

tiangolo merged commit 6216409 into fastapi:mainAug 27, 2022

yezz123 added 3 commits August 28, 2021 16:38

chore : Hoist repeated code outside conditional statement
52b5c12

Merges multiple nested if conditions into one
0a5460b

Merge pull request#1from yezz123/chore
ff2beb7
Chore: Merges multiple nested if conditions into one

tiangolo requested changes Aug 27, 2022
View reviewed changes

Comment threadsqlmodel/main.py
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/sql/sqltypes.py Outdated

Merge branch 'main' into main
2a91647

yezz123 added 2 commits August 27, 2022 22:45

🔧 changes
eda3d8a

Merge branch 'main' into main
0c054ab

yezz123 requested a review from tiangolo August 27, 2022 21:46

tiangolo changed the title ~~Chore: Merges multiply nested if conditions into one and Replaces conditional assignment~~♻ Refactor internal statements to simplify codeAug 27, 2022

tiangolo merged commit 6216409 into fastapi:mainAug 27, 2022

yezz123 added 3 commits August 28, 2021 16:38

chore : Hoist repeated code outside conditional statement
52b5c12

Merges multiple nested if conditions into one
0a5460b

Merge pull request#1from yezz123/chore
ff2beb7
Chore: Merges multiple nested if conditions into one

tiangolo requested changes Aug 27, 2022
View reviewed changes

Comment threadsqlmodel/main.py
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/sql/sqltypes.py Outdated

Merge branch 'main' into main
2a91647

yezz123 added 2 commits August 27, 2022 22:45

🔧 changes
eda3d8a

Merge branch 'main' into main
0c054ab

yezz123 requested a review from tiangolo August 27, 2022 21:46

tiangolo changed the title ~~Chore: Merges multiply nested if conditions into one and Replaces conditional assignment~~♻ Refactor internal statements to simplify codeAug 27, 2022

tiangolo merged commit 6216409 into fastapi:mainAug 27, 2022

yezz123 added 3 commits August 28, 2021 16:38

chore : Hoist repeated code outside conditional statement
52b5c12

Merges multiple nested if conditions into one
0a5460b

Merge pull request#1from yezz123/chore
ff2beb7
Chore: Merges multiple nested if conditions into one

tiangolo requested changes Aug 27, 2022
View reviewed changes

Comment threadsqlmodel/main.py
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/main.py Outdated
Comment threadsqlmodel/sql/sqltypes.py Outdated

Merge branch 'main' into main
2a91647

yezz123 added 2 commits August 27, 2022 22:45

🔧 changes
eda3d8a

Merge branch 'main' into main
0c054ab

yezz123 requested a review from tiangolo August 27, 2022 21:46

tiangolo changed the title ~~Chore: Merges multiply nested if conditions into one and Replaces conditional assignment~~♻ Refactor internal statements to simplify codeAug 27, 2022

tiangolo merged commit 6216409 into fastapi:mainAug 27, 2022

Uh oh!

Uh oh!

Conversation

yezz123 commented Aug 28, 2021

Uh oh!

tiangolo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 27, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsBot commented Aug 27, 2022

Uh oh!

yezz123 commented Aug 27, 2022

Uh oh!

github-actionsBot commented Aug 27, 2022

Uh oh!

tiangolo commented Aug 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

yezz123 commented Aug 28, 2021

Uh oh!

tiangolo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 27, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsBot commented Aug 27, 2022

Uh oh!

yezz123 commented Aug 27, 2022

Uh oh!

github-actionsBot commented Aug 27, 2022

Uh oh!

tiangolo commented Aug 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

yezz123 commented Aug 28, 2021

Uh oh!

tiangolo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Aug 27, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecovBot commented Aug 27, 2022•
edited
Loading

codecovBot commented Aug 27, 2022•
edited
Loading

codecovBot commented Aug 27, 2022•
edited
Loading

codecovBot commented Aug 27, 2022•
edited
Loading